From: Nathan Lynch <nathanl@linux.ibm.com>
To: Andrew Donnellan <ajd@linux.ibm.com>, linuxppc-dev@lists.ozlabs.org
Cc: Sathvika Vasireddy <sathvika@linux.ibm.com>, stable@vger.kernel.org
Subject: Re: [PATCH] powerpc/rtas: Allow ibm,platform-dump RTAS call with null buffer address
Date: Tue, 14 Jun 2022 10:21:44 -0500 [thread overview]
Message-ID: <87bkuv8e47.fsf@linux.ibm.com> (raw)
In-Reply-To: <20220614134952.156010-1-ajd@linux.ibm.com>
Andrew Donnellan <ajd@linux.ibm.com> writes:
> Add a special case to block_rtas_call() to allow the ibm,platform-dump RTAS
> call through the RTAS filter if the buffer address is 0.
>
> According to PAPR, ibm,platform-dump is called with a null buffer address
> to notify the platform firmware that processing of a particular dump is
> finished.
>
> Without this, on a pseries machine with CONFIG_PPC_RTAS_FILTER enabled, an
> application such as rtas_errd that is attempting to retrieve a dump will
> encounter an error at the end of the retrieval process.
>
> Fixes: bd59380c5ba4 ("powerpc/rtas: Restrict RTAS requests from userspace")
> Cc: stable@vger.kernel.org
> Reported-by: Sathvika Vasireddy <sathvika@linux.ibm.com>
> Signed-off-by: Andrew Donnellan <ajd@linux.ibm.com>
I agree this allows ibm,platform-dump to work without weakening the
filter for other calls. Thanks.
Reviewed-by: Nathan Lynch <nathanl@linux.ibm.com>
WARNING: multiple messages have this Message-ID (diff)
From: Nathan Lynch <nathanl@linux.ibm.com>
To: Andrew Donnellan <ajd@linux.ibm.com>, linuxppc-dev@lists.ozlabs.org
Cc: stable@vger.kernel.org, Sathvika Vasireddy <sathvika@linux.ibm.com>
Subject: Re: [PATCH] powerpc/rtas: Allow ibm,platform-dump RTAS call with null buffer address
Date: Tue, 14 Jun 2022 10:21:44 -0500 [thread overview]
Message-ID: <87bkuv8e47.fsf@linux.ibm.com> (raw)
In-Reply-To: <20220614134952.156010-1-ajd@linux.ibm.com>
Andrew Donnellan <ajd@linux.ibm.com> writes:
> Add a special case to block_rtas_call() to allow the ibm,platform-dump RTAS
> call through the RTAS filter if the buffer address is 0.
>
> According to PAPR, ibm,platform-dump is called with a null buffer address
> to notify the platform firmware that processing of a particular dump is
> finished.
>
> Without this, on a pseries machine with CONFIG_PPC_RTAS_FILTER enabled, an
> application such as rtas_errd that is attempting to retrieve a dump will
> encounter an error at the end of the retrieval process.
>
> Fixes: bd59380c5ba4 ("powerpc/rtas: Restrict RTAS requests from userspace")
> Cc: stable@vger.kernel.org
> Reported-by: Sathvika Vasireddy <sathvika@linux.ibm.com>
> Signed-off-by: Andrew Donnellan <ajd@linux.ibm.com>
I agree this allows ibm,platform-dump to work without weakening the
filter for other calls. Thanks.
Reviewed-by: Nathan Lynch <nathanl@linux.ibm.com>
next prev parent reply other threads:[~2022-06-14 15:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-14 13:49 [PATCH] powerpc/rtas: Allow ibm,platform-dump RTAS call with null buffer address Andrew Donnellan
2022-06-14 13:49 ` Andrew Donnellan
2022-06-14 15:21 ` Nathan Lynch [this message]
2022-06-14 15:21 ` Nathan Lynch
2022-06-14 16:28 ` Tyrel Datwyler
2022-06-14 16:28 ` Tyrel Datwyler
2022-06-19 11:55 ` Michael Ellerman
2022-06-19 11:55 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bkuv8e47.fsf@linux.ibm.com \
--to=nathanl@linux.ibm.com \
--cc=ajd@linux.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=sathvika@linux.ibm.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.