From: Jani Nikula <jani.nikula@linux.intel.com>
To: "José Expósito" <jose.exposito89@gmail.com>, javierm@redhat.com
Cc: davidgow@google.com, airlied@linux.ie, dlatypov@google.com,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
tzimmermann@suse.de, "José Expósito" <jose.exposito89@gmail.com>,
kunit-dev@googlegroups.com
Subject: Re: [PATCH v3 1/3] drm/rect: Add DRM_RECT_INIT() macro
Date: Mon, 13 Jun 2022 21:31:24 +0300 [thread overview]
Message-ID: <87bkuwza83.fsf@intel.com> (raw)
In-Reply-To: <20220613171738.111013-2-jose.exposito89@gmail.com>
On Mon, 13 Jun 2022, José Expósito <jose.exposito89@gmail.com> wrote:
> Add a helper macro to initialize a rectangle from x, y, width and
> height information.
>
> Signed-off-by: José Expósito <jose.exposito89@gmail.com>
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
> ---
> include/drm/drm_rect.h | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/include/drm/drm_rect.h b/include/drm/drm_rect.h
> index 6f6e19bd4dac..e8d94fca2703 100644
> --- a/include/drm/drm_rect.h
> +++ b/include/drm/drm_rect.h
> @@ -47,6 +47,22 @@ struct drm_rect {
> int x1, y1, x2, y2;
> };
>
> +/**
> + * DRM_RECT_INIT - initialize a rectangle from x/y/w/h
> + * @x: x coordinate
> + * @y: y coordinate
> + * @w: width
> + * @h: height
> + *
> + * RETURNS:
> + * A new rectangle of the specified size.
> + */
> +#define DRM_RECT_INIT(x, y, w, h) ((struct drm_rect){ \
> + .x1 = (x), \
> + .y1 = (y), \
> + .x2 = (x) + (w), \
> + .y2 = (y) + (h) })
> +
> /**
> * DRM_RECT_FMT - printf string for &struct drm_rect
> */
--
Jani Nikula, Intel Open Source Graphics Center
WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@linux.intel.com>
To: "José Expósito" <jose.exposito89@gmail.com>, javierm@redhat.com
Cc: davidgow@google.com, dlatypov@google.com, tzimmermann@suse.de,
maarten.lankhorst@linux.intel.com, mripard@kernel.org,
airlied@linux.ie, daniel@ffwll.ch,
dri-devel@lists.freedesktop.org, kunit-dev@googlegroups.com,
linux-kernel@vger.kernel.org,
"José Expósito" <jose.exposito89@gmail.com>
Subject: Re: [PATCH v3 1/3] drm/rect: Add DRM_RECT_INIT() macro
Date: Mon, 13 Jun 2022 21:31:24 +0300 [thread overview]
Message-ID: <87bkuwza83.fsf@intel.com> (raw)
In-Reply-To: <20220613171738.111013-2-jose.exposito89@gmail.com>
On Mon, 13 Jun 2022, José Expósito <jose.exposito89@gmail.com> wrote:
> Add a helper macro to initialize a rectangle from x, y, width and
> height information.
>
> Signed-off-by: José Expósito <jose.exposito89@gmail.com>
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
> ---
> include/drm/drm_rect.h | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/include/drm/drm_rect.h b/include/drm/drm_rect.h
> index 6f6e19bd4dac..e8d94fca2703 100644
> --- a/include/drm/drm_rect.h
> +++ b/include/drm/drm_rect.h
> @@ -47,6 +47,22 @@ struct drm_rect {
> int x1, y1, x2, y2;
> };
>
> +/**
> + * DRM_RECT_INIT - initialize a rectangle from x/y/w/h
> + * @x: x coordinate
> + * @y: y coordinate
> + * @w: width
> + * @h: height
> + *
> + * RETURNS:
> + * A new rectangle of the specified size.
> + */
> +#define DRM_RECT_INIT(x, y, w, h) ((struct drm_rect){ \
> + .x1 = (x), \
> + .y1 = (y), \
> + .x2 = (x) + (w), \
> + .y2 = (y) + (h) })
> +
> /**
> * DRM_RECT_FMT - printf string for &struct drm_rect
> */
--
Jani Nikula, Intel Open Source Graphics Center
next prev parent reply other threads:[~2022-06-13 18:31 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-13 17:17 [PATCH v3 0/3] KUnit tests for drm_format_helper José Expósito
2022-06-13 17:17 ` José Expósito
2022-06-13 17:17 ` [PATCH v3 1/3] drm/rect: Add DRM_RECT_INIT() macro José Expósito
2022-06-13 17:17 ` José Expósito
2022-06-13 18:31 ` Jani Nikula [this message]
2022-06-13 18:31 ` Jani Nikula
2022-06-13 17:17 ` [PATCH v3 2/3] drm/format-helper: Add KUnit tests for drm_fb_xrgb8888_to_rgb332() José Expósito
2022-06-13 17:17 ` José Expósito
2022-06-13 17:17 ` [PATCH v3 3/3] drm/doc: Add KUnit documentation José Expósito
2022-06-13 17:17 ` José Expósito
2022-06-14 12:58 ` Javier Martinez Canillas
2022-06-14 12:58 ` Javier Martinez Canillas
2022-06-14 18:09 ` José Expósito
2022-06-14 18:09 ` José Expósito
2022-06-14 18:14 ` Javier Martinez Canillas
2022-06-14 18:14 ` Javier Martinez Canillas
2022-06-24 21:01 ` Daniel Vetter
2022-06-24 21:01 ` Daniel Vetter
2022-06-24 21:18 ` Javier Martinez Canillas
2022-06-27 12:36 ` José Expósito
2022-06-27 12:36 ` José Expósito
2022-06-27 12:53 ` Javier Martinez Canillas
2022-06-27 12:53 ` Javier Martinez Canillas
2022-06-14 7:08 ` [PATCH v3 0/3] KUnit tests for drm_format_helper Thomas Zimmermann
2022-06-14 7:08 ` Thomas Zimmermann
2022-06-14 13:03 ` Javier Martinez Canillas
2022-06-14 13:03 ` Javier Martinez Canillas
2022-06-16 14:44 ` David Gow
2022-06-16 14:44 ` David Gow
2022-06-16 18:38 ` José Expósito
2022-06-16 18:38 ` José Expósito
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bkuwza83.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=airlied@linux.ie \
--cc=davidgow@google.com \
--cc=dlatypov@google.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=javierm@redhat.com \
--cc=jose.exposito89@gmail.com \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.