All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Corbet <corbet@lwn.net>
To: Desmond Cheong Zhi Xi <desmondcheongzx@gmail.com>,
	gregkh@linuxfoundation.org, jirislaby@kernel.org
Cc: Desmond Cheong Zhi Xi <desmondcheongzx@gmail.com>,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	skhan@linuxfoundation.org,
	linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [PATCH] Remove link to nonexistent rocket driver docs
Date: Tue, 11 May 2021 11:03:58 -0600	[thread overview]
Message-ID: <87bl9hdwxt.fsf@meer.lwn.net> (raw)
In-Reply-To: <20210511134937.2442291-1-desmondcheongzx@gmail.com>

Desmond Cheong Zhi Xi <desmondcheongzx@gmail.com> writes:

> Fixes: 3b00b6af7a5b ("tty: rocket, remove the driver")
> The rocket driver and documentation were removed in this commit, but
> the corresponding entry in index.rst was not removed.
>
> Signed-off-by: Desmond Cheong Zhi Xi <desmondcheongzx@gmail.com>

Please note: the "Fixes" tag should be down at the end with your
signoff. 

>  Documentation/driver-api/serial/index.rst | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/Documentation/driver-api/serial/index.rst b/Documentation/driver-api/serial/index.rst
> index 21351b8c95a4..8f7d7af3b90b 100644
> --- a/Documentation/driver-api/serial/index.rst
> +++ b/Documentation/driver-api/serial/index.rst
> @@ -19,7 +19,6 @@ Serial drivers
>  
>      moxa-smartio
>      n_gsm
> -    rocket
>      serial-iso7816
>      serial-rs485

Otherwise this looks like a good fix.  I've applied it (with Fixes in
the right place), thanks.

jon

WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Corbet <corbet@lwn.net>
To: Desmond Cheong Zhi Xi <desmondcheongzx@gmail.com>,
	gregkh@linuxfoundation.org, jirislaby@kernel.org
Cc: Desmond Cheong Zhi Xi <desmondcheongzx@gmail.com>,
	linux-kernel-mentees@lists.linuxfoundation.org,
	linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH] Remove link to nonexistent rocket driver docs
Date: Tue, 11 May 2021 11:03:58 -0600	[thread overview]
Message-ID: <87bl9hdwxt.fsf@meer.lwn.net> (raw)
In-Reply-To: <20210511134937.2442291-1-desmondcheongzx@gmail.com>

Desmond Cheong Zhi Xi <desmondcheongzx@gmail.com> writes:

> Fixes: 3b00b6af7a5b ("tty: rocket, remove the driver")
> The rocket driver and documentation were removed in this commit, but
> the corresponding entry in index.rst was not removed.
>
> Signed-off-by: Desmond Cheong Zhi Xi <desmondcheongzx@gmail.com>

Please note: the "Fixes" tag should be down at the end with your
signoff. 

>  Documentation/driver-api/serial/index.rst | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/Documentation/driver-api/serial/index.rst b/Documentation/driver-api/serial/index.rst
> index 21351b8c95a4..8f7d7af3b90b 100644
> --- a/Documentation/driver-api/serial/index.rst
> +++ b/Documentation/driver-api/serial/index.rst
> @@ -19,7 +19,6 @@ Serial drivers
>  
>      moxa-smartio
>      n_gsm
> -    rocket
>      serial-iso7816
>      serial-rs485

Otherwise this looks like a good fix.  I've applied it (with Fixes in
the right place), thanks.

jon
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

  reply	other threads:[~2021-05-11 17:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-11 13:49 [PATCH] Remove link to nonexistent rocket driver docs Desmond Cheong Zhi Xi
2021-05-11 13:49 ` Desmond Cheong Zhi Xi
2021-05-11 17:03 ` Jonathan Corbet [this message]
2021-05-11 17:03   ` Jonathan Corbet
2021-05-11 23:51   ` Desmond Cheong
2021-05-11 23:51     ` Desmond Cheong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bl9hdwxt.fsf@meer.lwn.net \
    --to=corbet@lwn.net \
    --cc=desmondcheongzx@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jirislaby@kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel-mentees@lists.linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.