From: Gregory CLEMENT <gregory.clement@bootlin.com>
To: Rosen Penev <rosenp@gmail.com>, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] ARM: dts: armada388-helios4: assign pinctrl to LEDs
Date: Fri, 29 Jan 2021 16:27:40 +0100 [thread overview]
Message-ID: <87bld7u5jn.fsf@BL-laptop> (raw)
In-Reply-To: <20201203022321.19952-1-rosenp@gmail.com>
Hi Rosen,
> Split up the pins to match earlier definitions. Allows LEDs to flash
> properly.
>
> Fixes: ced8025b569e ("ARM: dts: armada388-helios4")
>
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
Applied on mvebu/dt
Thanks,
Gregory
> ---
> arch/arm/boot/dts/armada-388-helios4.dts | 15 ++++++++++++---
> 1 file changed, 12 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/boot/dts/armada-388-helios4.dts b/arch/arm/boot/dts/armada-388-helios4.dts
> index b3728de3bd3f..5a6af7e83e44 100644
> --- a/arch/arm/boot/dts/armada-388-helios4.dts
> +++ b/arch/arm/boot/dts/armada-388-helios4.dts
> @@ -70,6 +70,9 @@
>
> system-leds {
> compatible = "gpio-leds";
> + pinctrl-names = "default";
> + pinctrl-0 = <&helios_system_led_pins>;
> +
> status-led {
> label = "helios4:green:status";
> gpios = <&gpio0 24 GPIO_ACTIVE_LOW>;
> @@ -86,6 +89,9 @@
>
> io-leds {
> compatible = "gpio-leds";
> + pinctrl-names = "default";
> + pinctrl-0 = <&helios_io_led_pins>;
> +
> sata1-led {
> label = "helios4:green:ata1";
> gpios = <&gpio1 17 GPIO_ACTIVE_LOW>;
> @@ -286,9 +292,12 @@
> "mpp39", "mpp40";
> marvell,function = "sd0";
> };
> - helios_led_pins: helios-led-pins {
> - marvell,pins = "mpp24", "mpp25",
> - "mpp49", "mpp50",
> + helios_system_led_pins: helios-system-led-pins {
> + marvell,pins = "mpp24", "mpp25";
> + marvell,function = "gpio";
> + };
> + helios_io_led_pins: helios-io-led-pins {
> + marvell,pins = "mpp49", "mpp50",
> "mpp52", "mpp53",
> "mpp54";
> marvell,function = "gpio";
> --
> 2.17.1
>
--
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2021-01-29 15:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-03 2:23 [PATCH 1/2] ARM: dts: armada388-helios4: assign pinctrl to LEDs Rosen Penev
2020-12-03 2:23 ` [PATCH 2/2] ARM: dts: armada388-helios4: assign pinctrl to each fan Rosen Penev
2021-01-29 15:27 ` Gregory CLEMENT
2021-01-29 15:27 ` Gregory CLEMENT [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bld7u5jn.fsf@BL-laptop \
--to=gregory.clement@bootlin.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=rosenp@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.