From: "Alex Bennée" <alex.bennee@linaro.org>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: qemu-devel@nongnu.org, "Fam Zheng" <fam@euphon.net>,
qemu-trivial@nongnu.org,
"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: Re: [PATCH] tests/docker: Fix typo in help message
Date: Tue, 19 Jan 2021 11:22:25 +0000 [thread overview]
Message-ID: <87bldluq6i.fsf@linaro.org> (raw)
In-Reply-To: <20210119052120.522069-1-f4bug@amsat.org>
Philippe Mathieu-Daudé <f4bug@amsat.org> writes:
> To have the variable properly passed, we need to set it,
> ie. NOUSER=1. Fix the message displayed by 'make docker'.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Queued to testing/next, thanks.
> ---
> tests/docker/Makefile.include | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include
> index 0779dab5b96..bdc53ddfcf9 100644
> --- a/tests/docker/Makefile.include
> +++ b/tests/docker/Makefile.include
> @@ -209,7 +209,7 @@ endif
> @echo ' before running the command.'
> @echo ' NETWORK=1 Enable virtual network interface with default backend.'
> @echo ' NETWORK=$$BACKEND Enable virtual network interface with $$BACKEND.'
> - @echo ' NOUSER Define to disable adding current user to containers passwd.'
> + @echo ' NOUSER=1 Define to disable adding current user to containers passwd.'
> @echo ' NOCACHE=1 Ignore cache when build images.'
> @echo ' EXECUTABLE=<path> Include executable in image.'
> @echo ' EXTRA_FILES="<path> [... <path>]"'
--
Alex Bennée
WARNING: multiple messages have this Message-ID (diff)
From: "Alex Bennée" <alex.bennee@linaro.org>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: "Fam Zheng" <fam@euphon.net>,
qemu-trivial@nongnu.org,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [PATCH] tests/docker: Fix typo in help message
Date: Tue, 19 Jan 2021 11:22:25 +0000 [thread overview]
Message-ID: <87bldluq6i.fsf@linaro.org> (raw)
In-Reply-To: <20210119052120.522069-1-f4bug@amsat.org>
Philippe Mathieu-Daudé <f4bug@amsat.org> writes:
> To have the variable properly passed, we need to set it,
> ie. NOUSER=1. Fix the message displayed by 'make docker'.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Queued to testing/next, thanks.
> ---
> tests/docker/Makefile.include | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include
> index 0779dab5b96..bdc53ddfcf9 100644
> --- a/tests/docker/Makefile.include
> +++ b/tests/docker/Makefile.include
> @@ -209,7 +209,7 @@ endif
> @echo ' before running the command.'
> @echo ' NETWORK=1 Enable virtual network interface with default backend.'
> @echo ' NETWORK=$$BACKEND Enable virtual network interface with $$BACKEND.'
> - @echo ' NOUSER Define to disable adding current user to containers passwd.'
> + @echo ' NOUSER=1 Define to disable adding current user to containers passwd.'
> @echo ' NOCACHE=1 Ignore cache when build images.'
> @echo ' EXECUTABLE=<path> Include executable in image.'
> @echo ' EXTRA_FILES="<path> [... <path>]"'
--
Alex Bennée
next prev parent reply other threads:[~2021-01-19 11:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-19 5:21 [PATCH] tests/docker: Fix typo in help message Philippe Mathieu-Daudé
2021-01-19 5:21 ` Philippe Mathieu-Daudé
2021-01-19 11:22 ` Alex Bennée [this message]
2021-01-19 11:22 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bldluq6i.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=f4bug@amsat.org \
--cc=fam@euphon.net \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.