From: "Keith Packard" <keithp@keithp.com>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: Peter Maydell <peter.maydell@linaro.org>,
QEMU Developers <qemu-devel@nongnu.org>,
Laurent Vivier <laurent@vivier.eu>,
"qemu-arm@nongnu.org" <qemu-arm@nongnu.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
Alistair Francis <Alistair.Francis@wdc.com>,
Sagar Karandikar <sagark@eecs.berkeley.edu>,
Bastian Koppelmann <kbastian@mail.uni-paderborn.de>,
"open list:RISC-V" <qemu-riscv@nongnu.org>
Subject: Re: [PATCH 1/4] semihosting: Move ARM semihosting code to shared directories
Date: Wed, 28 Oct 2020 08:37:55 -0700 [thread overview]
Message-ID: <87blgme4z0.fsf@keithp.com> (raw)
In-Reply-To: <87lffqmwi6.fsf@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 581 bytes --]
Alex Bennée <alex.bennee@linaro.org> writes:
> I don't think we want arm specific adds in the common code. I think what
> Peter was suggesting is a new config symbol that only ARM and RISC
> define, e.g something like:
>
> specific_ss.add(when: 'CONFIG_ARM_STYLE_SEMIHOSTING',
> if_true: files ('common-semi.c'))
>
> or some other suitably descriptive symbol. Otherwise you have to keep
> adding an foo_ss.add line for each architecture that wants it.
Sure, that will also work, just a few lines of additional config file
stuff.
--
-keith
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: "Keith Packard" via <qemu-devel@nongnu.org>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: Peter Maydell <peter.maydell@linaro.org>,
QEMU Developers <qemu-devel@nongnu.org>,
Laurent Vivier <laurent@vivier.eu>,
"qemu-arm@nongnu.org" <qemu-arm@nongnu.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
Alistair Francis <Alistair.Francis@wdc.com>,
Sagar Karandikar <sagark@eecs.berkeley.edu>,
Bastian Koppelmann <kbastian@mail.uni-paderborn.de>,
"open list:RISC-V" <qemu-riscv@nongnu.org>
Subject: Re: [PATCH 1/4] semihosting: Move ARM semihosting code to shared directories
Date: Wed, 28 Oct 2020 08:37:55 -0700 [thread overview]
Message-ID: <87blgme4z0.fsf@keithp.com> (raw)
In-Reply-To: <87lffqmwi6.fsf@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 581 bytes --]
Alex Bennée <alex.bennee@linaro.org> writes:
> I don't think we want arm specific adds in the common code. I think what
> Peter was suggesting is a new config symbol that only ARM and RISC
> define, e.g something like:
>
> specific_ss.add(when: 'CONFIG_ARM_STYLE_SEMIHOSTING',
> if_true: files ('common-semi.c'))
>
> or some other suitably descriptive symbol. Otherwise you have to keep
> adding an foo_ss.add line for each architecture that wants it.
Sure, that will also work, just a few lines of additional config file
stuff.
--
-keith
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2020-10-28 15:38 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-26 21:28 [PATCH 0/4] riscv: Add semihosting support [v10] Keith Packard
2020-10-26 21:28 ` Keith Packard via
2020-10-26 21:28 ` [PATCH 1/4] semihosting: Move ARM semihosting code to shared directories Keith Packard
2020-10-26 21:28 ` Keith Packard via
2020-10-27 20:32 ` Alistair Francis
2020-10-27 20:32 ` Alistair Francis
2020-10-27 21:20 ` Peter Maydell
2020-10-27 21:20 ` Peter Maydell
2020-10-27 21:56 ` Keith Packard
2020-10-27 21:56 ` Keith Packard via
2020-10-27 23:38 ` Peter Maydell
2020-10-27 23:38 ` Peter Maydell
2020-10-28 1:33 ` Keith Packard
2020-10-28 1:33 ` Keith Packard via
2020-10-28 11:16 ` Alex Bennée
2020-10-28 15:37 ` Keith Packard [this message]
2020-10-28 15:37 ` Keith Packard via
2020-10-28 19:14 ` Keith Packard
2020-10-28 19:14 ` Keith Packard via
2020-10-26 21:28 ` [PATCH 2/4] semihosting: Change common-semi API to be architecture-independent Keith Packard
2020-10-26 21:28 ` Keith Packard via
2020-10-26 21:28 ` [PATCH 3/4] semihosting: Change internal common-semi interfaces to use CPUState * Keith Packard
2020-10-26 21:28 ` Keith Packard via
2020-10-26 21:28 ` [PATCH 4/4] riscv: Add semihosting support [v10] Keith Packard
2020-10-26 21:28 ` Keith Packard via
2020-10-26 21:42 ` [PATCH 0/4] " no-reply
2020-10-26 21:42 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87blgme4z0.fsf@keithp.com \
--to=keithp@keithp.com \
--cc=Alistair.Francis@wdc.com \
--cc=alex.bennee@linaro.org \
--cc=kbastian@mail.uni-paderborn.de \
--cc=laurent@vivier.eu \
--cc=palmer@dabbelt.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=sagark@eecs.berkeley.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.