From: Markus Armbruster <armbru@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: duboisj@gmail.com, qemu-trivial@nongnu.org,
qemu-devel@nongnu.org, Josh DuBois <josh@joshdubois.com>
Subject: Re: [PATCH] trace/simple: Enable tracing on startup only if the user specifies a trace option
Date: Tue, 20 Oct 2020 11:19:52 +0200 [thread overview]
Message-ID: <87blgxfe4n.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <87lfgt3u0i.fsf@dusky.pond.sub.org> (Markus Armbruster's message of "Tue, 29 Sep 2020 09:46:21 +0200")
Markus Armbruster <armbru@redhat.com> writes:
> Stefan Hajnoczi <stefanha@gmail.com> writes:
>
>> On Sun, Aug 16, 2020 at 12:46:10PM -0500, duboisj@gmail.com wrote:
>>> From: Josh DuBois <josh@joshdubois.com>
>>>
>>> Tracing can be enabled at the command line or via the
>>> monitor. Command-line trace options are recorded during
>>> trace_opt_parse(), but tracing is not enabled until the various
>>> front-ends later call trace_init_file(). If the user passes a trace
>>> option on the command-line, remember that and enable tracing during
>>> trace_init_file(). Otherwise, trace_init_file() should record the
>>> trace file specified by the frontend and avoid enabling traces
>>> until the user requests them via the monitor.
>>>
>>> This fixes 1b7157be3a8c4300fc8044d40f4b2e64a152a1b4 and also
>>> db25d56c014aa1a96319c663e0a60346a223b31e, by allowing the user
>>> to enable traces on the command line and also avoiding
>>> unwanted trace-<pid> files when the user has not asked for them.
>>>
>>> Fixes: 1b7157be3a8c4300fc8044d40f4b2e64a152a1b4
>>> Signed-off-by: Josh DuBois <josh@joshdubois.com>
>>> ---
>>> trace/control.c | 6 +++++-
>>> 1 file changed, 5 insertions(+), 1 deletion(-)
>>
>> Thanks, applied to my tracing-next tree:
>> https://github.com/stefanha/qemu/commits/tracing-next
>>
>> Stefan
>
> Pull request?
Pretty-please?
WARNING: multiple messages have this Message-ID (diff)
From: Markus Armbruster <armbru@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: qemu-trivial@nongnu.org, duboisj@gmail.com,
qemu-devel@nongnu.org, Josh DuBois <josh@joshdubois.com>
Subject: Re: [PATCH] trace/simple: Enable tracing on startup only if the user specifies a trace option
Date: Tue, 20 Oct 2020 11:19:52 +0200 [thread overview]
Message-ID: <87blgxfe4n.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <87lfgt3u0i.fsf@dusky.pond.sub.org> (Markus Armbruster's message of "Tue, 29 Sep 2020 09:46:21 +0200")
Markus Armbruster <armbru@redhat.com> writes:
> Stefan Hajnoczi <stefanha@gmail.com> writes:
>
>> On Sun, Aug 16, 2020 at 12:46:10PM -0500, duboisj@gmail.com wrote:
>>> From: Josh DuBois <josh@joshdubois.com>
>>>
>>> Tracing can be enabled at the command line or via the
>>> monitor. Command-line trace options are recorded during
>>> trace_opt_parse(), but tracing is not enabled until the various
>>> front-ends later call trace_init_file(). If the user passes a trace
>>> option on the command-line, remember that and enable tracing during
>>> trace_init_file(). Otherwise, trace_init_file() should record the
>>> trace file specified by the frontend and avoid enabling traces
>>> until the user requests them via the monitor.
>>>
>>> This fixes 1b7157be3a8c4300fc8044d40f4b2e64a152a1b4 and also
>>> db25d56c014aa1a96319c663e0a60346a223b31e, by allowing the user
>>> to enable traces on the command line and also avoiding
>>> unwanted trace-<pid> files when the user has not asked for them.
>>>
>>> Fixes: 1b7157be3a8c4300fc8044d40f4b2e64a152a1b4
>>> Signed-off-by: Josh DuBois <josh@joshdubois.com>
>>> ---
>>> trace/control.c | 6 +++++-
>>> 1 file changed, 5 insertions(+), 1 deletion(-)
>>
>> Thanks, applied to my tracing-next tree:
>> https://github.com/stefanha/qemu/commits/tracing-next
>>
>> Stefan
>
> Pull request?
Pretty-please?
next prev parent reply other threads:[~2020-10-20 9:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-16 17:46 [PATCH] trace/simple: Enable tracing on startup only if the user specifies a trace option duboisj
2020-09-03 11:48 ` Markus Armbruster
2020-09-03 11:48 ` Markus Armbruster
2020-09-11 5:03 ` Markus Armbruster
2020-09-11 5:03 ` Markus Armbruster
2020-09-11 10:08 ` Stefan Hajnoczi
2020-09-11 10:08 ` Stefan Hajnoczi
2020-09-29 7:46 ` Markus Armbruster
2020-09-29 7:46 ` Markus Armbruster
2020-10-20 9:19 ` Markus Armbruster [this message]
2020-10-20 9:19 ` Markus Armbruster
2020-10-20 19:29 ` Josh DuBois
2020-10-20 19:29 ` Josh DuBois
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87blgxfe4n.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=duboisj@gmail.com \
--cc=josh@joshdubois.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.