From: "Alex Bennée" <alex.bennee@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-arm@nongnu.org, qemu-devel@nongnu.org,
Richard Henderson <richard.henderson@linaro.org>
Subject: Re: [PATCH 1/2] arm.risu: Correct VLDR/VSTR U=0 patterns
Date: Mon, 14 Sep 2020 14:42:03 +0100 [thread overview]
Message-ID: <87bli81nmc.fsf@linaro.org> (raw)
In-Reply-To: <20200901162046.32670-2-peter.maydell@linaro.org>
Peter Maydell <peter.maydell@linaro.org> writes:
> Correct the VLDR and VSTR patterns, which claimed to be setting U=0
> but in fact left it identical to the U=1 pattern due to a
> cut-and-paste error.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> Somehow the pre-generated test binaries I have from Alex have
> U=0 insns in them -- I suspect this got fixed locally but never
> made it upstream ?
Hmm my current set of aarch32 test patterns have U=1 throughout. So if
it did get fixed locally it also got lost.
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
--
Alex Bennée
WARNING: multiple messages have this Message-ID (diff)
From: "Alex Bennée" <alex.bennee@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-arm@nongnu.org,
Richard Henderson <richard.henderson@linaro.org>,
qemu-devel@nongnu.org
Subject: Re: [PATCH 1/2] arm.risu: Correct VLDR/VSTR U=0 patterns
Date: Mon, 14 Sep 2020 14:42:03 +0100 [thread overview]
Message-ID: <87bli81nmc.fsf@linaro.org> (raw)
In-Reply-To: <20200901162046.32670-2-peter.maydell@linaro.org>
Peter Maydell <peter.maydell@linaro.org> writes:
> Correct the VLDR and VSTR patterns, which claimed to be setting U=0
> but in fact left it identical to the U=1 pattern due to a
> cut-and-paste error.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> Somehow the pre-generated test binaries I have from Alex have
> U=0 insns in them -- I suspect this got fixed locally but never
> made it upstream ?
Hmm my current set of aarch32 test patterns have U=1 throughout. So if
it did get fixed locally it also got lost.
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
--
Alex Bennée
next prev parent reply other threads:[~2020-09-14 13:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-01 16:20 [RISU PATCH 0/2] arm.risu: two minor fixes Peter Maydell
2020-09-01 16:20 ` Peter Maydell
2020-09-01 16:20 ` [PATCH 1/2] arm.risu: Correct VLDR/VSTR U=0 patterns Peter Maydell
2020-09-01 16:20 ` Peter Maydell
2020-09-14 13:42 ` Alex Bennée [this message]
2020-09-14 13:42 ` Alex Bennée
2020-09-14 13:44 ` Peter Maydell
2020-09-14 13:44 ` Peter Maydell
2020-09-01 16:20 ` [PATCH 2/2] arm.risu: Fix typo in VCVT_B_TT pattern name Peter Maydell
2020-09-01 16:20 ` Peter Maydell
2020-09-14 13:42 ` Alex Bennée
2020-09-14 13:42 ` Alex Bennée
2020-09-10 19:54 ` [RISU PATCH 0/2] arm.risu: two minor fixes Peter Maydell
2020-09-10 19:54 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bli81nmc.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.