All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Michael <fedora.dm0@gmail.com>
To: grub-devel@gnu.org
Subject: [PATCH] generic/blocklist: Fix flag name
Date: Fri, 05 Jul 2019 07:45:59 -0400	[thread overview]
Message-ID: <87bly8r9fs.fsf@gmail.com> (raw)

Signed-off-by: David Michael <fedora.dm0@gmail.com>
---

Hi,

I tried to test the new release and hit this build failure:

In file included from ../grub-core/osdep/blocklist.c:6:0:
../grub-core/osdep/generic/blocklist.c: In function ‘grub_install_get_blocklist’:
../grub-core/osdep/generic/blocklist.c:62:67: error: ‘FILE_TYPE_NO_DECOMPRESS’ undeclared (first use in this function); did you mean ‘GRUB_FILE_TYPE_NO_DECOMPRESS’?
       file = grub_file_open (core_path_dev, GRUB_FILE_TYPE_NONE | FILE_TYPE_NO_DECOMPRESS);
                                                                   ^~~~~~~~~~~~~~~~~~~~~~~
                                                                   GRUB_FILE_TYPE_NO_DECOMPRESS
../grub-core/osdep/generic/blocklist.c:62:67: note: each undeclared identifier is reported only once for each function it appears in

It seems to be fixed by this change.  Can it be applied for the next release?

Thanks.

David

 grub-core/osdep/generic/blocklist.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/grub-core/osdep/generic/blocklist.c b/grub-core/osdep/generic/blocklist.c
index ea2a511b6..2d9040302 100644
--- a/grub-core/osdep/generic/blocklist.c
+++ b/grub-core/osdep/generic/blocklist.c
@@ -59,7 +59,7 @@ grub_install_get_blocklist (grub_device_t root_dev,
 
       grub_disk_cache_invalidate_all ();
 
-      file = grub_file_open (core_path_dev, GRUB_FILE_TYPE_NONE | FILE_TYPE_NO_DECOMPRESS);
+      file = grub_file_open (core_path_dev, GRUB_FILE_TYPE_NONE | GRUB_FILE_TYPE_NO_DECOMPRESS);
       if (file)
 	{
 	  if (grub_file_size (file) != core_size)
@@ -116,7 +116,7 @@ grub_install_get_blocklist (grub_device_t root_dev,
 
   grub_file_t file;
   /* Now read the core image to determine where the sectors are.  */
-  file = grub_file_open (core_path_dev, GRUB_FILE_TYPE_NONE | FILE_TYPE_NO_DECOMPRESS);
+  file = grub_file_open (core_path_dev, GRUB_FILE_TYPE_NONE | GRUB_FILE_TYPE_NO_DECOMPRESS);
   if (! file)
     grub_util_error ("%s", grub_errmsg);
 
-- 
2.20.1



             reply	other threads:[~2019-07-05 11:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-05 11:45 David Michael [this message]
2019-07-05 22:03 ` [PATCH] generic/blocklist: Fix flag name Daniel Kiper
2019-07-05 22:25   ` David Michael

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bly8r9fs.fsf@gmail.com \
    --to=fedora.dm0@gmail.com \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.