Re: [Qemu-trivial] [Qemu-devel] [PATCH v2 03/11] hw/devices: Move TC6393XB declarations into a new header

[Markus Armbruster <armbru@redhat.com>]

Philippe Mathieu-Daudé <philmd@redhat.com> writes:

> The TC6393XB_RAM definition introduced in 64b40bc54a9 is no
> more used since a0b753dfd39. Remove it.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
[...]
> diff --git a/include/hw/display/tc6393xb.h b/include/hw/display/tc6393xb.h
> new file mode 100644
> index 0000000000..387c143b44
> --- /dev/null
> +++ b/include/hw/display/tc6393xb.h
> @@ -0,0 +1,26 @@
> +/*
> + * Toshiba TC6393XB I/O Controller.
> + * Found in Sharp Zaurus SL-6000 (tosa) or some
> + * Toshiba e-Series PDAs.
> + *
> + * Copyright (c) 2007 Hervé Poussineau
> + *
> + * This work is licensed under the terms of the GNU GPL, version 2 or later.
> + * See the COPYING file in the top-level directory.
> + */
> +
> +#ifndef HW_DISPLAY_TC6393XB_H
> +#define HW_DISPLAY_TC6393XB_H
> +
> +#include "exec/memory.h"
> +#include "hw/irq.h"
> +
> +typedef struct TC6393xbState TC6393xbState;
> +
> +TC6393xbState *tc6393xb_init(struct MemoryRegion *sysmem,
> +                             uint32_t base, qemu_irq irq);
> +void tc6393xb_gpio_out_set(TC6393xbState *s, int line, qemu_irq handler);
> +qemu_irq *tc6393xb_gpio_in_get(TC6393xbState *s);

These two are actually unused.  Just an observation; I don't think this
patch should do anything about it.

> +qemu_irq tc6393xb_l3v_get(TC6393xbState *s);
> +
> +#endif