From: Markus Armbruster <armbru@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-trivial@nongnu.org,
pbonzini@redhat.com, xiezhide@huawei.com
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH v2] qapi: Reduce Makefile boilerplate
Date: Fri, 16 Nov 2018 11:17:25 +0100 [thread overview]
Message-ID: <87bm6p72dm.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <20181115225052.1322639-1-eblake@redhat.com> (Eric Blake's message of "Thu, 15 Nov 2018 16:50:52 -0600")
Eric Blake <eblake@redhat.com> writes:
> Adding a new qapi module requires some rather tedious repetition to
> wire it into Makefile and Makefile.objs. Add some indirection by
> taking advantage of GNU Make string processing to expand a list
> of module names into all the required artifacts, so that future
> additions of a new module need only touch the list of module names.
>
> The list has to live in Makefile.objs, due to the way that
> unnest-vars slirps in that file without remembering any definition
> of $(QAPI_MODULES) from Makefile.
>
> Signed-off-by: Eric Blake <eblake@redhat.com>
>
> ---
> v2: also condense Makefile.objs, prefer $(FOO:%=a%b) over
> %(patsubst %,a%b,$(foo))
> ---
> Makefile | 192 ++++++--------------------------------------------
> Makefile.objs | 75 ++------------------
> 2 files changed, 30 insertions(+), 237 deletions(-)
Lovely diffstat.
Reviewed-by: Markus Armbruster <armbru@redhat.com>
WARNING: multiple messages have this Message-ID (diff)
From: Markus Armbruster <armbru@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-trivial@nongnu.org,
pbonzini@redhat.com, xiezhide@huawei.com
Subject: Re: [Qemu-devel] [PATCH v2] qapi: Reduce Makefile boilerplate
Date: Fri, 16 Nov 2018 11:17:25 +0100 [thread overview]
Message-ID: <87bm6p72dm.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <20181115225052.1322639-1-eblake@redhat.com> (Eric Blake's message of "Thu, 15 Nov 2018 16:50:52 -0600")
Eric Blake <eblake@redhat.com> writes:
> Adding a new qapi module requires some rather tedious repetition to
> wire it into Makefile and Makefile.objs. Add some indirection by
> taking advantage of GNU Make string processing to expand a list
> of module names into all the required artifacts, so that future
> additions of a new module need only touch the list of module names.
>
> The list has to live in Makefile.objs, due to the way that
> unnest-vars slirps in that file without remembering any definition
> of $(QAPI_MODULES) from Makefile.
>
> Signed-off-by: Eric Blake <eblake@redhat.com>
>
> ---
> v2: also condense Makefile.objs, prefer $(FOO:%=a%b) over
> %(patsubst %,a%b,$(foo))
> ---
> Makefile | 192 ++++++--------------------------------------------
> Makefile.objs | 75 ++------------------
> 2 files changed, 30 insertions(+), 237 deletions(-)
Lovely diffstat.
Reviewed-by: Markus Armbruster <armbru@redhat.com>
next prev parent reply other threads:[~2018-11-16 10:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-15 22:50 [Qemu-trivial] [PATCH v2] qapi: Reduce Makefile boilerplate Eric Blake
2018-11-15 22:50 ` [Qemu-devel] " Eric Blake
2018-11-15 22:59 ` [Qemu-trivial] " Paolo Bonzini
2018-11-15 22:59 ` [Qemu-devel] " Paolo Bonzini
2018-11-16 10:17 ` Markus Armbruster [this message]
2018-11-16 10:17 ` Markus Armbruster
2018-11-16 10:26 ` [Qemu-trivial] " Daniel P. Berrangé
2018-11-16 10:26 ` Daniel P. Berrangé
2018-11-16 15:06 ` [Qemu-trivial] " Eric Blake
2018-11-16 15:06 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bm6p72dm.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=xiezhide@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.