Re: [Qemu-devel] [PATCH 1/4] qemu-options: Remove remainders of the -tdf option

[Markus Armbruster <armbru@redhat.com>]

Thomas Huth <thuth@redhat.com> writes:

> The -tdf options has been removed with d07aa197c5a1556449361a0cbb5108e2,
> but apparently I forgot to remove the corresponding two lines from
> qemu-options.hx.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  qemu-options.hx | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/qemu-options.hx b/qemu-options.hx
> index c611766..44daa10 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -3924,9 +3924,6 @@ DEF("no-kvm-pit-reinjection", 0, QEMU_OPTION_no_kvm_pit_reinjection,
>  HXCOMM Deprecated by -machine kernel_irqchip=on|off property
>  DEF("no-kvm-irqchip", 0, QEMU_OPTION_no_kvm_irqchip, "", QEMU_ARCH_I386)
>  
> -HXCOMM Deprecated (ignored)
> -DEF("tdf", 0, QEMU_OPTION_tdf,"", QEMU_ARCH_ALL)
> -
>  DEF("msg", HAS_ARG, QEMU_OPTION_msg,
>      "-msg timestamp[=on|off]\n"
>      "                change the format of messages\n"

Makes me wonder what happens when you specify --tdf.  Aha: nothing.
Why?  main() passes unknown options to os_parse_cmd_args(), which
happily ignores them.  Its function comment "return 0 if option handled,
-1 otherwise" is bogus.  Needs cleanup.  Separate patch, not necessarily
in this series.

Suggest to mention in your commit message that --tdf is silently
ignored.  Feel free to also point out the need for cleanup there.

Reviewed-by: Markus Armbruster <armbru@redhat.com>