From: Gregory CLEMENT <gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: Thomas Petazzoni
<thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Cc: "Jisheng Zhang"
<Jisheng.Zhang-Gq53QDLGkWKakBO8gow8eQ@public.gmane.org>,
"Rob Herring" <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"Mark Rutland" <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
"Ulf Hansson"
<ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
"Adrian Hunter"
<adrian.hunter-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
"Andrew Lunn" <andrew-g2DYL2Zd6BY@public.gmane.org>,
"Yehuda Yitschak"
<yehuday-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>,
"Jason Cooper" <jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>,
"Antoine Tenart"
<antoine.tenart-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
"Omri Itach" <omrii-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>,
Stable <stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"Nadav Haklai" <nadavh-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>,
"Shadi Ammouri" <shadi-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>,
"Igal Liberman" <igall-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>,
"Miquèl Raynal"
<miquel.raynal-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
"Marcin Wojtas" <mw-nYOzD4b6Jr9Wk0Htik3J/w@public.gmane.org>,
"Hanna Hawa" <hannah-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH] mmc: sdhci-xenon: Fix clock resource by adding an optional bus clock
Date: Fri, 29 Sep 2017 11:22:05 +0200 [thread overview]
Message-ID: <87bmlthnb6.fsf@free-electrons.com> (raw)
In-Reply-To: <20170929111550.065e7948-dFHcqWZE4nf+AlalS6MPSg@public.gmane.org> (Thomas Petazzoni's message of "Fri, 29 Sep 2017 11:15:50 +0200")
Hi Thomas,
On ven., sept. 29 2017, Thomas Petazzoni <thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote:
> Hello,
>
> On Fri, 29 Sep 2017 11:13:00 +0200, Gregory CLEMENT wrote:
>
>> >> - clock-names:
>> >> Array of names corresponding to clocks property.
>> >> The input clock for Xenon IP core should be named as "core".
>> >> + The input clock for the AXI bus must be named as "axi".
>> >
>> > Is "bus" more suitable?
>>
>> I find bus too vague.
>
> Actually no, I believe "bus" is more common. Indeed, you could have the
> same IP, attached to a different interconnect I guess.
>
>> >> /*
>> >> * Link Xenon specific mmc_host_ops function,
>> >> @@ -491,9 +493,20 @@ static int xenon_probe(struct platform_device *pdev)
>> >> if (err)
>> >> goto free_pltfm;
>> >>
>> >> + priv->axi_clk = devm_clk_get(&pdev->dev, "axi");
>> >> + if (IS_ERR(priv->axi_clk)) {
>
> -EPROBE_DEFER handling ?
See
http://lists.infradead.org/pipermail/linux-arm-kernel/2017-September/533510.html
Gregory
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: gregory.clement@free-electrons.com (Gregory CLEMENT)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] mmc: sdhci-xenon: Fix clock resource by adding an optional bus clock
Date: Fri, 29 Sep 2017 11:22:05 +0200 [thread overview]
Message-ID: <87bmlthnb6.fsf@free-electrons.com> (raw)
In-Reply-To: <20170929111550.065e7948@windsurf.lan> (Thomas Petazzoni's message of "Fri, 29 Sep 2017 11:15:50 +0200")
Hi Thomas,
On ven., sept. 29 2017, Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote:
> Hello,
>
> On Fri, 29 Sep 2017 11:13:00 +0200, Gregory CLEMENT wrote:
>
>> >> - clock-names:
>> >> Array of names corresponding to clocks property.
>> >> The input clock for Xenon IP core should be named as "core".
>> >> + The input clock for the AXI bus must be named as "axi".
>> >
>> > Is "bus" more suitable?
>>
>> I find bus too vague.
>
> Actually no, I believe "bus" is more common. Indeed, you could have the
> same IP, attached to a different interconnect I guess.
>
>> >> /*
>> >> * Link Xenon specific mmc_host_ops function,
>> >> @@ -491,9 +493,20 @@ static int xenon_probe(struct platform_device *pdev)
>> >> if (err)
>> >> goto free_pltfm;
>> >>
>> >> + priv->axi_clk = devm_clk_get(&pdev->dev, "axi");
>> >> + if (IS_ERR(priv->axi_clk)) {
>
> -EPROBE_DEFER handling ?
See
http://lists.infradead.org/pipermail/linux-arm-kernel/2017-September/533510.html
Gregory
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: Gregory CLEMENT <gregory.clement@free-electrons.com>
To: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: "Jisheng Zhang" <Jisheng.Zhang@synaptics.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
"Ulf Hansson" <ulf.hansson@linaro.org>,
"Adrian Hunter" <adrian.hunter@intel.com>,
linux-mmc@vger.kernel.org, "Andrew Lunn" <andrew@lunn.ch>,
"Yehuda Yitschak" <yehuday@marvell.com>,
"Jason Cooper" <jason@lakedaemon.net>,
"Antoine Tenart" <antoine.tenart@free-electrons.com>,
"Omri Itach" <omrii@marvell.com>, Stable <stable@vger.kernel.org>,
"Nadav Haklai" <nadavh@marvell.com>,
"Shadi Ammouri" <shadi@marvell.com>,
"Igal Liberman" <igall@marvell.com>,
"Miquèl Raynal" <miquel.raynal@free-electrons.com>,
"Marcin Wojtas" <mw@semihalf.com>,
"Hanna Hawa" <hannah@marvell.com>,
linux-arm-kernel@lists.infradead.org,
"Sebastian Hesselbarth" <sebastian.hesselbarth@gmail.com>,
devicetree@vger.kernel.org
Subject: Re: [PATCH] mmc: sdhci-xenon: Fix clock resource by adding an optional bus clock
Date: Fri, 29 Sep 2017 11:22:05 +0200 [thread overview]
Message-ID: <87bmlthnb6.fsf@free-electrons.com> (raw)
In-Reply-To: <20170929111550.065e7948@windsurf.lan> (Thomas Petazzoni's message of "Fri, 29 Sep 2017 11:15:50 +0200")
Hi Thomas,
On ven., sept. 29 2017, Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote:
> Hello,
>
> On Fri, 29 Sep 2017 11:13:00 +0200, Gregory CLEMENT wrote:
>
>> >> - clock-names:
>> >> Array of names corresponding to clocks property.
>> >> The input clock for Xenon IP core should be named as "core".
>> >> + The input clock for the AXI bus must be named as "axi".
>> >
>> > Is "bus" more suitable?
>>
>> I find bus too vague.
>
> Actually no, I believe "bus" is more common. Indeed, you could have the
> same IP, attached to a different interconnect I guess.
>
>> >> /*
>> >> * Link Xenon specific mmc_host_ops function,
>> >> @@ -491,9 +493,20 @@ static int xenon_probe(struct platform_device *pdev)
>> >> if (err)
>> >> goto free_pltfm;
>> >>
>> >> + priv->axi_clk = devm_clk_get(&pdev->dev, "axi");
>> >> + if (IS_ERR(priv->axi_clk)) {
>
> -EPROBE_DEFER handling ?
See
http://lists.infradead.org/pipermail/linux-arm-kernel/2017-September/533510.html
Gregory
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2017-09-29 9:22 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-28 15:05 [PATCH] mmc: sdhci-xenon: Fix clock resource by adding an optional bus clock Gregory CLEMENT
2017-09-28 15:05 ` Gregory CLEMENT
2017-09-28 15:57 ` Gregory CLEMENT
2017-09-28 15:57 ` Gregory CLEMENT
2017-09-29 2:39 ` Jisheng Zhang
2017-09-29 2:39 ` Jisheng Zhang
2017-09-29 2:39 ` Jisheng Zhang
[not found] ` <20170929103943.3a6f2509-XW7BGIvHH6X931TTwiNRCw@public.gmane.org>
2017-09-29 9:13 ` Gregory CLEMENT
2017-09-29 9:13 ` Gregory CLEMENT
2017-09-29 9:13 ` Gregory CLEMENT
2017-09-29 9:15 ` Thomas Petazzoni
2017-09-29 9:15 ` Thomas Petazzoni
2017-09-29 9:15 ` Thomas Petazzoni
[not found] ` <20170929111550.065e7948-dFHcqWZE4nf+AlalS6MPSg@public.gmane.org>
2017-09-29 9:22 ` Gregory CLEMENT [this message]
2017-09-29 9:22 ` Gregory CLEMENT
2017-09-29 9:22 ` Gregory CLEMENT
2017-09-30 2:47 ` Ziji Hu
2017-09-30 2:47 ` Ziji Hu
2017-09-30 2:56 ` Jisheng Zhang
2017-09-30 2:56 ` Jisheng Zhang
2017-09-30 2:56 ` Jisheng Zhang
-- strict thread matches above, loose matches on Subject: below --
2017-10-12 16:13 Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bmlthnb6.fsf@free-electrons.com \
--to=gregory.clement-wi1+55scjutkeb57/3fjtnbpr1lh4cv8@public.gmane.org \
--cc=Jisheng.Zhang-Gq53QDLGkWKakBO8gow8eQ@public.gmane.org \
--cc=adrian.hunter-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=andrew-g2DYL2Zd6BY@public.gmane.org \
--cc=antoine.tenart-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
--cc=hannah-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org \
--cc=igall-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org \
--cc=jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=miquel.raynal-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
--cc=mw-nYOzD4b6Jr9Wk0Htik3J/w@public.gmane.org \
--cc=nadavh-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org \
--cc=omrii-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=shadi-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org \
--cc=stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
--cc=ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=yehuday-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.