[PATCH 1/2] arm64: dts: marvell: fix USB3 regulator definition on MacchiatoBin

[PATCH 1/2] arm64: dts: marvell: fix USB3 regulator definition on MacchiatoBin

[Thomas Petazzoni]

Due to the lack of GPIO support, the USB3 regulator definition was
left unfinished in the MacchiatoBin DT description. Now that GPIO
support is available, this commit adjusts the Device Tree to properly
describe the USB3 regulator.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 arch/arm64/boot/dts/marvell/armada-8040-mcbin.dts | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dts b/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dts
index 015b58b..dfced8c 100644
--- a/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dts
+++ b/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dts
@@ -46,6 +46,8 @@
 
 #include "armada-8040.dtsi"
 
+#include <dt-bindings/gpio/gpio.h>
+
 / {
 	model = "Marvell 8040 MACHIATOBin";
 	compatible = "marvell,armada8040-mcbin", "marvell,armada8040",
@@ -80,8 +82,9 @@
 		regulator-name = "v_5v0_usb3_hst_vbus";
 		regulator-min-microvolt = <5000000>;
 		regulator-max-microvolt = <5000000>;
-		/* actually GPIO controlled, but 8k has no GPIO support yet */
+		gpio = <&cpm_gpio2 15 GPIO_ACTIVE_HIGH>;
 		regulator-always-on;
+		enable-active-high;
 		status = "okay";
 	};
 
-- 
2.9.4

[PATCH 2/2] arm64: defconfig: enable nop-xceiv PHY driver

[Thomas Petazzoni]

This commit enables the nop-xceiv PHY driver, which is needed for USB
support to work on the MacchiatoBin platform (Marvell Armada 8K).

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 arch/arm64/configs/defconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 97c123e..e037f1b 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -388,6 +388,7 @@ CONFIG_USB_CHIPIDEA_UDC=y
 CONFIG_USB_CHIPIDEA_HOST=y
 CONFIG_USB_ISP1760=y
 CONFIG_USB_HSIC_USB3503=y
+CONFIG_NOP_USB_XCEIV=y
 CONFIG_USB_MSM_OTG=y
 CONFIG_USB_QCOM_8X16_PHY=y
 CONFIG_USB_ULPI=y
-- 
2.9.4

[PATCH 2/2] arm64: defconfig: enable nop-xceiv PHY driver

[Gregory CLEMENT]

Hi Thomas,
 
 On ven., juin 23 2017, Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote:

> This commit enables the nop-xceiv PHY driver, which is needed for USB
> support to work on the MacchiatoBin platform (Marvell Armada 8K).
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

Applied on mvebu/arm64-for-4.14

Thanks,

Gregory
> ---
>  arch/arm64/configs/defconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index 97c123e..e037f1b 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -388,6 +388,7 @@ CONFIG_USB_CHIPIDEA_UDC=y
>  CONFIG_USB_CHIPIDEA_HOST=y
>  CONFIG_USB_ISP1760=y
>  CONFIG_USB_HSIC_USB3503=y
> +CONFIG_NOP_USB_XCEIV=y
>  CONFIG_USB_MSM_OTG=y
>  CONFIG_USB_QCOM_8X16_PHY=y
>  CONFIG_USB_ULPI=y
> -- 
> 2.9.4
>

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[PATCH 1/2] arm64: dts: marvell: fix USB3 regulator definition on MacchiatoBin

[Russell King - ARM Linux]

On Fri, Jun 23, 2017 at 05:40:13PM +0200, Thomas Petazzoni wrote:
> Due to the lack of GPIO support, the USB3 regulator definition was
> left unfinished in the MacchiatoBin DT description. Now that GPIO
> support is available, this commit adjusts the Device Tree to properly
> describe the USB3 regulator.
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
>  arch/arm64/boot/dts/marvell/armada-8040-mcbin.dts | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)

If you weren't soo keen with your NIH patches, then you wouldn't be
making a mistake here...

Now, from what you've said on IRC, I know that you're more than happy
to fetch my git tree and test it on your board, and I've already stated
in a previous thread that I'm happy for people to take the DTS patches
I have in that branch, but still you persist in creating your own (and
in this case broken) patches.

While it _may_ work for you, it is not correct to the binding doc.

Now, you could have taken these three patches from my tree (which I
know you have from what you said on IRC):

  arm64: dts: marvell: mcbin: add GPIO
  arm64: dts: marvell: mcbin: add pinctrl nodes
  arm64: dts: marvell: mcbin: add gpio binding include file

which apply cleanly on top of arm-soc, and tested them with your gpio
and pinmux work.  In fact, these three patches are solving the exact
problem you have here.

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.