[PATCH] staging: speakup: fix wrong code indent

[PATCH] staging: speakup: fix wrong code indent

[Michael Mera]

Remove unecessary multiline comment, fixes checkpatch messages:
ERROR: code indent should use tabs where possible
WARNING: Block comments should align the * on each line

Signed-off-by: Michael Mera <dev@michaelmera.com>
---
 drivers/staging/speakup/speakup_decpc.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/staging/speakup/speakup_decpc.c b/drivers/staging/speakup/speakup_decpc.c
index 6bf38e49a96d..94ca6987f71b 100644
--- a/drivers/staging/speakup/speakup_decpc.c
+++ b/drivers/staging/speakup/speakup_decpc.c
@@ -84,9 +84,7 @@
 #define	CTRL_last_index		0x0b00	/*   get last index spoken */
 #define	CTRL_io_priority	0x0c00	/*   change i/o priority */
 #define	CTRL_free_mem		0x0d00	/*   get free paragraphs on module */
-#define	CTRL_get_lang		0x0e00	/* return bit mask of loaded
-					         * languages
-					         */
+#define	CTRL_get_lang		0x0e00	/* return bitmask of loaded languages */
 #define	CMD_test			0x2000		/* self-test request */
 #define	TEST_mask		0x0F00	/* isolate test field */
 #define	TEST_null		0x0000	/* no test requested */
-- 
2.9.3

Re: [PATCH] staging: speakup: fix wrong code indent

[Greg Kroah-Hartman]

On Fri, Apr 28, 2017 at 03:20:24PM +0900, Michael Mera wrote:
> Remove unecessary multiline comment, fixes checkpatch messages:
> ERROR: code indent should use tabs where possible
> WARNING: Block comments should align the * on each line
> 
> Signed-off-by: Michael Mera <dev@michaelmera.com>
> ---
>  drivers/staging/speakup/speakup_decpc.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/speakup/speakup_decpc.c b/drivers/staging/speakup/speakup_decpc.c
> index 6bf38e49a96d..94ca6987f71b 100644
> --- a/drivers/staging/speakup/speakup_decpc.c
> +++ b/drivers/staging/speakup/speakup_decpc.c
> @@ -84,9 +84,7 @@
>  #define	CTRL_last_index		0x0b00	/*   get last index spoken */
>  #define	CTRL_io_priority	0x0c00	/*   change i/o priority */
>  #define	CTRL_free_mem		0x0d00	/*   get free paragraphs on module */
> -#define	CTRL_get_lang		0x0e00	/* return bit mask of loaded
> -					         * languages
> -					         */
> +#define	CTRL_get_lang		0x0e00	/* return bitmask of loaded languages */

And now you have a different coding style warning :(

Sorry, you can't replace one for another.

greg k-h

[PATCH v2] staging: speakup: fix wrong code indent

[Michael Mera]

Remove unnecessary multiline comment, fixes checkpatch messages:
ERROR: code indent should use tabs where possible
WARNING: Block comments should align the * on each line

Signed-off-by: Michael Mera <dev@michaelmera.com>
---
 drivers/staging/speakup/speakup_decpc.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/staging/speakup/speakup_decpc.c b/drivers/staging/speakup/speakup_decpc.c
index 6bf38e49a96d..94ca6987f71b 100644
--- a/drivers/staging/speakup/speakup_decpc.c
+++ b/drivers/staging/speakup/speakup_decpc.c
@@ -84,9 +84,7 @@
 #define	CTRL_last_index		0x0b00	/*   get last index spoken */
 #define	CTRL_io_priority	0x0c00	/*   change i/o priority */
 #define	CTRL_free_mem		0x0d00	/*   get free paragraphs on module */
-#define	CTRL_get_lang		0x0e00	/* return bit mask of loaded
-					         * languages
-					         */
+#define	CTRL_get_lang		0x0e00	/* return bitmask of loaded languages */
 #define	CMD_test			0x2000		/* self-test request */
 #define	TEST_mask		0x0F00	/* isolate test field */
 #define	TEST_null		0x0000	/* no test requested */
-- 
2.9.3

Re: [PATCH v2] staging: speakup: fix wrong code indent

[Greg Kroah-Hartman]

On Fri, Apr 28, 2017 at 05:46:07PM +0900, Michael Mera wrote:
> Remove unnecessary multiline comment, fixes checkpatch messages:
> ERROR: code indent should use tabs where possible
> WARNING: Block comments should align the * on each line
> 
> Signed-off-by: Michael Mera <dev@michaelmera.com>
> ---
>  drivers/staging/speakup/speakup_decpc.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)

What changed from v1?  That needs to go below the --- line.

And I think my previous email still is relevant here...

Re: [PATCH v2] staging: speakup: fix wrong code indent

[Michael Mera]

Greg Kroah-Hartman <gregkh@linuxfoundation.org> writes:

> On Fri, Apr 28, 2017 at 05:46:07PM +0900, Michael Mera wrote:
>> Remove unnecessary multiline comment, fixes checkpatch messages:
>> ERROR: code indent should use tabs where possible
>> WARNING: Block comments should align the * on each line
>> 
>> Signed-off-by: Michael Mera <dev@michaelmera.com>
>> ---
>>  drivers/staging/speakup/speakup_decpc.c | 4 +---
>>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> What changed from v1?  That needs to go below the --- line.

Oh. Sorry. I fixed the spelling of the patch message, since I
though that was the problem you detected but...

>
> And I think my previous email still is relevant here...

... apparently not. I double checked the patch with 'checkpatch --strict'
and it does not detect any problem this time.

Sorry if I missed something obvious, I am quite new to this, but could
you give me some additional hint about the problem.

Re: [PATCH v2] staging: speakup: fix wrong code indent

[Greg Kroah-Hartman]

On Fri, Apr 28, 2017 at 06:11:04PM +0900, Michael Mera wrote:
> Greg Kroah-Hartman <gregkh@linuxfoundation.org> writes:
> 
> > On Fri, Apr 28, 2017 at 05:46:07PM +0900, Michael Mera wrote:
> >> Remove unnecessary multiline comment, fixes checkpatch messages:
> >> ERROR: code indent should use tabs where possible
> >> WARNING: Block comments should align the * on each line
> >> 
> >> Signed-off-by: Michael Mera <dev@michaelmera.com>
> >> ---
> >>  drivers/staging/speakup/speakup_decpc.c | 4 +---
> >>  1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > What changed from v1?  That needs to go below the --- line.
> 
> Oh. Sorry. I fixed the spelling of the patch message, since I
> though that was the problem you detected but...
> 
> >
> > And I think my previous email still is relevant here...
> 
> ... apparently not. I double checked the patch with 'checkpatch --strict'
> and it does not detect any problem this time.
> 
> Sorry if I missed something obvious, I am quite new to this, but could
> you give me some additional hint about the problem.

Isn't the line now too long?

Anyway, please resend with at least the properly version information.

thanks,

greg k-h

[PATCH v3] staging: speakup: fix wrong code indent

[Michael Mera]

Fix checkpatch messages:
ERROR: code indent should use tabs where possible
WARNING: Block comments should align the * on each line

Changes:
  - replace unnecessary multiline comment by a single line comment
  - change "bit mask" for "bitmask" to have a line shorter than 80
    characters

Signed-off-by: Michael Mera <dev@michaelmera.com>
---

v2 -> v3:
  - add missing changes descriptions
  - improve patch message to make it more clear what changed

v1 -> v2:
  - fix typo in patch description message

 drivers/staging/speakup/speakup_decpc.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/staging/speakup/speakup_decpc.c b/drivers/staging/speakup/speakup_decpc.c
index 6bf38e49a96d..94ca6987f71b 100644
--- a/drivers/staging/speakup/speakup_decpc.c
+++ b/drivers/staging/speakup/speakup_decpc.c
@@ -84,9 +84,7 @@
 #define	CTRL_last_index		0x0b00	/*   get last index spoken */
 #define	CTRL_io_priority	0x0c00	/*   change i/o priority */
 #define	CTRL_free_mem		0x0d00	/*   get free paragraphs on module */
-#define	CTRL_get_lang		0x0e00	/* return bit mask of loaded
-					         * languages
-					         */
+#define	CTRL_get_lang		0x0e00	/* return bitmask of loaded languages */
 #define	CMD_test			0x2000		/* self-test request */
 #define	TEST_mask		0x0F00	/* isolate test field */
 #define	TEST_null		0x0000	/* no test requested */
-- 
2.9.3

Re: [PATCH v3] staging: speakup: fix wrong code indent

[Greg Kroah-Hartman]

On Fri, Apr 28, 2017 at 11:43:26PM +0900, Michael Mera wrote:
> Fix checkpatch messages:
> ERROR: code indent should use tabs where possible
> WARNING: Block comments should align the * on each line
> 
> Changes:
>   - replace unnecessary multiline comment by a single line comment
>   - change "bit mask" for "bitmask" to have a line shorter than 80
>     characters
> 
> Signed-off-by: Michael Mera <dev@michaelmera.com>
> ---
> 
> v2 -> v3:
>   - add missing changes descriptions
>   - improve patch message to make it more clear what changed

This patch doesn't apply to my tree at all, what tree/branch did you
make it against?

thanks,

greg k-h

Re: [PATCH v3] staging: speakup: fix wrong code indent

[Michael Mera]

Greg Kroah-Hartman <gregkh@linuxfoundation.org> writes:
> This patch doesn't apply to my tree at all, what tree/branch did you
> make it against?

>From the 'T:' line in MAINTAINER at STAGING SUBSYSTEM,  I thought that I
should base changes on:
  git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git

Since there was no branch indication unlike some other lines, I worked
on master.

Now, given your remark I found your blog post where you ask to base the
changes on linux-next. Sorry.

Part of the patch is still relevant, so I intend to submit a v4. If that
is ok with you.

Thank you,
Michael Mera

[PATCH v4] staging: speakup: fix unnecessary long line

[Michael Mera]

Fix checkpatch message:
WARNING: line over 80 characters

Change "bit mask" for "bitmask" to have a line shorter than 80 characters.

Signed-off-by: Michael Mera <dev@michaelmera.com>
---

v3 -> v4:
   - base changes on linux-next rather than some random tree
   - reduce scope of the patch (already partially solved)
   - adapted message accordingly

v2 -> v3:
  - add missing changes descriptions
  - improve patch message to make it more clear what changed

v1 -> v2:
  - fix typo in patch description message

 drivers/staging/speakup/speakup_decpc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/speakup/speakup_decpc.c b/drivers/staging/speakup/speakup_decpc.c
index 5d22c3b7edd4..7a8df7dc1e38 100644
--- a/drivers/staging/speakup/speakup_decpc.c
+++ b/drivers/staging/speakup/speakup_decpc.c
@@ -84,7 +84,7 @@
 #define	CTRL_last_index		0x0b00	/* get last index spoken */
 #define	CTRL_io_priority	0x0c00	/* change i/o priority */
 #define	CTRL_free_mem		0x0d00	/* get free paragraphs on module */
-#define	CTRL_get_lang		0x0e00	/* return bit mask of loaded languages */
+#define	CTRL_get_lang		0x0e00	/* return bitmask of loaded languages */
 #define	CMD_test		0x2000	/* self-test request */
 #define	TEST_mask		0x0F00	/* isolate test field */
 #define	TEST_null		0x0000	/* no test requested */
-- 
2.9.3