All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: qemu-ppc@nongnu.org, agraf@suse.de, david@gibson.dropbear.id.au
Subject: [Qemu-devel] Posible regressions around spapr-dr-connector property drc-connector[]
Date: Thu, 03 Dec 2015 16:30:31 +0100	[thread overview]
Message-ID: <87bna7v9bc.fsf@blackfin.pond.sub.org> (raw)

1. Before commit 94649d4 "spapr: Don't use QOM [*] syntax for DR
   connectors", the indexes were small integers:

       (qemu) info qom-tree
       /machine (pseries-2.4-machine)
         /unattached (container)
           [...]
           /device[5] (spapr-pci-host-bridge)
             /pci@800000020000000.mmio[0] (qemu:memory-region)
             /pci@800000020000000.mmio-alias[0] (qemu:memory-region)
             /pci@800000020000000.io[0] (qemu:memory-region)
             /pci@800000020000000.io-alias[0] (qemu:memory-region)
             /pci.0 (PCI)
             /pci@800000020000000.iommu-root[0] (qemu:memory-region)
             /dr-connector[0] (spapr-dr-connector)
             /dr-connector[1] (spapr-dr-connector)
             /dr-connector[2] (spapr-dr-connector)
             [...]

   Since then, they're big ones:

             /dr-connector[1073741824] (spapr-dr-connector)
             /dr-connector[1073741825] (spapr-dr-connector)
             /dr-connector[1073741826] (spapr-dr-connector)

   The commit message doesn't quite spell out this change, and I'm
   therefore double-checkint it's intentional.  Is it?

2. Before commit 6c2f9a1 "qapi: Make output visitor return qnull()
   instead of NULL", qom-get returned {}:

   Since then, it returns null:

       QMP> { "execute": "qom-get", "arguments": { "path": "/machine/unattached/device[5]/dr-connector[1073741950]", "property": "fdt" } }
       {"return": null}

   Does anyone care?

             reply	other threads:[~2015-12-03 15:30 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-03 15:30 Markus Armbruster [this message]
2015-12-04  0:01 ` [Qemu-devel] Posible regressions around spapr-dr-connector property drc-connector[] David Gibson
2015-12-04  8:05   ` Markus Armbruster
2015-12-04  9:35     ` David Gibson
2015-12-04 10:11       ` Markus Armbruster
2015-12-04 11:52         ` Peter Maydell
2015-12-08  0:18         ` David Gibson
2015-12-08  0:24           ` Eric Blake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bna7v9bc.fsf@blackfin.pond.sub.org \
    --to=armbru@redhat.com \
    --cc=agraf@suse.de \
    --cc=david@gibson.dropbear.id.au \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.