All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@codeaurora.org>
To: sedat.dilek@gmail.com
Cc: Hong Xu <hong@topbug.net>, wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] ath9k and ath9k_htc: rename variable "led_blink"
Date: Sat, 24 Jan 2015 12:39:19 +0200	[thread overview]
Message-ID: <87bnloiht4.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <CA+icZUVq-bhryv=Aj7JuCzFU6kTQEh+jiwBR_bnJzNnjJ2Kg-A@mail.gmail.com> (Sedat Dilek's message of "Sat, 24 Jan 2015 11:33:48 +0100")

(I'll drop ath9k-devel as someone from there seems to be spamming with
vacation responses)

Sedat Dilek <sedat.dilek@gmail.com> writes:

> 2nd, use the Fixes tag [2] in this case with a reference to the
> culprit commit [1].
>
> Fixes: 3a939a671225 ("ath9k_htc: Add a module parameter to disable blink")

Good point. I just found a handy tip from SubmittingPatches, just add
this to ~/.gitconfig:

	[core]
		abbrev = 12
	[pretty]
		fixes = Fixes: %h (\"%s\")

And then you get the fixes line automatically formatted for whatever
commit you want:

$ git log --format=fixes | head -5
Fixes: fa1270678ce4 ("ath10k: Enable the MCS8 and MCS9 at 2.4G band")
Fixes: 296f98ed02dd ("ath10k: fix pmf for wmi-tlv on qca6174")
Fixes: 3443aaf6f11d ("ath10k: remove sw encryption for pmf")
Fixes: d541c931dc93 ("ath10k: disable irqs after fw crash")
Fixes: 9f282daeedc9 ("ath10k: disable uapsd autotrigger")

Yet another reason why git is so awesome.

-- 
Kalle Valo

  parent reply	other threads:[~2015-01-24 10:39 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-24 10:19 [ath9k-devel] [PATCH] ath9k and ath9k_htc: rename variable "led_blink" Hong Xu
2015-01-24 10:19 ` Hong Xu
2015-01-24 10:23 ` [ath9k-devel] " Kalle Valo
2015-01-24 10:23   ` Kalle Valo
2015-01-24 10:33   ` [ath9k-devel] " Sedat Dilek
2015-01-24 10:33     ` Sedat Dilek
2015-01-24 10:38     ` [ath9k-devel] " Oleksij Rempel
2015-01-24 10:38       ` Oleksij Rempel
2015-01-24 10:44       ` [ath9k-devel] " Sedat Dilek
2015-01-24 10:44         ` Sedat Dilek
2015-01-24 10:39     ` Kalle Valo [this message]
2015-01-24 10:50       ` Sedat Dilek
2015-01-24 11:07         ` Sedat Dilek
2015-01-24 11:10     ` [ath9k-devel] " Hong Xu
2015-01-24 11:10       ` Hong Xu
2015-01-24 11:22       ` [ath9k-devel] " Sedat Dilek
2015-01-24 11:22         ` Sedat Dilek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bnloiht4.fsf@kamboji.qca.qualcomm.com \
    --to=kvalo@codeaurora.org \
    --cc=hong@topbug.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=sedat.dilek@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.