From: Kalle Valo <kvalo@codeaurora.org>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] [PATCH] ath9k and ath9k_htc: rename variable "led_blink"
Date: Sat, 24 Jan 2015 12:23:56 +0200 [thread overview]
Message-ID: <87k30ciiir.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1422094745-12718-1-git-send-email-hong@topbug.net> (Hong Xu's message of "Sat, 24 Jan 2015 02:19:05 -0800")
Hong Xu <hong@topbug.net> writes:
> ath9k and ath9k_htc use the variable name "led_blink" to indicate
> whether the module parameter "blink" is on. This name is easy to
> conflict with other variables, thus they are renamed.
Please state clearly that this fixes a compiler error found by kbuild.
Also it's very much recommended to add the actual compiler error to the
commit log:
drivers/net/wireless/ath/ath9k/ath9k_htc.o:(.data+0x47c): multiple definition of `led_blink'
drivers/net/wireless/ath/ath9k/ath9k.o:(.bss+0x20): first defined here
--
Kalle Valo
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@codeaurora.org>
To: Hong Xu <hong@topbug.net>
Cc: linux-wireless@vger.kernel.org, ath9k-devel@lists.ath9k.org
Subject: Re: [PATCH] ath9k and ath9k_htc: rename variable "led_blink"
Date: Sat, 24 Jan 2015 12:23:56 +0200 [thread overview]
Message-ID: <87k30ciiir.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1422094745-12718-1-git-send-email-hong@topbug.net> (Hong Xu's message of "Sat, 24 Jan 2015 02:19:05 -0800")
Hong Xu <hong@topbug.net> writes:
> ath9k and ath9k_htc use the variable name "led_blink" to indicate
> whether the module parameter "blink" is on. This name is easy to
> conflict with other variables, thus they are renamed.
Please state clearly that this fixes a compiler error found by kbuild.
Also it's very much recommended to add the actual compiler error to the
commit log:
drivers/net/wireless/ath/ath9k/ath9k_htc.o:(.data+0x47c): multiple definition of `led_blink'
drivers/net/wireless/ath/ath9k/ath9k.o:(.bss+0x20): first defined here
--
Kalle Valo
next prev parent reply other threads:[~2015-01-24 10:23 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-24 10:19 [ath9k-devel] [PATCH] ath9k and ath9k_htc: rename variable "led_blink" Hong Xu
2015-01-24 10:19 ` Hong Xu
2015-01-24 10:23 ` Kalle Valo [this message]
2015-01-24 10:23 ` Kalle Valo
2015-01-24 10:33 ` [ath9k-devel] " Sedat Dilek
2015-01-24 10:33 ` Sedat Dilek
2015-01-24 10:38 ` [ath9k-devel] " Oleksij Rempel
2015-01-24 10:38 ` Oleksij Rempel
2015-01-24 10:44 ` [ath9k-devel] " Sedat Dilek
2015-01-24 10:44 ` Sedat Dilek
2015-01-24 10:39 ` Kalle Valo
2015-01-24 10:50 ` Sedat Dilek
2015-01-24 11:07 ` Sedat Dilek
2015-01-24 11:10 ` [ath9k-devel] " Hong Xu
2015-01-24 11:10 ` Hong Xu
2015-01-24 11:22 ` [ath9k-devel] " Sedat Dilek
2015-01-24 11:22 ` Sedat Dilek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k30ciiir.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=ath9k-devel@lists.ath9k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.