From: Markus Armbruster <armbru@redhat.com>
To: zhanghailiang <zhang.zhanghailiang@huawei.com>
Cc: lersek@redhat.com, lcapitulino@redhat.com, luonengjun@huawei.com,
qemu-devel@nongnu.org, peter.huangpeng@huawei.com
Subject: Re: [Qemu-devel] [PATCH v6 1/2] dump: let dump_error return error info to caller
Date: Mon, 29 Sep 2014 09:48:17 +0200 [thread overview]
Message-ID: <87bnpyvpdq.fsf@blackfin.pond.sub.org> (raw)
In-Reply-To: <1411108984-4380-2-git-send-email-zhang.zhanghailiang@huawei.com> (zhanghailiang's message of "Fri, 19 Sep 2014 14:43:03 +0800")
zhanghailiang <zhang.zhanghailiang@huawei.com> writes:
> The second parameter of dump_error is unused, but one purpose of
> using this function is to report the error info.
>
> Use error_set to return the error info to the caller.
>
> Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
The commit message doesn't explain this patch's benefit clearly.
Suggest:
dump: Propagate errors into qmp_dump_guest_memory()
The code calls dump_error() on error, and even passes it a suitable
message. However, the message is thrown away, and its callers pass
up only success/failure. All qmp_dump_guest_memory() can do is set
a generic error.
Propagate the errors properly, so qmp_dump_guest_memory() can return
a more useful error.
With a commit message like that:
Reviewed-by: Markus Armbruster <armbru@redhat.com>
next prev parent reply other threads:[~2014-09-29 7:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-19 6:43 [Qemu-devel] [PATCH v6 0/2] dump: let dump_error return error reason to caller zhanghailiang
2014-09-19 6:43 ` [Qemu-devel] [PATCH v6 1/2] dump: let dump_error return error info " zhanghailiang
2014-09-29 7:48 ` Markus Armbruster [this message]
2014-09-29 8:06 ` zhanghailiang
2014-09-19 6:43 ` [Qemu-devel] [PATCH v6 2/2] dump: Don't return error code when return an Error object zhanghailiang
2014-09-29 8:06 ` Markus Armbruster
2014-09-30 8:39 ` zhanghailiang
2014-09-24 0:39 ` [Qemu-devel] [PATCH v6 0/2] dump: let dump_error return error reason to caller zhanghailiang
2014-09-28 1:18 ` zhanghailiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bnpyvpdq.fsf@blackfin.pond.sub.org \
--to=armbru@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=lersek@redhat.com \
--cc=luonengjun@huawei.com \
--cc=peter.huangpeng@huawei.com \
--cc=qemu-devel@nongnu.org \
--cc=zhang.zhanghailiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.