From: "Alex Bennée" <alex.bennee@linaro.org>
To: C Fontana <claudio.fontana@linaro.org>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Patch Tracking <patches@linaro.org>, Michael Matz <matz@suse.de>,
QEMU Developers <qemu-devel@nongnu.org>,
Will Newton <will.newton@linaro.org>,
Dirk Mueller <dmueller@suse.de>,
Laurent Desnogues <laurent.desnogues@gmail.com>,
"kvmarm@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>,
Christoffer Dall <christoffer.dall@linaro.org>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH v2 1/8] target-arm: A64: add support for ld/st pair
Date: Thu, 12 Dec 2013 11:43:10 +0000 [thread overview]
Message-ID: <87bo0m5m7l.fsf@linaro.org> (raw)
In-Reply-To: <CAOVdOBGdZAxpjsoXk_UFyrB8-Lk_BXss1_9VqncThV5BJ5m7JA@mail.gmail.com>
claudio.fontana@linaro.org writes:
> Hi,
>
> I saw a missing return below:
<snip>
>> + default: /* Failed decoder tree? */
>> + unallocated_encoding(s);
>> + break;
>> + }
>
> This doesn't seem right (break instead of return):
>
> default:
> unallocated_encoding(s);
> return;
> }
Good catch. I suspect it never hits though (or risu doesn't generate
enough unallocated versions).
--
Alex Bennée
QEMU/KVM Hacker for Linaro
next prev parent reply other threads:[~2013-12-12 11:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-11 22:01 [Qemu-devel] [PATCH v2 0/8] target-arm: A64 decoder set 3: loads, stores, misc integer Peter Maydell
2013-12-11 22:01 ` [Qemu-devel] [PATCH v2 1/8] target-arm: A64: add support for ld/st pair Peter Maydell
2013-12-12 9:54 ` C Fontana
2013-12-12 11:43 ` Alex Bennée [this message]
2013-12-12 11:45 ` Peter Maydell
2013-12-12 12:14 ` C Fontana
2013-12-13 14:34 ` Peter Maydell
2013-12-11 22:01 ` [Qemu-devel] [PATCH v2 2/8] target-arm: A64: add support for ld/st unsigned imm Peter Maydell
2013-12-11 22:01 ` [Qemu-devel] [PATCH v2 3/8] target-arm: A64: add support for ld/st with reg offset Peter Maydell
2013-12-11 22:01 ` [Qemu-devel] [PATCH v2 4/8] target-arm: A64: add support for ld/st with index Peter Maydell
2013-12-11 22:01 ` [Qemu-devel] [PATCH v2 5/8] target-arm: A64: add support for add, addi, sub, subi Peter Maydell
2013-12-11 22:01 ` [Qemu-devel] [PATCH v2 6/8] target-arm: A64: add support for move wide instructions Peter Maydell
2013-12-11 22:01 ` [Qemu-devel] [PATCH v2 7/8] target-arm: A64: add support for 3 src data proc insns Peter Maydell
2013-12-11 22:01 ` [Qemu-devel] [PATCH v2 8/8] target-arm: A64: implement SVC, BRK Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bo0m5m7l.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=christoffer.dall@linaro.org \
--cc=claudio.fontana@linaro.org \
--cc=dmueller@suse.de \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=laurent.desnogues@gmail.com \
--cc=matz@suse.de \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=will.newton@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.