All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH 1/8] ath10k: don't consume other's shared interrupts
Date: Sun, 24 Nov 2013 15:59:49 +0200	[thread overview]
Message-ID: <87bo19sxwq.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1385125518-13461-2-git-send-email-michal.kazior@tieto.com> (Michal Kazior's message of "Fri, 22 Nov 2013 14:05:11 +0100")

Michal Kazior <michal.kazior@tieto.com> writes:

> ath10k assumed all interrupts were directed to it.
> This isn't the case for legacy shared interrupts.
> ath10k consumed interrupts for other devices.
>
> Check device irq status and return IRQ_NONE when
> appropriate.
>
> Signed-off-by: Michal Kazior <michal.kazior@tieto.com>

[...]

> @@ -2085,6 +2103,9 @@ static irqreturn_t ath10k_pci_interrupt_handler(int irq, void *arg)
>  	struct ath10k *ar = arg;
>  	struct ath10k_pci *ar_pci = ath10k_pci_priv(ar);
>  
> +	if (!ath10k_pci_irq_pending(ar))
> +		return IRQ_NONE;
> +
>  	if (ar_pci->num_msi_intrs == 0) {
>  		/*
>  		 * IMPORTANT: INTR_CLR regiser has to be set after

What if you move ath10k_pci_irq_pending() call after
ar_pci->num_msi_intrs == 0 check? That way you could remove the
"ar_pci->num_msi_intrs == 0" check from irq_pending() function.

-- 
Kalle Valo

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: <ath10k@lists.infradead.org>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 1/8] ath10k: don't consume other's shared interrupts
Date: Sun, 24 Nov 2013 15:59:49 +0200	[thread overview]
Message-ID: <87bo19sxwq.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1385125518-13461-2-git-send-email-michal.kazior@tieto.com> (Michal Kazior's message of "Fri, 22 Nov 2013 14:05:11 +0100")

Michal Kazior <michal.kazior@tieto.com> writes:

> ath10k assumed all interrupts were directed to it.
> This isn't the case for legacy shared interrupts.
> ath10k consumed interrupts for other devices.
>
> Check device irq status and return IRQ_NONE when
> appropriate.
>
> Signed-off-by: Michal Kazior <michal.kazior@tieto.com>

[...]

> @@ -2085,6 +2103,9 @@ static irqreturn_t ath10k_pci_interrupt_handler(int irq, void *arg)
>  	struct ath10k *ar = arg;
>  	struct ath10k_pci *ar_pci = ath10k_pci_priv(ar);
>  
> +	if (!ath10k_pci_irq_pending(ar))
> +		return IRQ_NONE;
> +
>  	if (ar_pci->num_msi_intrs == 0) {
>  		/*
>  		 * IMPORTANT: INTR_CLR regiser has to be set after

What if you move ath10k_pci_irq_pending() call after
ar_pci->num_msi_intrs == 0 check? That way you could remove the
"ar_pci->num_msi_intrs == 0" check from irq_pending() function.

-- 
Kalle Valo

  reply	other threads:[~2013-11-24 14:00 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-22 13:05 [PATCH 0/8] ath10k: pci fixes 2013-11-22 Michal Kazior
2013-11-22 13:05 ` Michal Kazior
2013-11-22 13:05 ` [PATCH 1/8] ath10k: don't consume other's shared interrupts Michal Kazior
2013-11-22 13:05   ` Michal Kazior
2013-11-24 13:59   ` Kalle Valo [this message]
2013-11-24 13:59     ` Kalle Valo
2013-11-22 13:05 ` [PATCH 2/8] ath10k: split up pci irq code Michal Kazior
2013-11-22 13:05   ` Michal Kazior
2013-11-22 13:05 ` [PATCH 3/8] ath10k: fix memory leak on hif_start failpath Michal Kazior
2013-11-22 13:05   ` Michal Kazior
2013-11-22 13:05 ` [PATCH 4/8] ath10k: don't use interrupts for BMI Michal Kazior
2013-11-22 13:05   ` Michal Kazior
2013-11-22 13:05 ` [PATCH 5/8] ath10k: defer irq registration until hif start() Michal Kazior
2013-11-22 13:05   ` Michal Kazior
2013-11-22 13:05 ` [PATCH 6/8] ath10k: extract functions for legacy irq handling Michal Kazior
2013-11-22 13:05   ` Michal Kazior
2013-11-22 13:05 ` [PATCH 7/8] ath10k: re-add support for early fw indication Michal Kazior
2013-11-22 13:05   ` Michal Kazior
2013-11-25 12:20   ` Kalle Valo
2013-11-25 12:20     ` Kalle Valo
2013-11-25 12:46     ` Michal Kazior
2013-11-25 12:46       ` Michal Kazior
2013-11-22 13:05 ` [PATCH 8/8] ath10k: allow explicit MSI/MSI-X disabling Michal Kazior
2013-11-22 13:05   ` Michal Kazior
2013-11-25 12:01   ` Kalle Valo
2013-11-25 12:01     ` Kalle Valo
2013-11-25 13:06 ` [PATCH v2 0/8] ath10k: pci fixes 2013-11-22 Michal Kazior
2013-11-25 13:06   ` Michal Kazior
2013-11-25 13:06   ` [PATCH v2 1/8] ath10k: don't consume other's shared interrupts Michal Kazior
2013-11-25 13:06     ` Michal Kazior
2013-11-25 13:06   ` [PATCH v2 2/8] ath10k: split up pci irq code Michal Kazior
2013-11-25 13:06     ` Michal Kazior
2013-11-25 13:06   ` [PATCH v2 3/8] ath10k: don't use interrupts for BMI Michal Kazior
2013-11-25 13:06     ` Michal Kazior
2013-11-25 13:06   ` [PATCH v2 4/8] ath10k: decouple ath10k_pci_start_ce() Michal Kazior
2013-11-25 13:06     ` Michal Kazior
2013-11-25 13:06   ` [PATCH v2 5/8] ath10k: defer irq registration until hif start() Michal Kazior
2013-11-25 13:06     ` Michal Kazior
2013-11-25 13:06   ` [PATCH v2 6/8] ath10k: extract functions for legacy irq handling Michal Kazior
2013-11-25 13:06     ` Michal Kazior
2013-11-25 13:06   ` [PATCH v2 7/8] ath10k: re-add support for early fw indication Michal Kazior
2013-11-25 13:06     ` Michal Kazior
2013-11-25 13:06   ` [PATCH v2 8/8] ath10k: allow explicit MSI/MSI-X disabling Michal Kazior
2013-11-25 13:06     ` Michal Kazior
2013-11-27 14:47     ` Kalle Valo
2013-11-27 14:47       ` Kalle Valo
2013-11-27 14:48   ` [PATCH v2 0/8] ath10k: pci fixes 2013-11-22 Kalle Valo
2013-11-27 14:48     ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bo19sxwq.fsf@kamboji.qca.qualcomm.com \
    --to=kvalo@qca.qualcomm.com \
    --cc=ath10k@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=michal.kazior@tieto.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.