All of lore.kernel.org
 help / color / mirror / Atom feed
From: arno@natisbad.org (Arnaud Ebalard)
To: Guenter Roeck <linux@roeck-us.net>
Cc: Jean Delvare <khali@linux-fr.org>,
	Rob Herring <rob.herring@calxeda.com>,
	Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Stephen Warren <swarren@wwwdotorg.org>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Rob Landley <rob@landley.net>,
	Grant Likely <grant.likely@linaro.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Arnd Bergmann <arnd@arndb.de>,
	devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org
Subject: [lm-sensors] [PATCH] hwmon: add support for GMT G751 chip in lm75 driver
Date: Sat, 09 Nov 2013 17:39:14 +0000	[thread overview]
Message-ID: <87bo1th3ul.fsf@natisbad.org> (raw)

ClRoaXMgd2FzIHRlc3RlZCBvbiBhIE5FVEdFQVIgUmVhZHlOQVMgMjEyMCBkZXZpY2UgKE1hcnZl
bGwgQXJtYWRhIFhQCmJhc2VkIGJvYXJkLCB2aWEgRFQpLgoKU2lnbmVkLW9mZi1ieTogQXJuYXVk
IEViYWxhcmQgPGFybm9AbmF0aXNiYWQub3JnPgotLS0KSGkgR3VlbnRlciwKCkFzIGEgc2lkZSBu
b3RlLCBJIHJlbW92ZWQgdGhlIGh1bmsgdGhhdCB3YXMgcHJlc2VudCBpbiBwcmV2aW91cyBwYXRj
aCB0bwphZGQgZ210IHRvIHRoZSBsaXN0IG9mIERUIHZlbmRvciBwcmVmaXhlcyBiZWNhdXNlIEkg
bm90aWNlZCBzb21lb25lIGhhZAp0YWtlbiBjYXJlOiBodHRwczovL2xrbWwub3JnL2xrbWwvMjAx
My85LzEyLzM2NQoKRm9yIHRoZSByZWNvcmRzLCBoZXJlIGlzIHdoYXQgSSBnZXQgb24gbXkgTkFT
IHdpdGggdGhlIGF0dGFjaGVkIHBhdGNoOgoKcm9vdEB0aGluOi9zeXMjIHNlbnNvcnMKZzc2Mi1p
MmMtMC0zZQpBZGFwdGVyOiBtdjY0eHh4X2kyYyBhZGFwdGVyCmZhbjE6ICAgICAgICA1NDYxIFJQ
TSAgKGRpdiA9IDEpCgpnNzYyLWkyYy0wLTQ4CkFkYXB0ZXI6IG12NjR4eHhfaTJjIGFkYXB0ZXIK
ZmFuMTogICAgICAgIDU0NjEgUlBNICAoZGl2ID0gMSkKCmc3NjItaTJjLTAtNDkKQWRhcHRlcjog
bXY2NHh4eF9pMmMgYWRhcHRlcgpmYW4xOiAgICAgICAgNTQ2MSBSUE0gIChkaXYgPSAxKQoKZzc1
MS1pMmMtMC00YwpBZGFwdGVyOiBtdjY0eHh4X2kyYyBhZGFwdGVyCnRlbXAxOiAgICAgICAgKzMw
LjXCsEMgIChoaWdoID0gKzgwLjDCsEMsIGh5c3QgPSArNzUuMMKwQykKCmFybWFkYV90aGVybWFs
LXZpcnR1YWwtMApBZGFwdGVyOiBWaXJ0dWFsIGRldmljZQp0ZW1wMTogICAgICAgICszNC4ywrBD
Cgpyb290QHRoaW46L3N5cy9idXMvaTJjL2RyaXZlcnMvbG03NS8wLTAwNGMjIGxzCmRyaXZlciAg
bW9kYWxpYXMgIHN1YnN5c3RlbSAgICB0ZW1wMV9tYXggICAgICAgdWV2ZW50Cmh3bW9uICAgbmFt
ZSAgICAgIHRlbXAxX2lucHV0ICB0ZW1wMV9tYXhfaHlzdAoKcm9vdEB0aGluOi9zeXMvYnVzL2ky
Yy9kcml2ZXJzL2xtNzUvMC0wMDRjIyBkbWVzZyB8IGdyZXAgbG0KWyAgMTIwLjk2MDQ3MV0gbG03
NSAwLTAwNGM6IGh3bW9uMzogc2Vuc29yICdnNzUxJwoKCmp1c3QgYnkgYWRkaW5nIHRoZSBmb2xs
b3dpbmcgdG8gdGhlIC5kdHM6CgoJZzc1MTogZzc1MUA0YyB7CgkJY29tcGF0aWJsZSA9ICJnbXQs
Zzc1MSI7CgkJcmVnID0gPDB4NGM+OwoJfTsKCkRvIG5vdCBoZXNpdGF0ZSB0byB0ZWxsIG1lIGlm
IEkgbWlzc2VkIHNvbWV0aGluZy4KCkNoZWVycywKCmErCgogRG9jdW1lbnRhdGlvbi9kZXZpY2V0
cmVlL2JpbmRpbmdzL2kyYy90cml2aWFsLWRldmljZXMudHh0IHwgMSArCiBkcml2ZXJzL2h3bW9u
L0tjb25maWcgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAxICsKIGRyaXZl
cnMvaHdtb24vbG03NS5jICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8IDMg
KysrCiAzIGZpbGVzIGNoYW5nZWQsIDUgaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBhL0RvY3Vt
ZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9pMmMvdHJpdmlhbC1kZXZpY2VzLnR4dCBiL0Rv
Y3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9pMmMvdHJpdmlhbC1kZXZpY2VzLnR4dApp
bmRleCBhZDZhNzM4Li5jOThlNWEyIDEwMDY0NAotLS0gYS9Eb2N1bWVudGF0aW9uL2RldmljZXRy
ZWUvYmluZGluZ3MvaTJjL3RyaXZpYWwtZGV2aWNlcy50eHQKKysrIGIvRG9jdW1lbnRhdGlvbi9k
ZXZpY2V0cmVlL2JpbmRpbmdzL2kyYy90cml2aWFsLWRldmljZXMudHh0CkBAIC0zNSw2ICszNSw3
IEBAIGZzbCxtYzEzODkyCQlNQzEzODkyOiBQb3dlciBNYW5hZ2VtZW50IEludGVncmF0ZWQgQ2ly
Y3VpdCAoUE1JQykgZm9yIGkuTVgzNS81MQogZnNsLG1tYTg0NTAJCU1NQTg0NTBROiBYdHJpbnNp
YyBMb3ctcG93ZXIsIDMtYXhpcyBYdHJpbnNpYyBBY2NlbGVyb21ldGVyCiBmc2wsbXByMTIxCQlN
UFIxMjE6IFByb3hpbWl0eSBDYXBhY2l0aXZlIFRvdWNoIFNlbnNvciBDb250cm9sbGVyCiBmc2ws
c2d0bDUwMDAJCVNHVEw1MDAwOiBVbHRyYSBMb3ctUG93ZXIgQXVkaW8gQ29kZWMKK2dtdCxnNzUx
CQlHNzUxOiBEaWdpdGFsIFRlbXBlcmF0dXJlIFNlbnNvciBhbmQgVGhlcm1hbCBXYXRjaGRvZyB3
aXRoIFR3by1XaXJlIEludGVyZmFjZQogaW5maW5lb24sc2xiOTYzNXR0CUluZmluZW9uIFNMQjk2
MzUgKFNvZnQtKSBJMkMgVFBNIChvbGQgcHJvdG9jb2wsIG1heCAxMDBraHopCiBpbmZpbmVvbixz
bGI5NjQ1dHQJSW5maW5lb24gU0xCOTY0NSBJMkMgVFBNIChuZXcgcHJvdG9jb2wsIG1heCA0MDBr
aHopCiBtYXhpbSxkczEwNTAJCTUgQml0IFByb2dyYW1tYWJsZSwgUHVsc2UtV2lkdGggTW9kdWxh
dG9yCmRpZmYgLS1naXQgYS9kcml2ZXJzL2h3bW9uL0tjb25maWcgYi9kcml2ZXJzL2h3bW9uL0tj
b25maWcKaW5kZXggYjNhYjlkNC4uNTJkNTQ4ZiAxMDA2NDQKLS0tIGEvZHJpdmVycy9od21vbi9L
Y29uZmlnCisrKyBiL2RyaXZlcnMvaHdtb24vS2NvbmZpZwpAQCAtNjU2LDYgKzY1Niw3IEBAIGNv
bmZpZyBTRU5TT1JTX0xNNzUKIAogCQktIEFuYWxvZyBEZXZpY2VzIEFEVDc1CiAJCS0gRGFsbGFz
IFNlbWljb25kdWN0b3IgRFM3NSwgRFMxNzc1IGFuZCBEUzc1MDUKKwkJLSBHbG9iYWwgTWl4ZWQt
bW9kZSBUZWNobm9sb2d5IChHTVQpIEc3NTEKIAkJLSBNYXhpbSBNQVg2NjI1IGFuZCBNQVg2NjI2
CiAJCS0gTWljcm9jaGlwIE1DUDk4MHgKIAkJLSBOYXRpb25hbCBTZW1pY29uZHVjdG9yIExNNzUs
IExNNzVBCmRpZmYgLS1naXQgYS9kcml2ZXJzL2h3bW9uL2xtNzUuYyBiL2RyaXZlcnMvaHdtb24v
bG03NS5jCmluZGV4IGMwM2I0OTAuLjdlM2VmMTMgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvaHdtb24v
bG03NS5jCisrKyBiL2RyaXZlcnMvaHdtb24vbG03NS5jCkBAIC0zOSw2ICszOSw3IEBAIGVudW0g
bG03NV90eXBlIHsJCS8qIGtlZXAgc29ydGVkIGluIGFscGhhYmV0aWNhbCBvcmRlciAqLwogCWRz
MTc3NSwKIAlkczc1LAogCWRzNzUwNSwKKwlnNzUxLAogCWxtNzUsCiAJbG03NWEsCiAJbWF4NjYy
NSwKQEAgLTIwOCw2ICsyMDksNyBAQCBsbTc1X3Byb2JlKHN0cnVjdCBpMmNfY2xpZW50ICpjbGll
bnQsIGNvbnN0IHN0cnVjdCBpMmNfZGV2aWNlX2lkICppZCkKIAkJZGF0YS0+cmVzb2x1dGlvbiA9
IDEyOwogCQlkYXRhLT5zYW1wbGVfdGltZSA9IEhaIC8gNDsKIAkJYnJlYWs7CisJY2FzZSBnNzUx
OgogCWNhc2UgbG03NToKIAljYXNlIGxtNzVhOgogCQlkYXRhLT5yZXNvbHV0aW9uID0gOTsKQEAg
LTI5Niw2ICsyOTgsNyBAQCBzdGF0aWMgY29uc3Qgc3RydWN0IGkyY19kZXZpY2VfaWQgbG03NV9p
ZHNbXSA9IHsKIAl7ICJkczE3NzUiLCBkczE3NzUsIH0sCiAJeyAiZHM3NSIsIGRzNzUsIH0sCiAJ
eyAiZHM3NTA1IiwgZHM3NTA1LCB9LAorCXsgImc3NTEiLCBnNzUxLCB9LAogCXsgImxtNzUiLCBs
bTc1LCB9LAogCXsgImxtNzVhIiwgbG03NWEsIH0sCiAJeyAibWF4NjYyNSIsIG1heDY2MjUsIH0s
Ci0tIAoxLjguNC5yYzMKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fXwpsbS1zZW5zb3JzIG1haWxpbmcgbGlzdApsbS1zZW5zb3JzQGxtLXNlbnNvcnMub3Jn
Cmh0dHA6Ly9saXN0cy5sbS1zZW5zb3JzLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xtLXNlbnNvcnM

WARNING: multiple messages have this Message-ID (diff)
From: arno@natisbad.org (Arnaud Ebalard)
To: Guenter Roeck <linux@roeck-us.net>
Cc: Jean Delvare <khali@linux-fr.org>,
	Rob Herring <rob.herring@calxeda.com>,
	Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Stephen Warren <swarren@wwwdotorg.org>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Rob Landley <rob@landley.net>,
	Grant Likely <grant.likely@linaro.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Arnd Bergmann <arnd@arndb.de>,
	devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org
Subject: [PATCH] hwmon: add support for GMT G751 chip in lm75 driver
Date: Sat, 09 Nov 2013 18:39:14 +0100	[thread overview]
Message-ID: <87bo1th3ul.fsf@natisbad.org> (raw)


This was tested on a NETGEAR ReadyNAS 2120 device (Marvell Armada XP
based board, via DT).

Signed-off-by: Arnaud Ebalard <arno@natisbad.org>
---
Hi Guenter,

As a side note, I removed the hunk that was present in previous patch to
add gmt to the list of DT vendor prefixes because I noticed someone had
taken care: https://lkml.org/lkml/2013/9/12/365

For the records, here is what I get on my NAS with the attached patch:

root@thin:/sys# sensors
g762-i2c-0-3e
Adapter: mv64xxx_i2c adapter
fan1:        5461 RPM  (div = 1)

g762-i2c-0-48
Adapter: mv64xxx_i2c adapter
fan1:        5461 RPM  (div = 1)

g762-i2c-0-49
Adapter: mv64xxx_i2c adapter
fan1:        5461 RPM  (div = 1)

g751-i2c-0-4c
Adapter: mv64xxx_i2c adapter
temp1:        +30.5°C  (high = +80.0°C, hyst = +75.0°C)

armada_thermal-virtual-0
Adapter: Virtual device
temp1:        +34.2°C

root@thin:/sys/bus/i2c/drivers/lm75/0-004c# ls
driver  modalias  subsystem    temp1_max       uevent
hwmon   name      temp1_input  temp1_max_hyst

root@thin:/sys/bus/i2c/drivers/lm75/0-004c# dmesg | grep lm
[  120.960471] lm75 0-004c: hwmon3: sensor 'g751'


just by adding the following to the .dts:

	g751: g751@4c {
		compatible = "gmt,g751";
		reg = <0x4c>;
	};

Do not hesitate to tell me if I missed something.

Cheers,

a+

 Documentation/devicetree/bindings/i2c/trivial-devices.txt | 1 +
 drivers/hwmon/Kconfig                                     | 1 +
 drivers/hwmon/lm75.c                                      | 3 +++
 3 files changed, 5 insertions(+)

diff --git a/Documentation/devicetree/bindings/i2c/trivial-devices.txt b/Documentation/devicetree/bindings/i2c/trivial-devices.txt
index ad6a738..c98e5a2 100644
--- a/Documentation/devicetree/bindings/i2c/trivial-devices.txt
+++ b/Documentation/devicetree/bindings/i2c/trivial-devices.txt
@@ -35,6 +35,7 @@ fsl,mc13892		MC13892: Power Management Integrated Circuit (PMIC) for i.MX35/51
 fsl,mma8450		MMA8450Q: Xtrinsic Low-power, 3-axis Xtrinsic Accelerometer
 fsl,mpr121		MPR121: Proximity Capacitive Touch Sensor Controller
 fsl,sgtl5000		SGTL5000: Ultra Low-Power Audio Codec
+gmt,g751		G751: Digital Temperature Sensor and Thermal Watchdog with Two-Wire Interface
 infineon,slb9635tt	Infineon SLB9635 (Soft-) I2C TPM (old protocol, max 100khz)
 infineon,slb9645tt	Infineon SLB9645 I2C TPM (new protocol, max 400khz)
 maxim,ds1050		5 Bit Programmable, Pulse-Width Modulator
diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
index b3ab9d4..52d548f 100644
--- a/drivers/hwmon/Kconfig
+++ b/drivers/hwmon/Kconfig
@@ -656,6 +656,7 @@ config SENSORS_LM75
 
 		- Analog Devices ADT75
 		- Dallas Semiconductor DS75, DS1775 and DS7505
+		- Global Mixed-mode Technology (GMT) G751
 		- Maxim MAX6625 and MAX6626
 		- Microchip MCP980x
 		- National Semiconductor LM75, LM75A
diff --git a/drivers/hwmon/lm75.c b/drivers/hwmon/lm75.c
index c03b490..7e3ef13 100644
--- a/drivers/hwmon/lm75.c
+++ b/drivers/hwmon/lm75.c
@@ -39,6 +39,7 @@ enum lm75_type {		/* keep sorted in alphabetical order */
 	ds1775,
 	ds75,
 	ds7505,
+	g751,
 	lm75,
 	lm75a,
 	max6625,
@@ -208,6 +209,7 @@ lm75_probe(struct i2c_client *client, const struct i2c_device_id *id)
 		data->resolution = 12;
 		data->sample_time = HZ / 4;
 		break;
+	case g751:
 	case lm75:
 	case lm75a:
 		data->resolution = 9;
@@ -296,6 +298,7 @@ static const struct i2c_device_id lm75_ids[] = {
 	{ "ds1775", ds1775, },
 	{ "ds75", ds75, },
 	{ "ds7505", ds7505, },
+	{ "g751", g751, },
 	{ "lm75", lm75, },
 	{ "lm75a", lm75a, },
 	{ "max6625", max6625, },
-- 
1.8.4.rc3


             reply	other threads:[~2013-11-09 17:39 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-09 17:39 Arnaud Ebalard [this message]
2013-11-09 17:39 ` [PATCH] hwmon: add support for GMT G751 chip in lm75 driver Arnaud Ebalard
2013-11-09 18:27 ` [lm-sensors] " Guenter Roeck
2013-11-09 18:27   ` Guenter Roeck
2013-11-09 19:42   ` [lm-sensors] " Arnaud Ebalard
2013-11-09 19:42     ` Arnaud Ebalard
2013-11-09 21:17   ` [lm-sensors] " Jean Delvare
2013-11-09 21:17     ` Jean Delvare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bo1th3ul.fsf@natisbad.org \
    --to=arno@natisbad.org \
    --cc=arnd@arndb.de \
    --cc=devicetree@vger.kernel.org \
    --cc=grant.likely@linaro.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=khali@linux-fr.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=lm-sensors@lm-sensors.org \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=rob.herring@calxeda.com \
    --cc=rob@landley.net \
    --cc=swarren@wwwdotorg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.