[ath9k-devel] [PATCH v2 1/3] ath10k: implement device recovery

[Kalle Valo <kvalo@qca.qualcomm.com>]

Michal Kazior <michal.kazior@tieto.com> writes:

> Restart the hardware if FW crashes.
>
> If FW crashes during recovery we leave the
> hardware in a "wedged" state to avoid recursive
> recoveries.
>
> When in "wedged" state userspace may bring
> interfaces down (to issue stop()) and then bring
> one interface (to issue start()) to reload
> hardware manually.
>
> Signed-off-by: Michal Kazior <michal.kazior@tieto.com>

[...]

> --- a/drivers/net/wireless/ath/ath10k/core.h
> +++ b/drivers/net/wireless/ath/ath10k/core.h
> @@ -250,6 +250,20 @@ struct ath10k_debug {
>  enum ath10k_state {
>  	ATH10K_STATE_OFF = 0,
>  	ATH10K_STATE_ON,
> +
> +	/* When doing firmware recovery the device is first powered down.
> +	 * mac80211 is supposed to call in to start() hook later on. It is
> +	 * however possible that driver unloading and firmware crash overlap.
> +	 * mac80211 can wait on conf_mutex in stop() while the device is
> +	 * stopped in ath10k_core_restart() work holding conf_mutex. */
> +	ATH10K_STATE_RESTARTING_OFF,
> +	ATH10K_STATE_RESTARTING_ON,

I feel that RESTARTING_OFF and RESTARTING_ON are a bit confusing names,
especially when we have OFF and ON states. Wouldn't RESTARTING and
RESTARTED be simpler?

-- 
Kalle Valo