From: Kevin Hilman <khilman@linaro.org>
To: Aida Mynzhasova <aida.mynzhasova@skitlab.ru>
Cc: linux-omap@vger.kernel.org, tony@atomide.com,
linux@arm.linux.org.uk, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: OMAP: fix IVA2 module base address
Date: Tue, 28 May 2013 07:30:05 -0700 [thread overview]
Message-ID: <87bo7vdvo2.fsf@linaro.org> (raw)
In-Reply-To: <1369741577-21984-1-git-send-email-aida.mynzhasova@skitlab.ru> (Aida Mynzhasova's message of "Tue, 28 May 2013 15:46:17 +0400")
Aida Mynzhasova <aida.mynzhasova@skitlab.ru> writes:
> This patch corrects the base address of IVA2 module on omap3430.
>
> Signed-off-by: Aida Mynzhasova <aida.mynzhasova@skitlab.ru>
I know it looks a bit weird to have a negative offset like this, but
it's actually correct. These offsets are used relative to
prm_base (on 34xx, it's OMAP3430_PRM_BASE defined in omap34xx.h).
So I suggest you double check the values there, and cross reference to
the "PRCM Register Manual" section of the TRM (last section of the PRCM
chapter.)
Thanks,
Kevin
> ---
> arch/arm/mach-omap2/prcm-common.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-omap2/prcm-common.h b/arch/arm/mach-omap2/prcm-common.h
> index c7d355f..d5ec044 100644
> --- a/arch/arm/mach-omap2/prcm-common.h
> +++ b/arch/arm/mach-omap2/prcm-common.h
> @@ -37,7 +37,7 @@
> #define OMAP2430_MDM_MOD 0xc00
>
> /* IVA2 module is < base on 3430 */
> -#define OMAP3430_IVA2_MOD -0x800
> +#define OMAP3430_IVA2_MOD 0x800
> #define OMAP3430ES2_SGX_MOD GFX_MOD
> #define OMAP3430_CCR_MOD PLL_MOD
> #define OMAP3430_DSS_MOD 0x600
WARNING: multiple messages have this Message-ID (diff)
From: khilman@linaro.org (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: OMAP: fix IVA2 module base address
Date: Tue, 28 May 2013 07:30:05 -0700 [thread overview]
Message-ID: <87bo7vdvo2.fsf@linaro.org> (raw)
In-Reply-To: <1369741577-21984-1-git-send-email-aida.mynzhasova@skitlab.ru> (Aida Mynzhasova's message of "Tue, 28 May 2013 15:46:17 +0400")
Aida Mynzhasova <aida.mynzhasova@skitlab.ru> writes:
> This patch corrects the base address of IVA2 module on omap3430.
>
> Signed-off-by: Aida Mynzhasova <aida.mynzhasova@skitlab.ru>
I know it looks a bit weird to have a negative offset like this, but
it's actually correct. These offsets are used relative to
prm_base (on 34xx, it's OMAP3430_PRM_BASE defined in omap34xx.h).
So I suggest you double check the values there, and cross reference to
the "PRCM Register Manual" section of the TRM (last section of the PRCM
chapter.)
Thanks,
Kevin
> ---
> arch/arm/mach-omap2/prcm-common.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-omap2/prcm-common.h b/arch/arm/mach-omap2/prcm-common.h
> index c7d355f..d5ec044 100644
> --- a/arch/arm/mach-omap2/prcm-common.h
> +++ b/arch/arm/mach-omap2/prcm-common.h
> @@ -37,7 +37,7 @@
> #define OMAP2430_MDM_MOD 0xc00
>
> /* IVA2 module is < base on 3430 */
> -#define OMAP3430_IVA2_MOD -0x800
> +#define OMAP3430_IVA2_MOD 0x800
> #define OMAP3430ES2_SGX_MOD GFX_MOD
> #define OMAP3430_CCR_MOD PLL_MOD
> #define OMAP3430_DSS_MOD 0x600
next prev parent reply other threads:[~2013-05-28 14:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-28 11:46 [PATCH] ARM: OMAP: fix IVA2 module base address Aida Mynzhasova
2013-05-28 11:46 ` Aida Mynzhasova
2013-05-28 14:30 ` Kevin Hilman [this message]
2013-05-28 14:30 ` Kevin Hilman
2013-05-29 15:19 ` Aida Mynzhasova
2013-05-29 15:19 ` Aida Mynzhasova
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bo7vdvo2.fsf@linaro.org \
--to=khilman@linaro.org \
--cc=aida.mynzhasova@skitlab.ru \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.