From: Kevin Hilman <khilman@linaro.org>
To: Vaibhav Hiremath <hvaibhav@ti.com>
Cc: linux-omap@vger.kernel.org, tony@atomide.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: OMAP3+: am33xx id: Add new am33xx specific function to check dev_feature
Date: Mon, 13 May 2013 14:53:27 -0700 [thread overview]
Message-ID: <87bo8e1r8o.fsf@linaro.org> (raw)
In-Reply-To: <1367996313-6676-1-git-send-email-hvaibhav@ti.com> (Vaibhav Hiremath's message of "Wed, 8 May 2013 12:28:33 +0530")
Vaibhav Hiremath <hvaibhav@ti.com> writes:
> Layout of DEV_FEATURE register (offset = 0x604) is different
> between TI81xx and AM33xx device, so create separate function
> which will check for features available on specific AM33xx SoC
> and set the flags accordingly.
>
> Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com>
Minor nit below, otherwise...
Reviewed-by: Kevin Hilman <khilman@linaro.org>
> ---
> arch/arm/mach-omap2/control.h | 5 +++++
> arch/arm/mach-omap2/id.c | 13 +++++++++++++
> arch/arm/mach-omap2/io.c | 2 +-
> arch/arm/mach-omap2/soc.h | 1 +
> 4 files changed, 20 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/control.h b/arch/arm/mach-omap2/control.h
> index e6c3281..4acdfc5 100644
> --- a/arch/arm/mach-omap2/control.h
> +++ b/arch/arm/mach-omap2/control.h
> @@ -358,6 +358,11 @@
> #define AM33XX_CONTROL_STATUS_SYSBOOT1_WIDTH 0x2
> #define AM33XX_CONTROL_STATUS_SYSBOOT1_MASK (0x3 << 22)
>
> +/* DEV Feature register to identify AM33XX features */
> +#define AM33XX_DEV_FEATURE 0x604
> +#define AM33XX_SGX_SHIFT 29
You don't need the shift value anywhere in the code, so...
> +#define AM33XX_SGX_MASK (1 << AM33XX_SGX_SHIFT)
#define AM33XX_SGX_MASK BIT(29)
instead?
Otherwise, rest of patch looks fine.
Kevin
WARNING: multiple messages have this Message-ID (diff)
From: khilman@linaro.org (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: OMAP3+: am33xx id: Add new am33xx specific function to check dev_feature
Date: Mon, 13 May 2013 14:53:27 -0700 [thread overview]
Message-ID: <87bo8e1r8o.fsf@linaro.org> (raw)
In-Reply-To: <1367996313-6676-1-git-send-email-hvaibhav@ti.com> (Vaibhav Hiremath's message of "Wed, 8 May 2013 12:28:33 +0530")
Vaibhav Hiremath <hvaibhav@ti.com> writes:
> Layout of DEV_FEATURE register (offset = 0x604) is different
> between TI81xx and AM33xx device, so create separate function
> which will check for features available on specific AM33xx SoC
> and set the flags accordingly.
>
> Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com>
Minor nit below, otherwise...
Reviewed-by: Kevin Hilman <khilman@linaro.org>
> ---
> arch/arm/mach-omap2/control.h | 5 +++++
> arch/arm/mach-omap2/id.c | 13 +++++++++++++
> arch/arm/mach-omap2/io.c | 2 +-
> arch/arm/mach-omap2/soc.h | 1 +
> 4 files changed, 20 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/control.h b/arch/arm/mach-omap2/control.h
> index e6c3281..4acdfc5 100644
> --- a/arch/arm/mach-omap2/control.h
> +++ b/arch/arm/mach-omap2/control.h
> @@ -358,6 +358,11 @@
> #define AM33XX_CONTROL_STATUS_SYSBOOT1_WIDTH 0x2
> #define AM33XX_CONTROL_STATUS_SYSBOOT1_MASK (0x3 << 22)
>
> +/* DEV Feature register to identify AM33XX features */
> +#define AM33XX_DEV_FEATURE 0x604
> +#define AM33XX_SGX_SHIFT 29
You don't need the shift value anywhere in the code, so...
> +#define AM33XX_SGX_MASK (1 << AM33XX_SGX_SHIFT)
#define AM33XX_SGX_MASK BIT(29)
instead?
Otherwise, rest of patch looks fine.
Kevin
next prev parent reply other threads:[~2013-05-13 21:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-08 6:58 [PATCH] ARM: OMAP3+: am33xx id: Add new am33xx specific function to check dev_feature Vaibhav Hiremath
2013-05-08 6:58 ` Vaibhav Hiremath
2013-05-13 21:53 ` Kevin Hilman [this message]
2013-05-13 21:53 ` Kevin Hilman
2013-05-17 10:15 ` Hiremath, Vaibhav
2013-05-17 10:15 ` Hiremath, Vaibhav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bo8e1r8o.fsf@linaro.org \
--to=khilman@linaro.org \
--cc=hvaibhav@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.