All of lore.kernel.org
 help / color / mirror / Atom feed
From: ebiederm@xmission.com (Eric W. Biederman)
To: Vivek Goyal <vgoyal@redhat.com>
Cc: kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
	mingo@redhat.com, kumagai-atsushi@mxc.nes.nec.co.jp,
	hpa@zytor.com, yinghai@kernel.org, Jingbai Ma <jingbai.ma@hp.com>
Subject: Re: [RFC PATCH 0/5] crash dump bitmap: scan memory pages in kernel to speedup kernel dump process
Date: Fri, 08 Mar 2013 08:19:09 -0800	[thread overview]
Message-ID: <87boatooea.fsf@xmission.com> (raw)
In-Reply-To: <20130308155216.GB8219@redhat.com> (Vivek Goyal's message of "Fri, 8 Mar 2013 10:52:16 -0500")

Vivek Goyal <vgoyal@redhat.com> writes:

> On Thu, Mar 07, 2013 at 01:54:45PM -0800, Eric W. Biederman wrote:
>> Vivek Goyal <vgoyal@redhat.com> writes:
>> > I think this is not a good idea. It has several issues.
>> 
>> Actually it does not appear to be doing any work in the first kernel.
>
> Looks like patch3 in series is doing that.
>
>                         machine_crash_shutdown(&fixed_regs);
> +                       generate_crash_dump_bitmap();
>                         machine_kexec(kexec_crash_image);
>
> So this bitmap seems to be being set just before transitioning into
> second kernel.
>
> I am sure you would not like this extra code in this path. :-)

Ouch!  I had totally missed that.  No that is not at all acceptable.

I was blind that day.  The only call I saw was in patch 4 that put
the call generated the bitmap in the new proc file.

Eric

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

WARNING: multiple messages have this Message-ID (diff)
From: ebiederm@xmission.com (Eric W. Biederman)
To: Vivek Goyal <vgoyal@redhat.com>
Cc: Jingbai Ma <jingbai.ma@hp.com>,
	mingo@redhat.com, kumagai-atsushi@mxc.nes.nec.co.jp,
	hpa@zytor.com, yinghai@kernel.org, kexec@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 0/5] crash dump bitmap: scan memory pages in kernel to speedup kernel dump process
Date: Fri, 08 Mar 2013 08:19:09 -0800	[thread overview]
Message-ID: <87boatooea.fsf@xmission.com> (raw)
In-Reply-To: <20130308155216.GB8219@redhat.com> (Vivek Goyal's message of "Fri, 8 Mar 2013 10:52:16 -0500")

Vivek Goyal <vgoyal@redhat.com> writes:

> On Thu, Mar 07, 2013 at 01:54:45PM -0800, Eric W. Biederman wrote:
>> Vivek Goyal <vgoyal@redhat.com> writes:
>> > I think this is not a good idea. It has several issues.
>> 
>> Actually it does not appear to be doing any work in the first kernel.
>
> Looks like patch3 in series is doing that.
>
>                         machine_crash_shutdown(&fixed_regs);
> +                       generate_crash_dump_bitmap();
>                         machine_kexec(kexec_crash_image);
>
> So this bitmap seems to be being set just before transitioning into
> second kernel.
>
> I am sure you would not like this extra code in this path. :-)

Ouch!  I had totally missed that.  No that is not at all acceptable.

I was blind that day.  The only call I saw was in patch 4 that put
the call generated the bitmap in the new proc file.

Eric

  reply	other threads:[~2013-03-08 16:19 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-07 14:58 [RFC PATCH 0/5] crash dump bitmap: scan memory pages in kernel to speedup kernel dump process Jingbai Ma
2013-03-07 14:58 ` Jingbai Ma
2013-03-07 14:58 ` [RFC PATCH 1/5] crash dump bitmap: add a kernel config and help document Jingbai Ma
2013-03-07 14:58   ` Jingbai Ma
2013-03-07 14:58 ` [RFC PATCH 2/5] crash dump bitmap: init crash dump bitmap in kernel booting process Jingbai Ma
2013-03-07 14:58   ` Jingbai Ma
2013-03-07 14:58 ` [RFC PATCH 3/5] crash dump bitmap: scan memory pages in kernel crash process Jingbai Ma
2013-03-07 14:58   ` Jingbai Ma
2013-03-07 14:59 ` [RFC PATCH 4/5] crash dump bitmap: add a proc interface for crash dump bitmap Jingbai Ma
2013-03-07 14:59   ` Jingbai Ma
2013-03-07 14:59 ` [RFC PATCH 5/5] crash dump bitmap: workaround for kernel 3.9-rc1 kdump issue Jingbai Ma
2013-03-07 14:59   ` Jingbai Ma
2013-03-07 15:21 ` [RFC PATCH 0/5] crash dump bitmap: scan memory pages in kernel to speedup kernel dump process Vivek Goyal
2013-03-07 15:21   ` Vivek Goyal
2013-03-07 21:38   ` Yinghai Lu
2013-03-07 21:38     ` Yinghai Lu
2013-03-07 21:54   ` Eric W. Biederman
2013-03-07 21:54     ` Eric W. Biederman
2013-03-08 15:52     ` Vivek Goyal
2013-03-08 15:52       ` Vivek Goyal
2013-03-08 16:19       ` Eric W. Biederman [this message]
2013-03-08 16:19         ` Eric W. Biederman
2013-03-11  8:18       ` Jingbai Ma
2013-03-11  8:18         ` Jingbai Ma
2013-03-11  9:42         ` Eric W. Biederman
2013-03-11  9:42           ` Eric W. Biederman
2013-03-12 10:05           ` Jingbai Ma
2013-03-12 10:05             ` Jingbai Ma
2013-03-12 19:48             ` Eric W. Biederman
2013-03-12 19:48               ` Eric W. Biederman
2013-03-08  1:31   ` HATAYAMA Daisuke
2013-03-08  1:31     ` HATAYAMA Daisuke
2013-03-08 10:06   ` Jingbai Ma
2013-03-08 10:06     ` Jingbai Ma
2013-03-08 10:33     ` H. Peter Anvin
2013-03-08 10:33       ` H. Peter Anvin
2013-03-08 13:31       ` Ma, Jingbai (Kingboard)
2013-03-08 13:31         ` Ma, Jingbai (Kingboard)
2013-03-08 16:13         ` Eric W. Biederman
2013-03-08 16:13           ` Eric W. Biederman
2013-03-11  8:31           ` Jingbai Ma
2013-03-11  8:31             ` Jingbai Ma
2013-03-08 16:19     ` Vivek Goyal
2013-03-08 16:19       ` Vivek Goyal
2013-03-11  8:53       ` Jingbai Ma
2013-03-11  8:53         ` Jingbai Ma
2013-03-09  4:31     ` HATAYAMA Daisuke
2013-03-09  4:31       ` HATAYAMA Daisuke
2013-03-11  9:02       ` Jingbai Ma
2013-03-11  9:02         ` Jingbai Ma
2013-03-08 10:16   ` Jingbai Ma
2013-03-08 10:16     ` Jingbai Ma
  -- strict thread matches above, loose matches on Subject: below --
2013-03-07 14:05 Jingbai Ma
2013-03-07 14:00 Jingbai Ma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87boatooea.fsf@xmission.com \
    --to=ebiederm@xmission.com \
    --cc=hpa@zytor.com \
    --cc=jingbai.ma@hp.com \
    --cc=kexec@lists.infradead.org \
    --cc=kumagai-atsushi@mxc.nes.nec.co.jp \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=vgoyal@redhat.com \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.