From: Chris Ball <cjb@laptop.org>
To: Johan Rudholm <jrudholm@gmail.com>
Cc: Fabio Estevam <fabio.estevam@freescale.com>,
kliu5@marvell.com, linux-mmc@vger.kernel.org,
ulf.hansson@linaro.org, arnd.bergmann@linaro.org
Subject: Re: [PATCH v2] mmc: host: sdhci: Fix parameter of sdhci_do_start_signal_voltage_switch()
Date: Thu, 14 Feb 2013 16:04:27 -0500 [thread overview]
Message-ID: <87bobmli90.fsf@octavius.laptop.org> (raw)
In-Reply-To: <CA+20K0A4tWsmxrLJ+Enba3GPa8W0-E_tPvzaSL4izCF1x=K8uQ@mail.gmail.com> (Johan Rudholm's message of "Thu, 14 Feb 2013 13:56:53 +0100")
Hi,
On Thu, Feb 14 2013, Johan Rudholm wrote:
> 2013/2/14 Fabio Estevam <fabio.estevam@freescale.com>:
>> Commit 3714f4315354 (mmc: sdhci: update signal voltage switch code)
>> changed the
>> type of the second parameter of sdhci_do_start_signal_voltage_switch(), from
>> "struct mmc_ios *ios" to "int signal_voltage" which causes the following build
>> warning:
>>
>> drivers/mmc/host/sdhci.c:2044:2: warning: initialization from
>> incompatible pointer type [enabled by default]
>> drivers/mmc/host/sdhci.c:2044:2: warning: (near initialization for
>> sdhci_ops.start_signal_voltage_switch') [enabled by default]
>>
>> Use the previous type so that it matches the start_signal_voltage_switch()
>> definition from host.h.
>>
>> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
>
> Reviewed-by: Johan Rudholm <johan.rudholm@stericsson.com>
Pushed to mmc-next for 3.9. Thanks!
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
prev parent reply other threads:[~2013-02-14 21:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-14 12:35 [PATCH v2] mmc: host: sdhci: Fix parameter of sdhci_do_start_signal_voltage_switch() Fabio Estevam
2013-02-14 12:56 ` Johan Rudholm
2013-02-14 21:04 ` Chris Ball [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bobmli90.fsf@octavius.laptop.org \
--to=cjb@laptop.org \
--cc=arnd.bergmann@linaro.org \
--cc=fabio.estevam@freescale.com \
--cc=jrudholm@gmail.com \
--cc=kliu5@marvell.com \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.