All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@ti.com>
To: Javier Martinez Canillas <javier@dowhile0.org>
Cc: Tony Lindgren <tony@atomide.com>,
	Russell King <linux@arm.linux.org.uk>,
	Santosh Shilimkar <santosh.shilimkar@ti.com>,
	"Govindraj.R" <govindraj.raja@ti.com>,
	linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH 1/1] ARM: OMAP2+: omap2plus_defconfig: enable OMAP DMA engine support
Date: Mon, 16 Jul 2012 10:12:28 -0700	[thread overview]
Message-ID: <87bojfeikj.fsf@ti.com> (raw)
In-Reply-To: <1342321398-11009-1-git-send-email-javier@dowhile0.org> (Javier Martinez Canillas's message of "Sun, 15 Jul 2012 05:03:18 +0200")

Javier Martinez Canillas <javier@dowhile0.org> writes:

> commit 13f30fc893e4610f67dd7a8b0b67aec02eac1775
> Author: Russell King <rmk+kernel@arm.linux.org.uk>
> Date:   Sat Apr 21 22:41:10 2012 +0100
>
>     mmc: omap: remove private DMA API implementation
>
> removed the private DMA API implementation from the OMAP mmc host to
> make it use exclusively the DMA engine API.
>
> Unfortunately the omap2plus_defconfig doesn't enable this feature
> leading to the following error on an IGEPv2 Rev.C (and probably on most
> boards with MMC support):

Personally, I'd rather see this fixed by having the drivers that depend
on DMA engine 'select DMADEVICES'.  That way, any defconfig will work
correctly instead of just omap2plus_defconfig.

Kevin

> [    2.199981] omap_hsmmc omap_hsmmc.1: unable to obtain RX DMA engine channel 48
> [    2.215087] omap_hsmmc omap_hsmmc.0: unable to obtain RX DMA engine channel 62
>
> Signed-off-by: Javier Martinez Canillas <javier@dowhile0.org>
> ---
>  arch/arm/configs/omap2plus_defconfig |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/configs/omap2plus_defconfig b/arch/arm/configs/omap2plus_defconfig
> index b152de7..e58edc3 100644
> --- a/arch/arm/configs/omap2plus_defconfig
> +++ b/arch/arm/configs/omap2plus_defconfig
> @@ -193,6 +193,8 @@ CONFIG_MMC_OMAP_HS=y
>  CONFIG_RTC_CLASS=y
>  CONFIG_RTC_DRV_TWL92330=y
>  CONFIG_RTC_DRV_TWL4030=y
> +CONFIG_DMADEVICES=y
> +CONFIG_DMA_OMAP=y
>  CONFIG_EXT2_FS=y
>  CONFIG_EXT3_FS=y
>  # CONFIG_EXT3_FS_XATTR is not set

WARNING: multiple messages have this Message-ID (diff)
From: khilman@ti.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/1] ARM: OMAP2+: omap2plus_defconfig: enable OMAP DMA engine support
Date: Mon, 16 Jul 2012 10:12:28 -0700	[thread overview]
Message-ID: <87bojfeikj.fsf@ti.com> (raw)
In-Reply-To: <1342321398-11009-1-git-send-email-javier@dowhile0.org> (Javier Martinez Canillas's message of "Sun, 15 Jul 2012 05:03:18 +0200")

Javier Martinez Canillas <javier@dowhile0.org> writes:

> commit 13f30fc893e4610f67dd7a8b0b67aec02eac1775
> Author: Russell King <rmk+kernel@arm.linux.org.uk>
> Date:   Sat Apr 21 22:41:10 2012 +0100
>
>     mmc: omap: remove private DMA API implementation
>
> removed the private DMA API implementation from the OMAP mmc host to
> make it use exclusively the DMA engine API.
>
> Unfortunately the omap2plus_defconfig doesn't enable this feature
> leading to the following error on an IGEPv2 Rev.C (and probably on most
> boards with MMC support):

Personally, I'd rather see this fixed by having the drivers that depend
on DMA engine 'select DMADEVICES'.  That way, any defconfig will work
correctly instead of just omap2plus_defconfig.

Kevin

> [    2.199981] omap_hsmmc omap_hsmmc.1: unable to obtain RX DMA engine channel 48
> [    2.215087] omap_hsmmc omap_hsmmc.0: unable to obtain RX DMA engine channel 62
>
> Signed-off-by: Javier Martinez Canillas <javier@dowhile0.org>
> ---
>  arch/arm/configs/omap2plus_defconfig |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/configs/omap2plus_defconfig b/arch/arm/configs/omap2plus_defconfig
> index b152de7..e58edc3 100644
> --- a/arch/arm/configs/omap2plus_defconfig
> +++ b/arch/arm/configs/omap2plus_defconfig
> @@ -193,6 +193,8 @@ CONFIG_MMC_OMAP_HS=y
>  CONFIG_RTC_CLASS=y
>  CONFIG_RTC_DRV_TWL92330=y
>  CONFIG_RTC_DRV_TWL4030=y
> +CONFIG_DMADEVICES=y
> +CONFIG_DMA_OMAP=y
>  CONFIG_EXT2_FS=y
>  CONFIG_EXT3_FS=y
>  # CONFIG_EXT3_FS_XATTR is not set

  reply	other threads:[~2012-07-16 17:12 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-15  3:03 [PATCH 1/1] ARM: OMAP2+: omap2plus_defconfig: enable OMAP DMA engine support Javier Martinez Canillas
2012-07-15  3:03 ` Javier Martinez Canillas
2012-07-16 17:12 ` Kevin Hilman [this message]
2012-07-16 17:12   ` Kevin Hilman
2012-07-16 23:28   ` Javier Martinez Canillas
2012-07-16 23:28     ` Javier Martinez Canillas
2012-07-19 11:40     ` Tony Lindgren
2012-07-19 11:40       ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bojfeikj.fsf@ti.com \
    --to=khilman@ti.com \
    --cc=govindraj.raja@ti.com \
    --cc=javier@dowhile0.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=santosh.shilimkar@ti.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.