From: cjb@laptop.org (Chris Ball)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 0/4] DT clock bindings
Date: Thu, 21 Jun 2012 03:27:00 -0400 [thread overview]
Message-ID: <87bokd15x7.fsf@octavius.laptop.org> (raw)
In-Reply-To: <1339512111-11172-1-git-send-email-robherring2@gmail.com> (Rob Herring's message of "Tue, 12 Jun 2012 09:41:47 -0500")
Hi Rob,
On Tue, Jun 12 2012, Rob Herring wrote:
> This series defines clock bindings for Device-Tree and adds kernel
> support using the common clock infrastructure. The last patch enables
> DT clock support for the Calxeda Highbank platform.
>
> I'm posting this again to solicit further review. There has been some
> discussion[1], but no definite path forward. This series is not changed
> from the last post other than rebasing to v3.5-rc2.
This is a very useful patchset, thanks! Mitch Bradley and I have been
hooking up the mach-mmp ARM subarchitecture to it and we needed to
make a few changes, mainly because mach-mmp doesn't use COMMON_CLK.
The changes are:
1) Remove the COMMON_CLK dependency that the of_clk_* functions have by
moving them into a new file, drivers/clk/clk-of.c. The OF functions
in drivers/clk/clk.c aren't dependent on anything else in clk.c
(since you pass them a struct clk) so they can be moved out easily.
The of_clk_* entries in clk-provider.h move to clk.h.
2) Use alloc_bootmem() instead of kzalloc() in of_clk_add_provider(),
because we need to set up clocks during .init_early on ARM (which
happens pre-slab) so that they are available for platform init.
I'll send our patches in a reply to this mail. Are you okay with these
changes, and would you like to include them in your patchset?
Thanks very much,
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
WARNING: multiple messages have this Message-ID (diff)
From: Chris Ball <cjb@laptop.org>
To: Rob Herring <robherring2@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
devicetree-discuss@lists.ozlabs.org, mturquette@linaro.org,
s.hauer@pengutronix.de, sboyd@codeaurora.org,
Rob Herring <rob.herring@calxeda.com>,
Grant Likely <grant.likely@secretlab.ca>,
skannan@codeaurora.org, shawn.guo@linaro.org,
Mitch Bradley <wmb@laptop.org>
Subject: Re: [PATCH v3 0/4] DT clock bindings
Date: Thu, 21 Jun 2012 03:27:00 -0400 [thread overview]
Message-ID: <87bokd15x7.fsf@octavius.laptop.org> (raw)
In-Reply-To: <1339512111-11172-1-git-send-email-robherring2@gmail.com> (Rob Herring's message of "Tue, 12 Jun 2012 09:41:47 -0500")
Hi Rob,
On Tue, Jun 12 2012, Rob Herring wrote:
> This series defines clock bindings for Device-Tree and adds kernel
> support using the common clock infrastructure. The last patch enables
> DT clock support for the Calxeda Highbank platform.
>
> I'm posting this again to solicit further review. There has been some
> discussion[1], but no definite path forward. This series is not changed
> from the last post other than rebasing to v3.5-rc2.
This is a very useful patchset, thanks! Mitch Bradley and I have been
hooking up the mach-mmp ARM subarchitecture to it and we needed to
make a few changes, mainly because mach-mmp doesn't use COMMON_CLK.
The changes are:
1) Remove the COMMON_CLK dependency that the of_clk_* functions have by
moving them into a new file, drivers/clk/clk-of.c. The OF functions
in drivers/clk/clk.c aren't dependent on anything else in clk.c
(since you pass them a struct clk) so they can be moved out easily.
The of_clk_* entries in clk-provider.h move to clk.h.
2) Use alloc_bootmem() instead of kzalloc() in of_clk_add_provider(),
because we need to set up clocks during .init_early on ARM (which
happens pre-slab) so that they are available for platform init.
I'll send our patches in a reply to this mail. Are you okay with these
changes, and would you like to include them in your patchset?
Thanks very much,
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
next prev parent reply other threads:[~2012-06-21 7:27 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-12 14:41 [PATCH v3 0/4] DT clock bindings Rob Herring
2012-06-12 14:41 ` Rob Herring
2012-06-12 14:41 ` [PATCH v3 1/4] clk: add DT clock binding support Rob Herring
2012-06-12 14:41 ` Rob Herring
2012-06-15 3:17 ` Shawn Guo
2012-06-15 3:17 ` Shawn Guo
2012-06-15 3:17 ` Shawn Guo
2012-06-15 4:32 ` Rob Herring
2012-06-15 4:32 ` Rob Herring
2012-07-01 22:13 ` [PATCH v6] " Rob Herring
2012-07-01 22:13 ` Rob Herring
2012-07-01 22:13 ` Rob Herring
2012-06-12 14:41 ` [PATCH v3 2/4] clk: add DT fixed-clock " Rob Herring
2012-06-12 14:41 ` Rob Herring
2012-06-12 14:41 ` [PATCH v3 3/4] dt: add clock binding doc to primecell bindings Rob Herring
2012-06-12 14:41 ` Rob Herring
2012-06-22 13:55 ` Ben Dooks
2012-06-22 14:23 ` Russell King - ARM Linux
2012-06-12 14:41 ` [PATCH v3 4/4] clk: add highbank clock support Rob Herring
2012-06-12 14:41 ` Rob Herring
2012-06-12 15:47 ` [PATCH v3 0/4] DT clock bindings Mike Turquette
2012-06-12 15:47 ` Mike Turquette
2012-06-12 16:23 ` Rob Herring
2012-06-12 16:23 ` Rob Herring
2012-06-14 8:49 ` Shawn Guo
2012-06-14 8:49 ` Shawn Guo
2012-06-14 8:49 ` Shawn Guo
2012-06-13 15:26 ` Peter De Schrijver
2012-06-13 15:26 ` Peter De Schrijver
2012-06-13 18:09 ` Rob Herring
2012-06-13 18:09 ` Rob Herring
2012-06-15 8:39 ` Shawn Guo
2012-06-15 8:39 ` Shawn Guo
2012-06-15 8:39 ` Shawn Guo
2012-06-15 15:40 ` Stephen Warren
2012-06-15 15:40 ` Stephen Warren
2012-06-15 21:07 ` Rob Herring
2012-06-15 21:07 ` Rob Herring
2012-06-21 7:27 ` Chris Ball [this message]
2012-06-21 7:27 ` Chris Ball
2012-06-21 7:30 ` [PATCH 01/02] clk: Refactor of_clk_* into a new clk-of.c Chris Ball
2012-06-21 7:30 ` Chris Ball
2012-06-21 7:32 ` [PATCH 02/02] clk: clk-of: Use alloc_bootmem() instead of kzalloc() Chris Ball
2012-06-21 7:32 ` Chris Ball
2012-06-21 12:18 ` Paul Mundt
2012-06-21 12:18 ` Paul Mundt
2012-06-21 15:00 ` [PATCH v3 0/4] DT clock bindings Rob Herring
2012-06-21 15:00 ` Rob Herring
2012-06-21 17:54 ` Mike Turquette
2012-06-21 17:54 ` Mike Turquette
2012-06-27 12:54 ` Rob Herring
2012-06-27 12:54 ` Rob Herring
2012-07-03 1:30 ` Turquette, Mike
2012-07-03 1:30 ` Turquette, Mike
2012-07-03 2:37 ` Rob Herring
2012-07-03 2:37 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bokd15x7.fsf@octavius.laptop.org \
--to=cjb@laptop.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.