From: Kevin Hilman <khilman@deeprootsystems.com>
To: "Shilimkar, Santosh" <santosh.shilimkar@ti.com>
Cc: "Varadarajan, Charulatha" <charu@ti.com>,
Tony Lindgren <tony@atomide.com>,
"Cousson, Benoit" <b-cousson@ti.com>,
"Menon, Nishanth" <nm@ti.com>, "wim@iguana.be" <wim@iguana.be>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"paul@pwsan.com" <paul@pwsan.com>,
"Nayak, Rajendra" <rnayak@ti.com>,
"Basak, Partha" <p-basak2@ti.com>
Subject: Re: [PATCH] OMAP2PLUS: WDT: Fix: Disable WDT after reset during init
Date: Thu, 30 Sep 2010 10:11:49 -0700 [thread overview]
Message-ID: <87bp7ff962.fsf@deeprootsystems.com> (raw)
In-Reply-To: <EAF47CD23C76F840A9E7FCE10091EFAB030CD03185@dbde02.ent.ti.com> (Santosh Shilimkar's message of "Thu, 30 Sep 2010 22:35:05 +0530")
"Shilimkar, Santosh" <santosh.shilimkar@ti.com> writes:
>> -----Original Message-----
>> From: linux-omap-owner@vger.kernel.org [mailto:linux-omap-
>> owner@vger.kernel.org] On Behalf Of Varadarajan, Charulatha
>> Sent: Thursday, September 30, 2010 9:25 PM
>> To: Tony Lindgren; Cousson, Benoit
>> Cc: Kevin Hilman; Menon, Nishanth; wim@iguana.be; linux-
>> omap@vger.kernel.org; linux-watchdog@vger.kernel.org; linux-arm-
>> kernel@lists.infradead.org; paul@pwsan.com; Nayak, Rajendra; Basak, Partha
>> Subject: RE: [PATCH] OMAP2PLUS: WDT: Fix: Disable WDT after reset during
>> init
>>
>> Tony/ Benoit,
>>
>> > >
>> > > I think that disabling it should be done only if the CONFIG_OMAP_WDT
>> > > is not set.
>> >
>> > How about disabling is done always unless CONFIG_WATCHDOG_NOWAYOUT
>> > is set?
>>
>> As given in the patch description, this patch does a disable of watchdog
>> timer, during init, to avoid the system rebooting that happens due to
>> enabling of watchdog timer after a reset of the module (during hwmod init).
>>
>> According to the default WDT registers values, the system reboot would
>> happen in ~10s if watchdog is enabled with default values. Hence, after
>> a WDT module reset during init, the watchdog has to be disabled within 10s
>> otherwise the system will keep rebooting.
>>
>> Hence irrespective of CONFIG_WATCHDOG_NOWAYOUT/ CONFIG_OMAP_WDT,
>> the watchdog timer needs to be disabled after a WDT reset has happened.
>>
> One more option is to avoid the software reset using the CONFIG_OMAP_WDT
> flag. Something like below.
This was already proposed by Charu, and rejected.
Doing this means we have a dependency on particular bootloader init, and
we'd like to get rid of *all* assumptions about what the bootloader does
(or does not do.)
Kevin
WARNING: multiple messages have this Message-ID (diff)
From: khilman@deeprootsystems.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] OMAP2PLUS: WDT: Fix: Disable WDT after reset during init
Date: Thu, 30 Sep 2010 10:11:49 -0700 [thread overview]
Message-ID: <87bp7ff962.fsf@deeprootsystems.com> (raw)
In-Reply-To: <EAF47CD23C76F840A9E7FCE10091EFAB030CD03185@dbde02.ent.ti.com> (Santosh Shilimkar's message of "Thu, 30 Sep 2010 22:35:05 +0530")
"Shilimkar, Santosh" <santosh.shilimkar@ti.com> writes:
>> -----Original Message-----
>> From: linux-omap-owner at vger.kernel.org [mailto:linux-omap-
>> owner at vger.kernel.org] On Behalf Of Varadarajan, Charulatha
>> Sent: Thursday, September 30, 2010 9:25 PM
>> To: Tony Lindgren; Cousson, Benoit
>> Cc: Kevin Hilman; Menon, Nishanth; wim at iguana.be; linux-
>> omap at vger.kernel.org; linux-watchdog at vger.kernel.org; linux-arm-
>> kernel at lists.infradead.org; paul at pwsan.com; Nayak, Rajendra; Basak, Partha
>> Subject: RE: [PATCH] OMAP2PLUS: WDT: Fix: Disable WDT after reset during
>> init
>>
>> Tony/ Benoit,
>>
>> > >
>> > > I think that disabling it should be done only if the CONFIG_OMAP_WDT
>> > > is not set.
>> >
>> > How about disabling is done always unless CONFIG_WATCHDOG_NOWAYOUT
>> > is set?
>>
>> As given in the patch description, this patch does a disable of watchdog
>> timer, during init, to avoid the system rebooting that happens due to
>> enabling of watchdog timer after a reset of the module (during hwmod init).
>>
>> According to the default WDT registers values, the system reboot would
>> happen in ~10s if watchdog is enabled with default values. Hence, after
>> a WDT module reset during init, the watchdog has to be disabled within 10s
>> otherwise the system will keep rebooting.
>>
>> Hence irrespective of CONFIG_WATCHDOG_NOWAYOUT/ CONFIG_OMAP_WDT,
>> the watchdog timer needs to be disabled after a WDT reset has happened.
>>
> One more option is to avoid the software reset using the CONFIG_OMAP_WDT
> flag. Something like below.
This was already proposed by Charu, and rejected.
Doing this means we have a dependency on particular bootloader init, and
we'd like to get rid of *all* assumptions about what the bootloader does
(or does not do.)
Kevin
next prev parent reply other threads:[~2010-09-30 17:12 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-30 8:11 [PATCH] OMAP2PLUS: WDT: Fix: Disable WDT after reset during init Varadarajan, Charulatha
2010-09-30 8:11 ` Varadarajan, Charulatha
2010-09-30 9:07 ` Cousson, Benoit
2010-09-30 9:07 ` Cousson, Benoit
2010-09-30 13:55 ` Kevin Hilman
2010-09-30 13:55 ` Kevin Hilman
2010-09-30 14:12 ` Cousson, Benoit
2010-09-30 14:12 ` Cousson, Benoit
2010-09-30 14:51 ` Kevin Hilman
2010-09-30 14:51 ` Kevin Hilman
2010-09-30 15:07 ` Tony Lindgren
2010-09-30 15:07 ` Tony Lindgren
2010-09-30 15:55 ` Varadarajan, Charulatha
2010-09-30 15:55 ` Varadarajan, Charulatha
2010-09-30 16:32 ` Varadarajan, Charulatha
2010-09-30 16:32 ` Varadarajan, Charulatha
2010-09-30 16:43 ` Paul Walmsley
2010-09-30 16:43 ` Paul Walmsley
2010-09-30 16:51 ` Tony Lindgren
2010-09-30 16:51 ` Tony Lindgren
2010-09-30 16:46 ` Cousson, Benoit
2010-09-30 16:46 ` Cousson, Benoit
2010-09-30 16:57 ` Cousson, Benoit
2010-09-30 16:57 ` Cousson, Benoit
2010-09-30 17:06 ` Varadarajan, Charulatha
2010-09-30 17:06 ` Varadarajan, Charulatha
2010-09-30 17:05 ` Shilimkar, Santosh
2010-09-30 17:05 ` Shilimkar, Santosh
2010-09-30 17:11 ` Kevin Hilman [this message]
2010-09-30 17:11 ` Kevin Hilman
2010-10-01 7:26 ` Shilimkar, Santosh
2010-10-01 7:26 ` Shilimkar, Santosh
2010-10-01 13:33 ` Varadarajan, Charulatha
2010-10-01 13:33 ` Varadarajan, Charulatha
2010-10-01 14:43 ` Kevin Hilman
2010-10-01 14:43 ` Kevin Hilman
2010-10-01 17:12 ` Cousson, Benoit
2010-10-01 17:12 ` Cousson, Benoit
2010-09-30 13:57 ` Kevin Hilman
2010-09-30 13:57 ` Kevin Hilman
2010-09-30 13:57 ` Kevin Hilman
2010-09-30 16:36 ` Varadarajan, Charulatha
2010-09-30 16:36 ` Varadarajan, Charulatha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bp7ff962.fsf@deeprootsystems.com \
--to=khilman@deeprootsystems.com \
--cc=b-cousson@ti.com \
--cc=charu@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=nm@ti.com \
--cc=p-basak2@ti.com \
--cc=paul@pwsan.com \
--cc=rnayak@ti.com \
--cc=santosh.shilimkar@ti.com \
--cc=tony@atomide.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.