All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Mark Brown <broonie@sirena.org.uk>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
Subject: Re: [RFC/PATCH] pxa2xx_ac97 and gpio reset line
Date: Sun, 08 Mar 2009 19:59:38 +0100	[thread overview]
Message-ID: <87bpsb6dt1.fsf@free.fr> (raw)
In-Reply-To: <4C46CDB4-EF69-4B6F-929E-FCBE644A7FA5@sirena.org.uk> (Mark Brown's message of "Thu\, 19 Feb 2009 21\:21\:59 +0000")

Mark Brown <broonie@sirena.org.uk> writes:

> On 19 Feb 2009, at 20:44, Robert Jarzmik <robert.jarzmik@free.fr> wrote:
>
>> Hi Mark,
>>
>> I can't find out if somebody had submitted that kind of patch  before. This is
>> a
>> starting point of discussion. I'm not fully convinced by my own  code, and so
>> I
>> post it here for advice.
>>
>> What I'd really like is to be able to choose the PXA AC97 gpio reset  (GPIO95
>> or
>> GPIO113) through platform_data, but I couldn't find a way of doing  it. I hope
>> you'll have some kind of idea.
>
> This is a sensible idea in principle but should be done via platform  data for
> the AC97 driver rather than via Kconfig - it'll need an  update to use the
> platform in ASoC but I'll need to do those anyway.

Would you like me to help you with this platform data. This GPIO thing is
breaking mioa701 GSM chip (not damaging this time :)), so would you like me to
cook up the platform data passed to pxa2xx-ac97, and amend my patch accordingly
?

Or have you already coded the beast in your working repository ?

Cheers.

--
Robert

PS: passing that platform data is easy, I should have done it right from the
start. I can't see how I missed the simple platform_data in pxa2xx_ac97 probe
function ... grrr... Must be the belgian food I tried.

  reply	other threads:[~2009-03-08 18:59 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-19 20:44 [RFC/PATCH] pxa2xx_ac97 and gpio reset line Robert Jarzmik
2009-02-19 21:21 ` Mark Brown
2009-03-08 18:59   ` Robert Jarzmik [this message]
2009-03-08 19:31     ` Mark Brown
2009-03-08 19:45       ` Mark Brown
2009-03-14 21:27         ` Robert Jarzmik
2009-03-14 22:46           ` Mark Brown
2009-03-15 11:14             ` Robert Jarzmik
2009-03-15 11:26               ` Mark Brown
2009-03-15 12:36                 ` Robert Jarzmik
2009-03-15 12:52                   ` Mark Brown
2009-03-15 13:10                     ` Robert Jarzmik
2009-03-15 20:25                       ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bpsb6dt1.fsf@free.fr \
    --to=robert.jarzmik@free.fr \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@sirena.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.