All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Mark Brown <broonie@sirena.org.uk>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
Subject: Re: [RFC/PATCH] pxa2xx_ac97 and gpio reset line
Date: Sun, 15 Mar 2009 13:36:48 +0100	[thread overview]
Message-ID: <87hc1vezdr.fsf@free.fr> (raw)
In-Reply-To: <20090315112638.GA7439@sirena.org.uk> (Mark Brown's message of "Sun\, 15 Mar 2009 11\:26\:40 +0000")

Mark Brown <broonie@sirena.org.uk> writes:

> Could you change this to provide an explicit way of specifying that (eg,
> with -1 as the GPIO)?
Sure.

>  There are other things we might want platform data for in future - passing
> data to the AC97 codec, for example - so we can't rely on people not
> specifying platform data for anything.
I don't understand the "anything". What should be done if pdata is passed with
reset_gpio = 0 then ?

Should this be considered as the default case and transformed into 113 ? That
sounds a bit buggy, because if someone changes his code to include platform_data
support, they'll have to init platform_data anyway, and fill in reset_gpio
field.

Should this be handled like a casual gpio (ie. gpio 99) ?


--
Robert

  reply	other threads:[~2009-03-15 12:36 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-19 20:44 [RFC/PATCH] pxa2xx_ac97 and gpio reset line Robert Jarzmik
2009-02-19 21:21 ` Mark Brown
2009-03-08 18:59   ` Robert Jarzmik
2009-03-08 19:31     ` Mark Brown
2009-03-08 19:45       ` Mark Brown
2009-03-14 21:27         ` Robert Jarzmik
2009-03-14 22:46           ` Mark Brown
2009-03-15 11:14             ` Robert Jarzmik
2009-03-15 11:26               ` Mark Brown
2009-03-15 12:36                 ` Robert Jarzmik [this message]
2009-03-15 12:52                   ` Mark Brown
2009-03-15 13:10                     ` Robert Jarzmik
2009-03-15 20:25                       ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87hc1vezdr.fsf@free.fr \
    --to=robert.jarzmik@free.fr \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@sirena.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.