From: Markus Armbruster <armbru@redhat.com>
To: Akio Takebe <takebe_akio@jp.fujitsu.com>
Cc: xen-devel <xen-devel@lists.xensource.com>
Subject: [PATCH] fbfront: Improve diagnostics when kthread_run() fails
Date: Mon, 02 Feb 2009 10:17:22 +0100 [thread overview]
Message-ID: <87bptlp599.fsf_-_@pike.pond.sub.org> (raw)
In-Reply-To: <498009CC.1000101@jp.fujitsu.com> (Akio Takebe's message of "Wed\, 28 Jan 2009 16\:31\:24 +0900")
Failure is reported with xenbus_dev_fatal(..."register_framebuffer"),
which was already suboptimal before it got moved away from
register_framebuffer(), and is outright misleading now.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
diff -r 26ddc59c674d drivers/xen/fbfront/xenfb.c
--- a/drivers/xen/fbfront/xenfb.c Fri Jan 30 10:54:10 2009 +0000
+++ b/drivers/xen/fbfront/xenfb.c Mon Feb 02 10:12:54 2009 +0100
@@ -211,7 +211,7 @@
return;
mutex_lock(&info->mm_lock);
-
+
spin_lock_irqsave(&info->dirty_lock, flags);
if (info->dirty){
info->dirty = 0;
@@ -837,7 +837,7 @@
if (IS_ERR(info->kthread)) {
info->kthread = NULL;
xenbus_dev_fatal(dev, PTR_ERR(info->kthread),
- "register_framebuffer");
+ "xenfb_thread");
}
}
break;
next prev parent reply other threads:[~2009-02-02 9:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-27 2:58 [Patch] fix xenfb_update_screen bogus rect Akio Takebe
2009-01-27 8:16 ` Jan Beulich
2009-01-28 7:31 ` Akio Takebe
2009-01-28 9:06 ` Jan Beulich
2009-01-28 14:33 ` Markus Armbruster
2009-01-29 9:12 ` Akio Takebe
2009-01-29 14:29 ` Markus Armbruster
2009-01-28 14:31 ` Markus Armbruster
2009-01-29 12:54 ` Akio Takebe
2009-01-29 14:44 ` Markus Armbruster
2009-01-30 2:02 ` Akio Takebe
2009-01-30 7:38 ` Markus Armbruster
2009-02-02 9:17 ` Markus Armbruster [this message]
2009-02-02 23:48 ` [PATCH] fbfront: Improve diagnostics when kthread_run()fails Akio Takebe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bptlp599.fsf_-_@pike.pond.sub.org \
--to=armbru@redhat.com \
--cc=takebe_akio@jp.fujitsu.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.