All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marco Gerards <metgerards@student.han.nl>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [ppc patch] fix line-wrapping
Date: Tue, 08 Nov 2005 19:20:47 +0100	[thread overview]
Message-ID: <87br0vknls.fsf@student.han.nl> (raw)
In-Reply-To: <28ec5adc7b401784d274908e3a641565@penguinppc.org> (Hollis Blanchard's message of "Mon, 7 Nov 2005 22:55:04 -0600")

Hollis Blanchard <hollis@penguinppc.org> writes:

> This patch fixes the line-wrapping problems we've been having on
> PPC. I rearranged grub_ofconsole_getwh() slightly to avoid excessive
> indentation. I will apply soon unless people criticize my ChangeLog
> entry. ;)

Great!  This was a very annoying bug.

> Index: ChangeLog
> ===================================================================
> RCS file: /cvsroot/grub/grub2/ChangeLog,v
> retrieving revision 1.193
> diff -u -p -r1.193 ChangeLog
> --- ChangeLog	7 Nov 2005 22:28:55 -0000	1.193
> +++ ChangeLog	8 Nov 2005 04:50:12 -0000
> @@ -1,3 +1,12 @@
> +2005-11-03  Hollis Blanchard  <hollis@penguinppc.org>
> +
> +	* term/ieee1275/ofconsole.c (grub_ofconsole_width): New variable.
> +	(grub_ofconsole_height): Likewise.
> +	(grub_ofconsole_putchar): If grub_curr_x exceeds console width,
> +	manually insert a '\n'.

This won't work if the width can not be read from the firmware.  IIRC
the pegasos has such bug.  I should have a look at that...

Feel free to apply the patch. :-)

Thanks,
Marco




  reply	other threads:[~2005-11-08 18:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-08  4:55 [ppc patch] fix line-wrapping Hollis Blanchard
2005-11-08 18:20 ` Marco Gerards [this message]
2005-11-09  6:05   ` Hollis Blanchard
2005-11-08 18:28 ` Dennis Clarke
2005-11-08 18:34   ` Marco Gerards

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87br0vknls.fsf@student.han.nl \
    --to=metgerards@student.han.nl \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.