All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marco Gerards <metgerards@student.han.nl>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [patch] set prefix on PPC
Date: Fri, 15 Apr 2005 22:24:35 +0200	[thread overview]
Message-ID: <87br8fkcu4.fsf@student.han.nl> (raw)
In-Reply-To: <20050414023823.GA24293@miracle> (Hollis Blanchard's message of "Wed, 13 Apr 2005 21:38:23 -0500")

Hollis Blanchard <hollis@penguinppc.org> writes:

> Marco, I believe I addressed all your comments in my mail on 23 Feb
> 2005. I have implemented your suggestions, with the exception of
> checking the device node property lengths, as this requires modifying
> many callers elsewhere in the code.
>
> I will commit this in a couple days if I don't hear any complaints.

There is a problem with the patch, so please don't.  When booting on
the pegasosII I see the following problem:

grub> set
prefix=(/pci@80000000/ide@C,1/disk@0,0,3)

That is when I am booting using `boot hd:4 grub)'.

The prefix contains an OF device name which will not work in GRUB,
mainly because of the comma's.  Would it be possible to lookup the OF
path in /aliases and set the prefix to the alias?  That will be
something that will work and is more user friendly I think.

Another thing we could do, but which is a bit more ugly, is creating
an alias.  I am not sure if it is possible to create an OF alias from
GRUB, but I assume it will be.

Shouldn't the prefix end with a `/' like you mentioned in one of your
other emails.  So in this case:

prefix=(/pci@80000000/ide@C,1/disk@0,0,3)/


Thanks,
Marco




  parent reply	other threads:[~2005-04-15 20:41 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-04-14  2:38 [patch] set prefix on PPC Hollis Blanchard
2005-04-14 17:13 ` Marco Gerards
2005-04-15 20:24 ` Marco Gerards [this message]
2005-04-17 18:42   ` Hollis Blanchard
2005-04-17 19:23     ` Marco Gerards
  -- strict thread matches above, loose matches on Subject: below --
2005-04-17 18:33 Hollis Blanchard
2005-04-17 19:38 ` Marco Gerards
2005-04-17 20:32   ` Hollis Blanchard
2005-02-13 16:54 Hollis Blanchard
2005-02-13 18:35 ` Marco Gerards
2005-02-13 19:52   ` Hollis Blanchard
2005-02-14 19:01     ` Marco Gerards
2005-02-15 16:39       ` Hollis Blanchard
2005-02-15 21:31         ` Marco Gerards
2005-02-20  0:21           ` Hollis Blanchard
2005-02-20 17:50             ` Marco Gerards
2005-02-24  4:44               ` Hollis Blanchard
2005-04-14 16:35                 ` Marco Gerards
2005-02-21 19:01 ` Marco Gerards
2005-02-24  4:40   ` Hollis Blanchard
2005-04-14 17:05     ` Marco Gerards

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87br8fkcu4.fsf@student.han.nl \
    --to=metgerards@student.han.nl \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.