All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marco Gerards <metgerards@student.han.nl>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [patch] set prefix on PPC
Date: Thu, 14 Apr 2005 19:13:32 +0200	[thread overview]
Message-ID: <877jj5ffib.fsf@student.han.nl> (raw)
In-Reply-To: <20050414023823.GA24293@miracle> (Hollis Blanchard's message of "Wed, 13 Apr 2005 21:38:23 -0500")

Hollis Blanchard <hollis@penguinppc.org> writes:

> Marco, I believe I addressed all your comments in my mail on 23 Feb
> 2005. I have implemented your suggestions, with the exception of
> checking the device node property lengths, as this requires modifying
> many callers elsewhere in the code.

Ok.  I will test the patch on both of my machines to see if it works
for me.

> I will commit this in a couple days if I don't hear any complaints.

Ok.

> Index: loader/powerpc/ieee1275/linux.c
> ===================================================================
> RCS file: /cvsroot/grub/grub2/loader/powerpc/ieee1275/linux.c,v
> retrieving revision 1.6
> diff -u -p -r1.6 linux.c
> --- loader/powerpc/ieee1275/linux.c	14 Feb 2005 18:41:33 -0000	1.6
> +++ loader/powerpc/ieee1275/linux.c	14 Apr 2005 02:57:01 -0000
> @@ -55,7 +55,7 @@ grub_linux_boot (void)
>    /* Set the command line arguments.  */
>    grub_ieee1275_set_property (chosen, "bootargs", linux_args,
>  			      grub_strlen (linux_args) + 1, &actual);
> -  
> +
>    /* Boot the kernel.  */
>    linuxmain = (kernel_entry_t) linux_addr;
>    linuxmain ((void *) initrd_addr, initrd_size, grub_ieee1275_entry_fn, 0, 0);

Can you fix this? :)

--
Marco




  reply	other threads:[~2005-04-14 17:17 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-04-14  2:38 [patch] set prefix on PPC Hollis Blanchard
2005-04-14 17:13 ` Marco Gerards [this message]
2005-04-15 20:24 ` Marco Gerards
2005-04-17 18:42   ` Hollis Blanchard
2005-04-17 19:23     ` Marco Gerards
  -- strict thread matches above, loose matches on Subject: below --
2005-04-17 18:33 Hollis Blanchard
2005-04-17 19:38 ` Marco Gerards
2005-04-17 20:32   ` Hollis Blanchard
2005-02-13 16:54 Hollis Blanchard
2005-02-13 18:35 ` Marco Gerards
2005-02-13 19:52   ` Hollis Blanchard
2005-02-14 19:01     ` Marco Gerards
2005-02-15 16:39       ` Hollis Blanchard
2005-02-15 21:31         ` Marco Gerards
2005-02-20  0:21           ` Hollis Blanchard
2005-02-20 17:50             ` Marco Gerards
2005-02-24  4:44               ` Hollis Blanchard
2005-04-14 16:35                 ` Marco Gerards
2005-02-21 19:01 ` Marco Gerards
2005-02-24  4:40   ` Hollis Blanchard
2005-04-14 17:05     ` Marco Gerards

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877jj5ffib.fsf@student.han.nl \
    --to=metgerards@student.han.nl \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.