From: "Alex Bennée" <alex.bennee@linaro.org>
To: Nagendran Jairam <nagendranjairam52@gmail.com>
Cc: qemu-devel@nongnu.org, berrange@redhat.com, philmd@linaro.org,
daan.j.demeyer@gmail.com, peter.maydell@linaro.org,
Alistair <alistair@alistair23.me>
Subject: Re: [PATCH v3] hw/core/loader.c: Add Extended Tektronix HEX file support
Date: Fri, 20 Nov 2026 15:08:59 +0000 [thread overview]
Message-ID: <87cxrz5ylw.fsf@draig.linaro.org> (raw)
In-Reply-To: <CAEAkEp7jbv=uZS61Yd6V-zfNr6cp-MjgHBStC08ft3qROfE2bA@mail.gmail.com> (Nagendran Jairam's message of "Fri, 20 Nov 2026 19:39:50 +0530")
Nagendran Jairam <nagendranjairam52@gmail.com> writes:
> On Fri, Nov 20, 2026, 17:35 Alex Bennée <alex.bennee@linaro.org> wrote:
>
> Nagendran K <nagendranjairam52@gmail.com> writes:
>
> > Add support for loading Extended Tektronix HEX files through the
> > generic loader.
> >
> > The loader parses Extended Tektronix records, validates their
> > checksums, and loads the data at the addresses specified in the file.
> >
> > This allows Extended Tektronix files to be loaded directly without
> > manual conversion to another supported format.
> >
> > Tested by loading an Extended Tektronix file containing a simple UART
> > application on the RealView EB machine. The application executed
> > successfully and produced the expected UART output.
> >
> > Signed-off-by: Nagendran K <nagendranjairam52@gmail.com>
>
> Ok before you send another version you should consider:
>
> - split whitespace and comment updates into their own patches
> - include a test case for the loader to show its use
> - verify the whole series applies and builds cleanly on upstream's master branch
>
> And the cover letter for the series should also include what changes
> you've made between each iteration. You can also include a summary of
> updates under the --- in the commit messages.
>
> --
> Alex Bennée
> Virtualisation Tech Lead @ Linaro
>
> Ok sure, but where do I upload cover letter and testcase means the baremetal build through which I tested or just overall summary
> of how did I test?
The cover letter is part of a multi-patch series, there is tooling you
can use to help prepare a series:
https://www.qemu.org/docs/master/devel/submitting-a-patch.html#submitting-your-patches
For the testcase you can either publish a binary asset somewhere and
write a functional test:
https://www.qemu.org/docs/master/devel/testing/functional.html
Or work out how to build one of the tcg tests and package it up as a hex
file and add a run to test it.
> Nagendran
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
prev parent reply other threads:[~2026-11-20 15:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-12 18:49 [PATCH v3] hw/core/loader.c: Add Extended Tektronix HEX file support Nagendran K
2026-11-20 0:49 ` Alistair
2026-11-20 12:05 ` Alex Bennée
2026-11-20 14:09 ` Nagendran Jairam
2026-11-20 15:08 ` Alex Bennée [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cxrz5ylw.fsf@draig.linaro.org \
--to=alex.bennee@linaro.org \
--cc=alistair@alistair23.me \
--cc=berrange@redhat.com \
--cc=daan.j.demeyer@gmail.com \
--cc=nagendranjairam52@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.