All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: Nagendran K <nagendranjairam52@gmail.com>
Cc: qemu-devel@nongnu.org,  berrange@redhat.com,  philmd@linaro.org,
	daan.j.demeyer@gmail.com,  peter.maydell@linaro.org,
	alistair@alistair23.me
Subject: Re: [PATCH v3] hw/core/loader.c: Add Extended Tektronix HEX file support
Date: Fri, 20 Nov 2026 12:05:44 +0000	[thread overview]
Message-ID: <87ik1r673b.fsf@draig.linaro.org> (raw)
In-Reply-To: <20261112184949.1042-1-nagendranjairam52@gmail.com> (Nagendran K.'s message of "Fri, 13 Nov 2026 00:19:48 +0530")

Nagendran K <nagendranjairam52@gmail.com> writes:

> Add support for loading Extended Tektronix HEX files through the
> generic loader.
>
> The loader parses Extended Tektronix records, validates their
> checksums, and loads the data at the addresses specified in the file.
>
> This allows Extended Tektronix files to be loaded directly without
> manual conversion to another supported format.
>
> Tested by loading an Extended Tektronix file containing a simple UART
> application on the RealView EB machine. The application executed
> successfully and produced the expected UART output.
>
> Signed-off-by: Nagendran K <nagendranjairam52@gmail.com>

Ok before you send another version you should consider:

  - split whitespace and comment updates into their own patches
  - include a test case for the loader to show its use
  - verify the whole series applies and builds cleanly on upstream's master branch

And the cover letter for the series should also include what changes
you've made between each iteration. You can also include a summary of
updates under the --- in the commit messages.

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro


  parent reply	other threads:[~2026-11-20 12:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-12 18:49 [PATCH v3] hw/core/loader.c: Add Extended Tektronix HEX file support Nagendran K
2026-11-20  0:49 ` Alistair
2026-11-20 12:05 ` Alex Bennée [this message]
2026-11-20 14:09   ` Nagendran Jairam
2026-11-20 15:08     ` Alex Bennée

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ik1r673b.fsf@draig.linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=alistair@alistair23.me \
    --cc=berrange@redhat.com \
    --cc=daan.j.demeyer@gmail.com \
    --cc=nagendranjairam52@gmail.com \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.