All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Bastien Curutchet <bastien.curutchet@bootlin.com>
Cc: Richard Weinberger <richard@nod.at>,
	 Vignesh Raghavendra <vigneshr@ti.com>,
	 Michal Simek <michal.simek@amd.com>,
	 Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	 linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
	 stable@vger.kernel.org
Subject: Re: [PATCH 0/4] rawnand: pl35x: Implement mixed ECC
Date: Fri, 07 Aug 2026 16:01:17 +0200	[thread overview]
Message-ID: <87cxvuav2q.fsf@bootlin.com> (raw)
In-Reply-To: <20260723-mix-ecc-v1-0-7361c3baeb07@bootlin.com> (Bastien Curutchet's message of "Thu, 23 Jul 2026 15:41:00 +0200")

Hello Bastien,

On 23/07/2026 at 15:41:00 +02, Bastien Curutchet <bastien.curutchet@bootlin.com> wrote:

> Hi all,
>
> This series addresses the PL353 errata "SLC ECC misses single error to
> bit0 byte0 and fails to detect some double error cases" (see 721059 in
> [1]).
>
> The ECC HW engine is known to be broken on this chip, it fails to detect
> some bitflips on reads.
>
> This series implements a mixed-ECC where the HW engine is used on writes
> and reads are done by software. To make it work, the software ECC has to
> use the same layout for the ECC bits than the HW engine. Patches 1 & 2
> add the PL35x ordering to the available orderings for soft ECC. Patches
> 3 & 4 make use of this ordering to implement the mixed-ECC for the PL353
> controller.
>
> Note that this series is based on top of nand/next.
>
> [1]: https://developer.arm.com/documentation/rlnc000227/a
>
> Signed-off-by: Bastien Curutchet <bastien.curutchet@bootlin.com>
> ---

There are several interesting Sashiko findings for this series, can you
please have a look?

Thanks!
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Bastien Curutchet <bastien.curutchet@bootlin.com>
Cc: Richard Weinberger <richard@nod.at>,
	 Vignesh Raghavendra <vigneshr@ti.com>,
	 Michal Simek <michal.simek@amd.com>,
	 Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	 linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
	 stable@vger.kernel.org
Subject: Re: [PATCH 0/4] rawnand: pl35x: Implement mixed ECC
Date: Fri, 07 Aug 2026 16:01:17 +0200	[thread overview]
Message-ID: <87cxvuav2q.fsf@bootlin.com> (raw)
In-Reply-To: <20260723-mix-ecc-v1-0-7361c3baeb07@bootlin.com> (Bastien Curutchet's message of "Thu, 23 Jul 2026 15:41:00 +0200")

Hello Bastien,

On 23/07/2026 at 15:41:00 +02, Bastien Curutchet <bastien.curutchet@bootlin.com> wrote:

> Hi all,
>
> This series addresses the PL353 errata "SLC ECC misses single error to
> bit0 byte0 and fails to detect some double error cases" (see 721059 in
> [1]).
>
> The ECC HW engine is known to be broken on this chip, it fails to detect
> some bitflips on reads.
>
> This series implements a mixed-ECC where the HW engine is used on writes
> and reads are done by software. To make it work, the software ECC has to
> use the same layout for the ECC bits than the HW engine. Patches 1 & 2
> add the PL35x ordering to the available orderings for soft ECC. Patches
> 3 & 4 make use of this ordering to implement the mixed-ECC for the PL353
> controller.
>
> Note that this series is based on top of nand/next.
>
> [1]: https://developer.arm.com/documentation/rlnc000227/a
>
> Signed-off-by: Bastien Curutchet <bastien.curutchet@bootlin.com>
> ---

There are several interesting Sashiko findings for this series, can you
please have a look?

Thanks!
Miquèl

  parent reply	other threads:[~2026-08-07 14:01 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-23 13:41 [PATCH 0/4] rawnand: pl35x: Implement mixed ECC Bastien Curutchet
2026-07-23 13:41 ` Bastien Curutchet
2026-07-23 13:41 ` [PATCH 1/4] nand: hamming: Replace sm_order boolean with enum Bastien Curutchet
2026-07-23 13:41   ` Bastien Curutchet
2026-07-23 13:41 ` [PATCH 2/4] nand: hamming: Add support for the PL35x ECC bit ordering Bastien Curutchet
2026-07-23 13:41   ` Bastien Curutchet
2026-07-23 13:41 ` [PATCH 3/4] rawnand: base: Export nand_read_page_swecc Bastien Curutchet
2026-07-23 13:41   ` Bastien Curutchet
2026-07-23 13:41 ` [PATCH 4/4] rawnand: pl35x: Implement mixed ECC computing Bastien Curutchet
2026-07-23 13:41   ` Bastien Curutchet
2026-08-07 14:01 ` Miquel Raynal [this message]
2026-08-07 14:01   ` [PATCH 0/4] rawnand: pl35x: Implement mixed ECC Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87cxvuav2q.fsf@bootlin.com \
    --to=miquel.raynal@bootlin.com \
    --cc=bastien.curutchet@bootlin.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=michal.simek@amd.com \
    --cc=richard@nod.at \
    --cc=stable@vger.kernel.org \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.