All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Santhosh Kumar K <s-k6@ti.com>
Cc: "Mark Brown" <broonie@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Geert Uytterhoeven" <geert+renesas@glider.be>,
	"Magnus Damm" <magnus.damm@gmail.com>,
	"Vaishnav Achath" <vaishnav.a@ti.com>,
	"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
	"Hervé Codina" <herve.codina@bootlin.com>,
	"Wolfram Sang" <wsa+renesas@sang-engineering.com>,
	"Vignesh Raghavendra" <vigneshr@ti.com>,
	"Pratyush Yadav" <pratyush@kernel.org>,
	"Pascal Eberhard" <pascal.eberhard@se.com>,
	linux-spi@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v2 00/13] spi: cadence-qspi: Add Renesas RZ/N1 support
Date: Tue, 20 Jan 2026 16:05:35 +0100	[thread overview]
Message-ID: <87cy34s4sg.fsf@bootlin.com> (raw)
In-Reply-To: <80e7a578-4636-48bd-b92b-54fa33cc076d@ti.com> (Santhosh Kumar K.'s message of "Tue, 20 Jan 2026 14:52:38 +0530")

Hi Santhosh,

On 20/01/2026 at 14:52:38 +0530, Santhosh Kumar K <s-k6@ti.com> wrote:

> Hello Miquel,
>
> On 15/01/26 14:54, Miquel Raynal (Schneider Electric) wrote:
>> Hello,
>> This series adds support for the QSPI controller available on Renesas
>> RZ/N1S and RZ/N1D SoC. It has been tested with a custom board (see last
>> SPI patch for details).
>> Adding support for this SoC required a few adaptations in the Cadence
>> QSPI driver. The bulk of the work is in the few last patches. Everything
>> else is just misc style fixes and improvements which bothered me while I
>> was wandering.
>> In order to support all constraints, I sometimes used a new quirk (for
>> the write protection feature and the "no indirect mode"), and sometimes
>> used the compatible directly. The ones I thought might not be RZ/N1
>> specific have been implemented under the form of a quirk, in order to
>> ease their reuse. The other adaptations, which I believe are more
>> Renesas specific, have been handled using the compatible. This is all
>> very arbitrary, and can be discussed.
>> Thanks,
>> Miquèl
>> Signed-off-by: Miquel Raynal (Schneider Electric)
>> <miquel.raynal@bootlin.com>
>
> Thank you for the series! Tested it on TI's AM62A SK with
> OSPI NAND (Winbond's W35N01JW).
>
> Controller fails to probe with the following message:
>
> [    1.868863] cadence-qspi fc40000.spi: Cannot claim mandatory QSPI ref
> clock.

Strange, I was nonetheless careful not to change the existing
behaviour on other SoCs. I have that board, I will give it a try.

Thanks a lot for the feedback.
Miquèl

  reply	other threads:[~2026-01-20 15:05 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-15  9:24 [PATCH v2 00/13] spi: cadence-qspi: Add Renesas RZ/N1 support Miquel Raynal (Schneider Electric)
2026-01-15  9:24 ` [PATCH v2 01/13] spi: dt-bindings: cdns,qspi-nor: Add Renesas RZ/N1D400 to the list Miquel Raynal (Schneider Electric)
2026-01-15 12:45   ` Geert Uytterhoeven
2026-01-16  9:39     ` Miquel Raynal
2026-01-21  2:40       ` Rob Herring
2026-01-21 10:39         ` Miquel Raynal
2026-01-15  9:24 ` [PATCH v2 02/13] spi: cadence-qspi: Align definitions Miquel Raynal (Schneider Electric)
2026-01-15  9:24 ` [PATCH v2 03/13] spi: cadence-qspi: Fix style and improve readability Miquel Raynal (Schneider Electric)
2026-01-15  9:24 ` [PATCH v2 04/13] spi: cadence-qspi: Fix ORing style and alignments Miquel Raynal (Schneider Electric)
2026-01-15  9:24 ` [PATCH v2 05/13] spi: cadence-qspi: Remove an useless operation Miquel Raynal (Schneider Electric)
2026-01-15  9:24 ` [PATCH v2 06/13] spi: cadence-qspi: Make sure we filter out unsupported ops Miquel Raynal
2026-01-15  9:24 ` [PATCH v2 07/13] spi: cadence-qspi: Fix probe error path and remove Miquel Raynal (Schneider Electric)
2026-01-15  9:24 ` [PATCH v2 08/13] spi: cadence-qspi: Try hard to disable the clocks Miquel Raynal (Schneider Electric)
2026-01-15  9:25 ` [PATCH v2 09/13] spi: cadence-qspi: Kill cqspi_jh7110_clk_init Miquel Raynal (Schneider Electric)
2026-01-15  9:25 ` [PATCH v2 10/13] spi: cadence-qspi: Add a flag for controllers without indirect access support Miquel Raynal (Schneider Electric)
2026-01-15  9:25 ` [PATCH v2 11/13] spi: cadence-qspi: Make sure write protection is disabled Miquel Raynal (Schneider Electric)
2026-01-15  9:25 ` [PATCH v2 12/13] spi: cadence-qspi: Add support for the Renesas RZ/N1 controller Miquel Raynal (Schneider Electric)
2026-01-15  9:25 ` [PATCH v2 13/13] ARM: dts: r9a06g032: Describe the QSPI controller Miquel Raynal (Schneider Electric)
2026-01-15 13:00   ` Geert Uytterhoeven
2026-01-16  9:49     ` Miquel Raynal
2026-01-16 10:07       ` Geert Uytterhoeven
2026-01-16 15:19         ` Miquel Raynal
2026-01-21 17:03     ` Miquel Raynal
2026-01-16 11:26 ` [PATCH v2 00/13] spi: cadence-qspi: Add Renesas RZ/N1 support Wolfram Sang
2026-01-20  9:22 ` Santhosh Kumar K
2026-01-20 15:05   ` Miquel Raynal [this message]
2026-01-21 10:37     ` Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87cy34s4sg.fsf@bootlin.com \
    --to=miquel.raynal@bootlin.com \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=geert+renesas@glider.be \
    --cc=herve.codina@bootlin.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=pascal.eberhard@se.com \
    --cc=pratyush@kernel.org \
    --cc=robh@kernel.org \
    --cc=s-k6@ti.com \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=vaishnav.a@ti.com \
    --cc=vigneshr@ti.com \
    --cc=wsa+renesas@sang-engineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.