All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: BALATON Zoltan <balaton@eik.bme.hu>
Cc: qemu-devel@nongnu.org, "Aurelien Jarno" <aurelien@aurel32.net>,
	"Jiaxun Yang" <jiaxun.yang@flygoat.com>,
	"Bastian Koppelmann" <kbastian@rumtueddeln.de>,
	"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
	"Zhao Liu" <zhao1.liu@intel.com>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Laurent Vivier" <laurent@vivier.eu>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	qemu-arm@nongnu.org, "Yoshinori Sato" <yoshinori.sato@nifty.com>,
	"Yanan Wang" <wangyanan55@huawei.com>,
	"Aleksandar Rikalo" <arikalo@gmail.com>,
	"Thomas Huth" <huth@tuxfamily.org>,
	"Eduardo Habkost" <eduardo@habkost.net>
Subject: Re: [RFC PATCH 02/12] target/m68k: introduce env->reset_pc
Date: Thu, 08 Jan 2026 17:44:33 +0000	[thread overview]
Message-ID: <87cy3k80e6.fsf@draig.linaro.org> (raw)
In-Reply-To: <7361d961-6dbf-57af-b5e6-93f32c1b2b4c@eik.bme.hu> (BALATON Zoltan's message of "Thu, 8 Jan 2026 18:14:57 +0100 (CET)")

BALATON Zoltan <balaton@eik.bme.hu> writes:

> On Thu, 8 Jan 2026, Alex Bennée wrote:
>> To transition CPUs to use the multi-phase resettable logic we need to
>> stash some information for the reset handlers. Arm does this with
>> arm_boot_info but for m68k all we really need is the PC we should
>> reset to.
>>
>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>> ---
>> target/m68k/cpu.h | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/target/m68k/cpu.h b/target/m68k/cpu.h
>> index d9db6a486a8..fda015c4b7b 100644
>> --- a/target/m68k/cpu.h
>> +++ b/target/m68k/cpu.h
>> @@ -155,6 +155,7 @@ typedef struct CPUArchState {
>>
>>     /* Fields from here on are preserved across CPU reset. */
>>     uint64_t features;
>> +    uint32_t reset_pc;
>
> The m64k CPUs are 32 bit but should this better use some other type
> like vaddr or hwaddr here?

Possibly - but the underlying env->pc is also a unint32_t so I didn't
see the point of adding more churn.

>
> Regards.
> BALATON Zoltan
>
>> } CPUM68KState;
>>
>> /*
>>

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro


  parent reply	other threads:[~2026-01-08 17:44 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-08 14:34 [RFC PATCH 00/12] cpu_reset clean-ups for arm, sh4, mips, m68k and tricore Alex Bennée
2026-01-08 14:34 ` [RFC PATCH 01/12] target/sh4: drop cpu_reset from realizefn Alex Bennée
2026-01-11  7:51   ` Richard Henderson
2026-01-12 13:58   ` Philippe Mathieu-Daudé
2026-01-08 14:34 ` [RFC PATCH 02/12] target/m68k: introduce env->reset_pc Alex Bennée
2026-01-08 17:14   ` BALATON Zoltan
2026-01-08 17:23     ` BALATON Zoltan
2026-01-08 17:44     ` Alex Bennée [this message]
2026-01-10  5:33   ` Thomas Huth
2026-01-11  7:52   ` Richard Henderson
2026-01-13  1:17     ` Richard Henderson
2026-01-08 14:34 ` [RFC PATCH 03/12] hw/m68k: register a nextcube_cpu_reset handler Alex Bennée
2026-01-10  5:42   ` Thomas Huth
2026-01-13  1:20   ` Richard Henderson
2026-01-08 14:34 ` [RFC PATCH 04/12] hw/m68k: register a mcf5208evb_cpu_reset handler Alex Bennée
2026-01-13  1:21   ` Richard Henderson
2026-01-13 16:38   ` Peter Maydell
2026-01-13 18:08     ` BALATON Zoltan
2026-01-13 18:30       ` Peter Maydell
2026-01-13 22:12         ` BALATON Zoltan
2026-01-08 14:34 ` [RFC PATCH 05/12] hw/m68k: register a an5206_cpu_reset handler Alex Bennée
2026-01-10  5:50   ` Thomas Huth
2026-01-13  1:22   ` Richard Henderson
2026-01-08 14:34 ` [RFC PATCH 06/12] hw/m68k: just use reset_pc for virt platform Alex Bennée
2026-01-10  5:52   ` Thomas Huth
2026-01-13  1:19   ` Richard Henderson
2026-01-08 14:34 ` [RFC PATCH 07/12] target/m68k: drop cpu_reset on realizefn Alex Bennée
2026-01-10  5:53   ` Thomas Huth
2026-01-11  7:55   ` Richard Henderson
2026-01-08 14:34 ` [RFC PATCH 08/12] hw/mips: defer finalising gcr_base until reset time Alex Bennée
2026-01-13 16:29   ` Peter Maydell
2026-01-08 14:34 ` [RFC PATCH 09/12] hw/mips: drop cpu_reset in mips_cpu_realizefn Alex Bennée
2026-01-08 14:34 ` [RFC PATCH 10/12] target/tricore: move cpu_reset from tricore_cpu_realizefn Alex Bennée
2026-01-13 16:46   ` Peter Maydell
2026-01-08 14:34 ` [RFC PATCH 11/12] target/arm: remove extraneous cpu_reset from realizefn Alex Bennée
2026-01-08 14:34 ` [RFC PATCH 12/12] include/hw: expand cpu_reset function docs Alex Bennée
2026-01-13  1:24   ` Richard Henderson
2026-01-08 15:35 ` [RFC PATCH 00/12] cpu_reset clean-ups for arm, sh4, mips, m68k and tricore Philippe Mathieu-Daudé
2026-01-08 16:34   ` Alex Bennée
2026-01-13 16:51     ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87cy3k80e6.fsf@draig.linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=arikalo@gmail.com \
    --cc=aurelien@aurel32.net \
    --cc=balaton@eik.bme.hu \
    --cc=eduardo@habkost.net \
    --cc=huth@tuxfamily.org \
    --cc=jiaxun.yang@flygoat.com \
    --cc=kbastian@rumtueddeln.de \
    --cc=laurent@vivier.eu \
    --cc=marcel.apfelbaum@gmail.com \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=wangyanan55@huawei.com \
    --cc=yoshinori.sato@nifty.com \
    --cc=zhao1.liu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.