All of lore.kernel.org
 help / color / mirror / Atom feed
From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: Christoph Hellwig <hch@lst.de>
Cc: Christian Brauner <brauner@kernel.org>,
	Al Viro <viro@zeniv.linux.org.uk>,
	David Sterba <dsterba@suse.com>, Jan Kara <jack@suse.cz>,
	Mike Marshall <hubcap@omnibond.com>,
	Martin Brandenburg <martin@omnibond.com>,
	Carlos Maiolino <cem@kernel.org>, Stefan Roesch <shr@fb.com>,
	Jeff Layton <jlayton@kernel.org>,
	Trond Myklebust <trondmy@kernel.org>,
	Anna Schumaker <anna@kernel.org>,
	linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org, gfs2@lists.linux.dev,
	io-uring@vger.kernel.org, devel@lists.orangefs.org,
	linux-unionfs@vger.kernel.org, linux-mtd@lists.infradead.org,
	linux-xfs@vger.kernel.org, linux-nfs@vger.kernel.org
Subject: Re: [PATCH 04/11] fat: cleanup the flags for fat_truncate_time
Date: Tue, 06 Jan 2026 19:45:17 +0900	[thread overview]
Message-ID: <87cy3nrpdu.fsf@mail.parknet.co.jp> (raw)
In-Reply-To: <20260106075008.1610195-5-hch@lst.de>

Christoph Hellwig <hch@lst.de> writes:

> Fat only has a single on-disk timestamp covering ctime and mtime.  Add
> fat-specific flags that indicate which timestamp fat_truncate_time should
> update to make this more clear.  This allows removing no-op
> fat_truncate_time calls with the S_CTIME flag and prepares for removing
> the S_* flags.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>

This breaks fat_update_time() by calling fat_truncate_time() with old
S_* flags (later patch looks like fixing though). Please add the commit
comment about it, or fix it in this patch.

Thanks.
-- 
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>

WARNING: multiple messages have this Message-ID (diff)
From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: Christoph Hellwig <hch@lst.de>
Cc: Christian Brauner <brauner@kernel.org>,
	Al Viro <viro@zeniv.linux.org.uk>,
	David Sterba <dsterba@suse.com>, Jan Kara <jack@suse.cz>,
	Mike Marshall <hubcap@omnibond.com>,
	Martin Brandenburg <martin@omnibond.com>,
	Carlos Maiolino <cem@kernel.org>, Stefan Roesch <shr@fb.com>,
	Jeff Layton <jlayton@kernel.org>,
	Trond Myklebust <trondmy@kernel.org>,
	Anna Schumaker <anna@kernel.org>,
	linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org, gfs2@lists.linux.dev,
	io-uring@vger.kernel.org, devel@lists.orangefs.org,
	linux-unionfs@vger.kernel.org, linux-mtd@lists.infradead.org,
	linux-xfs@vger.kernel.org, linux-nfs@vger.kernel.org
Subject: Re: [PATCH 04/11] fat: cleanup the flags for fat_truncate_time
Date: Tue, 06 Jan 2026 19:45:17 +0900	[thread overview]
Message-ID: <87cy3nrpdu.fsf@mail.parknet.co.jp> (raw)
In-Reply-To: <20260106075008.1610195-5-hch@lst.de>

Christoph Hellwig <hch@lst.de> writes:

> Fat only has a single on-disk timestamp covering ctime and mtime.  Add
> fat-specific flags that indicate which timestamp fat_truncate_time should
> update to make this more clear.  This allows removing no-op
> fat_truncate_time calls with the S_CTIME flag and prepares for removing
> the S_* flags.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>

This breaks fat_update_time() by calling fat_truncate_time() with old
S_* flags (later patch looks like fixing though). Please add the commit
comment about it, or fix it in this patch.

Thanks.
-- 
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  reply	other threads:[~2026-01-06 10:45 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-06  7:49 re-enable IOCB_NOWAIT writes to files v5 Christoph Hellwig
2026-01-06  7:49 ` Christoph Hellwig
2026-01-06  7:49 ` [PATCH 01/11] fs: remove inode_update_time Christoph Hellwig
2026-01-06  7:49   ` Christoph Hellwig
2026-01-06  7:49 ` [PATCH 02/11] fs: allow error returns from generic_update_time Christoph Hellwig
2026-01-06  7:49   ` Christoph Hellwig
2026-01-06  7:49 ` [PATCH 03/11] nfs: split nfs_update_timestamps Christoph Hellwig
2026-01-06  7:49   ` Christoph Hellwig
2026-01-06 11:25   ` Jan Kara
2026-01-06 11:25     ` Jan Kara
2026-01-06 11:40   ` Jeff Layton
2026-01-06 11:40     ` Jeff Layton
2026-01-06  7:49 ` [PATCH 04/11] fat: cleanup the flags for fat_truncate_time Christoph Hellwig
2026-01-06  7:49   ` Christoph Hellwig
2026-01-06 10:45   ` OGAWA Hirofumi [this message]
2026-01-06 10:45     ` OGAWA Hirofumi
2026-01-06 17:55     ` OGAWA Hirofumi
2026-01-06 17:55       ` OGAWA Hirofumi
2026-01-07  7:43       ` Christoph Hellwig
2026-01-07  7:43         ` Christoph Hellwig
2026-01-06  7:49 ` [PATCH 05/11] fs: refactor ->update_time handling Christoph Hellwig
2026-01-06  7:49   ` Christoph Hellwig
2026-01-06 11:48   ` Jan Kara
2026-01-06 11:48     ` Jan Kara
2026-01-07  7:35     ` Christoph Hellwig
2026-01-07  7:35       ` Christoph Hellwig
2026-01-06 12:09   ` Jeff Layton
2026-01-06 12:09     ` Jeff Layton
2026-01-07  7:36     ` Christoph Hellwig
2026-01-07  7:36       ` Christoph Hellwig
2026-01-06  7:50 ` [PATCH 06/11] fs: factor out a sync_lazytime helper Christoph Hellwig
2026-01-06  7:50   ` Christoph Hellwig
2026-01-06  7:50 ` [PATCH 07/11] fs: add a ->sync_lazytime method Christoph Hellwig
2026-01-06  7:50   ` Christoph Hellwig
2026-01-06  7:50 ` [PATCH 08/11] fs: add support for non-blocking timestamp updates Christoph Hellwig
2026-01-06  7:50   ` Christoph Hellwig
2026-01-06 11:58   ` Jan Kara
2026-01-06 11:58     ` Jan Kara
2026-01-06 12:13   ` Jeff Layton
2026-01-06 12:13     ` Jeff Layton
2026-01-06  7:50 ` [PATCH 09/11] fs: refactor file_update_time_flags Christoph Hellwig
2026-01-06  7:50   ` Christoph Hellwig
2026-01-06 11:51   ` Jan Kara
2026-01-06 11:51     ` Jan Kara
2026-01-06 12:15   ` Jeff Layton
2026-01-06 12:15     ` Jeff Layton
2026-01-06  7:50 ` [PATCH 10/11] xfs: implement ->sync_lazytime Christoph Hellwig
2026-01-06  7:50   ` Christoph Hellwig
2026-01-06  7:50 ` [PATCH 11/11] xfs: enable non-blocking timestamp updates Christoph Hellwig
2026-01-06  7:50   ` Christoph Hellwig
  -- strict thread matches above, loose matches on Subject: below --
2026-01-08 14:19 re-enable IOCB_NOWAIT writes to files v6 Christoph Hellwig
2026-01-08 14:19 ` [PATCH 04/11] fat: cleanup the flags for fat_truncate_time Christoph Hellwig
2026-01-08 14:19   ` Christoph Hellwig
2026-01-06  7:44 re-enable IOCB_NOWAIT writes to files v5 Christoph Hellwig
2026-01-06  7:44 ` [PATCH 04/11] fat: cleanup the flags for fat_truncate_time Christoph Hellwig
2026-01-06  7:44   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87cy3nrpdu.fsf@mail.parknet.co.jp \
    --to=hirofumi@mail.parknet.co.jp \
    --cc=anna@kernel.org \
    --cc=brauner@kernel.org \
    --cc=cem@kernel.org \
    --cc=devel@lists.orangefs.org \
    --cc=dsterba@suse.com \
    --cc=gfs2@lists.linux.dev \
    --cc=hch@lst.de \
    --cc=hubcap@omnibond.com \
    --cc=io-uring@vger.kernel.org \
    --cc=jack@suse.cz \
    --cc=jlayton@kernel.org \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=linux-unionfs@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=martin@omnibond.com \
    --cc=shr@fb.com \
    --cc=trondmy@kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.