All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mattijs Korpershoek <mkorpershoek@kernel.org>
To: Quentin Schulz <foss+uboot@0leil.net>,
	Heinrich Schuchardt <xypron.glpk@gmx.de>,
	Jerome Forissier <jerome.forissier@linaro.org>,
	Simon Glass <sjg@chromium.org>,
	u-boot@lists.denx.de
Cc: Tom Rini <trini@konsulko.com>,
	Mattijs Korpershoek <mkorpershoek@kernel.org>,
	David Lechner <dlechner@baylibre.com>,
	Quentin Schulz <quentin.schulz@cherry.de>
Subject: Re: [PATCH] doc: pytest: fix typo in multiple config options example for buildconfigspec
Date: Thu, 18 Dec 2025 12:00:59 +0100	[thread overview]
Message-ID: <87cy4ccavo.fsf@kernel.org> (raw)
In-Reply-To: <20251217-doc-pytest-lwip-v1-1-bdcaa59d4154@cherry.de>

Hi Quentin,

Thank you for the patch.

On Wed, Dec 17, 2025 at 15:02, Quentin Schulz <foss+uboot@0leil.net> wrote:

> From: Quentin Schulz <quentin.schulz@cherry.de>
>
> The option should be 'net_lwip' and not 'net lwip' (see all usage of it
> in the test code base).
>
> Fixes: 2bac578c5aba ("test: allow multiple config options in buildconfigspec")
> Signed-off-by: Quentin Schulz <quentin.schulz@cherry.de>

Reviewed-by: Mattijs Korpershoek <mkorpershoek@kernel.org>

> ---
>  doc/develop/pytest/usage.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/doc/develop/pytest/usage.rst b/doc/develop/pytest/usage.rst
> index df3821da20d..924bc185b51 100644
> --- a/doc/develop/pytest/usage.rst
> +++ b/doc/develop/pytest/usage.rst
> @@ -546,7 +546,7 @@ either of ``CONFIG_NET`` or ``CONFIG_NET_LWIP`` is set:
>  
>  .. code-block:: python
>  
> -    @pytest.mark.buildconfigspec('net', 'net lwip')
> +    @pytest.mark.buildconfigspec('net', 'net_lwip')
>  
>  The ``notbuildconfigspec()`` annotation can be used to require a configuration
>  option not to be set. The following annotation requires ``CONFIG_RISCV=n``:
>
> ---
> base-commit: 47b50fb1125c539d80ed3e7f739c02c6486e1b52
> change-id: 20251217-doc-pytest-lwip-9a34f21454c9
>
> Best regards,
> -- 
> Quentin Schulz <quentin.schulz@cherry.de>

  parent reply	other threads:[~2025-12-18 11:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-17 14:02 [PATCH] doc: pytest: fix typo in multiple config options example for buildconfigspec Quentin Schulz
2025-12-17 14:47 ` Jérôme Forissier
2025-12-18 11:00 ` Mattijs Korpershoek [this message]
2025-12-18 19:51 ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87cy4ccavo.fsf@kernel.org \
    --to=mkorpershoek@kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=foss+uboot@0leil.net \
    --cc=jerome.forissier@linaro.org \
    --cc=quentin.schulz@cherry.de \
    --cc=sjg@chromium.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=xypron.glpk@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.