* [PATCH] doc: pytest: fix typo in multiple config options example for buildconfigspec
@ 2025-12-17 14:02 Quentin Schulz
2025-12-17 14:47 ` Jérôme Forissier
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Quentin Schulz @ 2025-12-17 14:02 UTC (permalink / raw)
To: Heinrich Schuchardt, Jerome Forissier, Simon Glass, u-boot
Cc: Tom Rini, Mattijs Korpershoek, David Lechner, Quentin Schulz
From: Quentin Schulz <quentin.schulz@cherry.de>
The option should be 'net_lwip' and not 'net lwip' (see all usage of it
in the test code base).
Fixes: 2bac578c5aba ("test: allow multiple config options in buildconfigspec")
Signed-off-by: Quentin Schulz <quentin.schulz@cherry.de>
---
doc/develop/pytest/usage.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/develop/pytest/usage.rst b/doc/develop/pytest/usage.rst
index df3821da20d..924bc185b51 100644
--- a/doc/develop/pytest/usage.rst
+++ b/doc/develop/pytest/usage.rst
@@ -546,7 +546,7 @@ either of ``CONFIG_NET`` or ``CONFIG_NET_LWIP`` is set:
.. code-block:: python
- @pytest.mark.buildconfigspec('net', 'net lwip')
+ @pytest.mark.buildconfigspec('net', 'net_lwip')
The ``notbuildconfigspec()`` annotation can be used to require a configuration
option not to be set. The following annotation requires ``CONFIG_RISCV=n``:
---
base-commit: 47b50fb1125c539d80ed3e7f739c02c6486e1b52
change-id: 20251217-doc-pytest-lwip-9a34f21454c9
Best regards,
--
Quentin Schulz <quentin.schulz@cherry.de>
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] doc: pytest: fix typo in multiple config options example for buildconfigspec
2025-12-17 14:02 [PATCH] doc: pytest: fix typo in multiple config options example for buildconfigspec Quentin Schulz
@ 2025-12-17 14:47 ` Jérôme Forissier
2025-12-18 11:00 ` Mattijs Korpershoek
2025-12-18 19:51 ` Tom Rini
2 siblings, 0 replies; 4+ messages in thread
From: Jérôme Forissier @ 2025-12-17 14:47 UTC (permalink / raw)
To: Quentin Schulz
Cc: Heinrich Schuchardt, Simon Glass, u-boot, Tom Rini,
Mattijs Korpershoek, David Lechner, Quentin Schulz
On Wed, 17 Dec 2025 at 15:02, Quentin Schulz <foss+uboot@0leil.net> wrote:
>
> From: Quentin Schulz <quentin.schulz@cherry.de>
>
> The option should be 'net_lwip' and not 'net lwip' (see all usage of it
> in the test code base).
>
> Fixes: 2bac578c5aba ("test: allow multiple config options in buildconfigspec")
> Signed-off-by: Quentin Schulz <quentin.schulz@cherry.de>
> ---
> doc/develop/pytest/usage.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Thanks,
--
Jerome
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] doc: pytest: fix typo in multiple config options example for buildconfigspec
2025-12-17 14:02 [PATCH] doc: pytest: fix typo in multiple config options example for buildconfigspec Quentin Schulz
2025-12-17 14:47 ` Jérôme Forissier
@ 2025-12-18 11:00 ` Mattijs Korpershoek
2025-12-18 19:51 ` Tom Rini
2 siblings, 0 replies; 4+ messages in thread
From: Mattijs Korpershoek @ 2025-12-18 11:00 UTC (permalink / raw)
To: Quentin Schulz, Heinrich Schuchardt, Jerome Forissier,
Simon Glass, u-boot
Cc: Tom Rini, Mattijs Korpershoek, David Lechner, Quentin Schulz
Hi Quentin,
Thank you for the patch.
On Wed, Dec 17, 2025 at 15:02, Quentin Schulz <foss+uboot@0leil.net> wrote:
> From: Quentin Schulz <quentin.schulz@cherry.de>
>
> The option should be 'net_lwip' and not 'net lwip' (see all usage of it
> in the test code base).
>
> Fixes: 2bac578c5aba ("test: allow multiple config options in buildconfigspec")
> Signed-off-by: Quentin Schulz <quentin.schulz@cherry.de>
Reviewed-by: Mattijs Korpershoek <mkorpershoek@kernel.org>
> ---
> doc/develop/pytest/usage.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/doc/develop/pytest/usage.rst b/doc/develop/pytest/usage.rst
> index df3821da20d..924bc185b51 100644
> --- a/doc/develop/pytest/usage.rst
> +++ b/doc/develop/pytest/usage.rst
> @@ -546,7 +546,7 @@ either of ``CONFIG_NET`` or ``CONFIG_NET_LWIP`` is set:
>
> .. code-block:: python
>
> - @pytest.mark.buildconfigspec('net', 'net lwip')
> + @pytest.mark.buildconfigspec('net', 'net_lwip')
>
> The ``notbuildconfigspec()`` annotation can be used to require a configuration
> option not to be set. The following annotation requires ``CONFIG_RISCV=n``:
>
> ---
> base-commit: 47b50fb1125c539d80ed3e7f739c02c6486e1b52
> change-id: 20251217-doc-pytest-lwip-9a34f21454c9
>
> Best regards,
> --
> Quentin Schulz <quentin.schulz@cherry.de>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] doc: pytest: fix typo in multiple config options example for buildconfigspec
2025-12-17 14:02 [PATCH] doc: pytest: fix typo in multiple config options example for buildconfigspec Quentin Schulz
2025-12-17 14:47 ` Jérôme Forissier
2025-12-18 11:00 ` Mattijs Korpershoek
@ 2025-12-18 19:51 ` Tom Rini
2 siblings, 0 replies; 4+ messages in thread
From: Tom Rini @ 2025-12-18 19:51 UTC (permalink / raw)
To: Heinrich Schuchardt, Jerome Forissier, Simon Glass, u-boot,
Quentin Schulz
Cc: Mattijs Korpershoek, David Lechner, Quentin Schulz
On Wed, 17 Dec 2025 15:02:27 +0100, Quentin Schulz wrote:
> The option should be 'net_lwip' and not 'net lwip' (see all usage of it
> in the test code base).
>
>
Applied to u-boot/master, thanks!
[1/1] doc: pytest: fix typo in multiple config options example for buildconfigspec
commit: 24ab2b9684d72af960a7145a88c34ab0ec801c84
--
Tom
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-12-18 19:52 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-17 14:02 [PATCH] doc: pytest: fix typo in multiple config options example for buildconfigspec Quentin Schulz
2025-12-17 14:47 ` Jérôme Forissier
2025-12-18 11:00 ` Mattijs Korpershoek
2025-12-18 19:51 ` Tom Rini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.