All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: George Moussalem <george.moussalem@outlook.com>
Cc: Ziyang Huang <hzyitc@outlook.com>,
	 quic_mdalam@quicinc.com, richard@nod.at,  vigneshr@ti.com,
	 tudor.ambarus@linaro.org, mmkurbanov@salutedevices.com,
	 linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Revert "mtd: spinand: esmt: fix id code for F50D1G41LB"
Date: Tue, 16 Dec 2025 09:07:56 +0100	[thread overview]
Message-ID: <87cy4esvc3.fsf@bootlin.com> (raw)
In-Reply-To: <BL4PR19MB8902CF825EF35C4F145300BF9DA2A@BL4PR19MB8902.namprd19.prod.outlook.com> (George Moussalem's message of "Mon, 8 Dec 2025 13:26:21 +0400")

Hi,

>>> This reverts commit dd26402642a0899fde59ea6b0852fad3d799b4cc.
>>>
>>> The issue George met is due to the limit of QPIC, not the issue of the
>>> flash chip.
>>>
>>> QPIC only supports 4 bytes ID. So the fifth byte is always 0.
>>>
>>> If we use spi-gpio, the fifth byte can be read correctly.
>>>
>>> Signed-off-by: Ziyang Huang <hzyitc@outlook.com>
>>> ---
>> 
>> So how do we solve that?
>> 
>> Is there anything than can be done on the qpic side?
>
> Hi Alam,
>
> Is the hardware itself limited to reading 4 ID bytes only or is it a
> driver limitation?

FYI I will pick the revert, because indeed the original fix is wrong and
any device with 5 ID bytes would need a similar change (which is not
possible), and let you figure out a quirk for the Qpic driver.

Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: George Moussalem <george.moussalem@outlook.com>
Cc: Ziyang Huang <hzyitc@outlook.com>,
	 quic_mdalam@quicinc.com, richard@nod.at,  vigneshr@ti.com,
	 tudor.ambarus@linaro.org, mmkurbanov@salutedevices.com,
	 linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Revert "mtd: spinand: esmt: fix id code for F50D1G41LB"
Date: Tue, 16 Dec 2025 09:07:56 +0100	[thread overview]
Message-ID: <87cy4esvc3.fsf@bootlin.com> (raw)
In-Reply-To: <BL4PR19MB8902CF825EF35C4F145300BF9DA2A@BL4PR19MB8902.namprd19.prod.outlook.com> (George Moussalem's message of "Mon, 8 Dec 2025 13:26:21 +0400")

Hi,

>>> This reverts commit dd26402642a0899fde59ea6b0852fad3d799b4cc.
>>>
>>> The issue George met is due to the limit of QPIC, not the issue of the
>>> flash chip.
>>>
>>> QPIC only supports 4 bytes ID. So the fifth byte is always 0.
>>>
>>> If we use spi-gpio, the fifth byte can be read correctly.
>>>
>>> Signed-off-by: Ziyang Huang <hzyitc@outlook.com>
>>> ---
>> 
>> So how do we solve that?
>> 
>> Is there anything than can be done on the qpic side?
>
> Hi Alam,
>
> Is the hardware itself limited to reading 4 ID bytes only or is it a
> driver limitation?

FYI I will pick the revert, because indeed the original fix is wrong and
any device with 5 ID bytes would need a similar change (which is not
possible), and let you figure out a quirk for the Qpic driver.

Thanks,
Miquèl

  parent reply	other threads:[~2025-12-16  8:08 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-02 15:05 [PATCH] Revert "mtd: spinand: esmt: fix id code for F50D1G41LB" Ziyang Huang
2025-12-02 15:05 ` Ziyang Huang
2025-12-08  8:33 ` Miquel Raynal
2025-12-08  8:33   ` Miquel Raynal
2025-12-08  9:26   ` George Moussalem
2025-12-08  9:26     ` George Moussalem
2025-12-08 10:26     ` Md Sadre Alam
2025-12-08 10:26       ` Md Sadre Alam
2025-12-16  8:07     ` Miquel Raynal [this message]
2025-12-16  8:07       ` Miquel Raynal
2025-12-12 14:53   ` Ziyang Huang
2025-12-12 14:53     ` Ziyang Huang
2025-12-16  8:09 ` Miquel Raynal
2025-12-16  8:09   ` Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87cy4esvc3.fsf@bootlin.com \
    --to=miquel.raynal@bootlin.com \
    --cc=george.moussalem@outlook.com \
    --cc=hzyitc@outlook.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=mmkurbanov@salutedevices.com \
    --cc=quic_mdalam@quicinc.com \
    --cc=richard@nod.at \
    --cc=tudor.ambarus@linaro.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.