From: Peter Korsgaard <peter@korsgaard.com>
To: Thomas Perale via buildroot <buildroot@buildroot.org>
Cc: Thomas Perale <thomas.perale@mind.be>,
Angelo Compagnucci <angelo.compagnucci@gmail.com>
Subject: Re: [Buildroot] [PATCH] package/libapparmor: remove stale reference to patch 0001
Date: Sun, 10 Aug 2025 20:21:34 +0200 [thread overview]
Message-ID: <87cy93ox5d.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20250809175417.315091-1-thomas.perale@mind.be> (Thomas Perale via buildroot's message of "Sat, 9 Aug 2025 19:54:17 +0200")
>>>>> "Thomas" == Thomas Perale via buildroot <buildroot@buildroot.org> writes:
> The AUTORECONF variable was introduced in commit [1] with reference to
> the patches that modified the m4 and Makefile.am files.
> The commit [2] removed the last such patch but left the reference to the
> patch and the AUTORECONF variable.
> Later, commit [3] updated the mirror to the gitlab URL that no longer
> bundle a pre-generated `configure` file, making the execution of
> AUTORECONF necessary anyway.
> This patch removes the obsolete reference to the patch 0001 removed in
> [2] to avoid ambiguity with the new patch 0001 introduced in commit [4].
> [1] 01a82c1401 package/libapparmor: enable python bindings
> [2] 27cd0b5033 package/apparmor: bump to version 3.0.4
> [3] 5649202ddc package/libapparmor: bump to version 3.1.7
> [4] 2640f5dcd0 package/libapparmor: fix build w/ musl
> Signed-off-by: Thomas Perale <thomas.perale@mind.be>
> ---
> package/libapparmor/libapparmor.mk | 1 -
> 1 file changed, 1 deletion(-)
> diff --git a/package/libapparmor/libapparmor.mk b/package/libapparmor/libapparmor.mk
> index fa59ff2924..b1c9a952f0 100644
> --- a/package/libapparmor/libapparmor.mk
> +++ b/package/libapparmor/libapparmor.mk
> @@ -16,7 +16,6 @@ LIBAPPARMOR_DEPENDENCIES = host-bison host-flex host-pkgconf
> LIBAPPARMOR_SUBDIR = libraries/libapparmor
> LIBAPPARMOR_INSTALL_STAGING = YES
> -# Patch 0001 touches Makefile.am and m4 files
> LIBAPPARMOR_AUTORECONF = YES
I replaced the comment with another one saying:
# no configure in tarball
To make it clear why this is needed and committed, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2025-08-10 18:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-09 17:54 [Buildroot] [PATCH] package/libapparmor: remove stale reference to patch 0001 Thomas Perale via buildroot
2025-08-09 20:59 ` Romain Naour via buildroot
2025-08-10 18:21 ` Peter Korsgaard [this message]
2025-08-14 20:32 ` Thomas Perale via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cy93ox5d.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=angelo.compagnucci@gmail.com \
--cc=buildroot@buildroot.org \
--cc=thomas.perale@mind.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.