[Buildroot] [PATCH] package/libapparmor: remove stale reference to patch 0001

[Buildroot] [PATCH] package/libapparmor: remove stale reference to patch 0001

[Thomas Perale via buildroot]

The AUTORECONF variable was introduced in commit [1] with reference to
the patches that modified the m4 and Makefile.am files.

The commit [2] removed the last such patch but left the reference to the
patch and the AUTORECONF variable.

Later, commit [3] updated the mirror to the gitlab URL that no longer
bundle a pre-generated `configure` file, making the execution of
AUTORECONF necessary anyway.

This patch removes the obsolete reference to the patch 0001 removed in
[2] to avoid ambiguity with the new patch 0001 introduced in commit [4].

[1] 01a82c1401 package/libapparmor: enable python bindings
[2] 27cd0b5033 package/apparmor: bump to version 3.0.4
[3] 5649202ddc package/libapparmor: bump to version 3.1.7
[4] 2640f5dcd0 package/libapparmor: fix build w/ musl

Signed-off-by: Thomas Perale <thomas.perale@mind.be>
---
 package/libapparmor/libapparmor.mk | 1 -
 1 file changed, 1 deletion(-)

diff --git a/package/libapparmor/libapparmor.mk b/package/libapparmor/libapparmor.mk
index fa59ff2924..b1c9a952f0 100644
--- a/package/libapparmor/libapparmor.mk
+++ b/package/libapparmor/libapparmor.mk
@@ -16,7 +16,6 @@ LIBAPPARMOR_DEPENDENCIES = host-bison host-flex host-pkgconf
 LIBAPPARMOR_SUBDIR = libraries/libapparmor
 LIBAPPARMOR_INSTALL_STAGING = YES
 
-# Patch 0001 touches Makefile.am and m4 files
 LIBAPPARMOR_AUTORECONF = YES
 
 # Most AppArmor tools will want to link to the static lib.
-- 
2.50.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/libapparmor: remove stale reference to patch 0001

[Romain Naour via buildroot]

Hello Thomas, All,

Le 09/08/2025 à 19:54, Thomas Perale via buildroot a écrit :
> The AUTORECONF variable was introduced in commit [1] with reference to
> the patches that modified the m4 and Makefile.am files.
> 
> The commit [2] removed the last such patch but left the reference to the
> patch and the AUTORECONF variable.
> 
> Later, commit [3] updated the mirror to the gitlab URL that no longer
> bundle a pre-generated `configure` file, making the execution of
> AUTORECONF necessary anyway.
> 
> This patch removes the obsolete reference to the patch 0001 removed in
> [2] to avoid ambiguity with the new patch 0001 introduced in commit [4].
> 
> [1] 01a82c1401 package/libapparmor: enable python bindings
> [2] 27cd0b5033 package/apparmor: bump to version 3.0.4
> [3] 5649202ddc package/libapparmor: bump to version 3.1.7
> [4] 2640f5dcd0 package/libapparmor: fix build w/ musl
> 
> Signed-off-by: Thomas Perale <thomas.perale@mind.be>
> ---
>  package/libapparmor/libapparmor.mk | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/package/libapparmor/libapparmor.mk b/package/libapparmor/libapparmor.mk
> index fa59ff2924..b1c9a952f0 100644
> --- a/package/libapparmor/libapparmor.mk
> +++ b/package/libapparmor/libapparmor.mk
> @@ -16,7 +16,6 @@ LIBAPPARMOR_DEPENDENCIES = host-bison host-flex host-pkgconf
>  LIBAPPARMOR_SUBDIR = libraries/libapparmor
>  LIBAPPARMOR_INSTALL_STAGING = YES
>  
> -# Patch 0001 touches Makefile.am and m4 files

Thanks for the detailed analysis!

Usually we prefer a small comment to remember why we have to use AUTORECONF.

What about:

# git repo, no configure

Best regards,
Romain


>  LIBAPPARMOR_AUTORECONF = YES
>  
>  # Most AppArmor tools will want to link to the static lib.

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/libapparmor: remove stale reference to patch 0001

[Peter Korsgaard]

>>>>> "Thomas" == Thomas Perale via buildroot <buildroot@buildroot.org> writes:

 > The AUTORECONF variable was introduced in commit [1] with reference to
 > the patches that modified the m4 and Makefile.am files.

 > The commit [2] removed the last such patch but left the reference to the
 > patch and the AUTORECONF variable.

 > Later, commit [3] updated the mirror to the gitlab URL that no longer
 > bundle a pre-generated `configure` file, making the execution of
 > AUTORECONF necessary anyway.

 > This patch removes the obsolete reference to the patch 0001 removed in
 > [2] to avoid ambiguity with the new patch 0001 introduced in commit [4].

 > [1] 01a82c1401 package/libapparmor: enable python bindings
 > [2] 27cd0b5033 package/apparmor: bump to version 3.0.4
 > [3] 5649202ddc package/libapparmor: bump to version 3.1.7
 > [4] 2640f5dcd0 package/libapparmor: fix build w/ musl

 > Signed-off-by: Thomas Perale <thomas.perale@mind.be>
 > ---
 >  package/libapparmor/libapparmor.mk | 1 -
 >  1 file changed, 1 deletion(-)

 > diff --git a/package/libapparmor/libapparmor.mk b/package/libapparmor/libapparmor.mk
 > index fa59ff2924..b1c9a952f0 100644
 > --- a/package/libapparmor/libapparmor.mk
 > +++ b/package/libapparmor/libapparmor.mk
 > @@ -16,7 +16,6 @@ LIBAPPARMOR_DEPENDENCIES = host-bison host-flex host-pkgconf
 >  LIBAPPARMOR_SUBDIR = libraries/libapparmor
 >  LIBAPPARMOR_INSTALL_STAGING = YES
 
 > -# Patch 0001 touches Makefile.am and m4 files
 >  LIBAPPARMOR_AUTORECONF = YES

I replaced the comment with another one saying:

# no configure in tarball

To make it clear why this is needed and committed, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/libapparmor: remove stale reference to patch 0001

[Thomas Perale via buildroot]

In reply of:
> The AUTORECONF variable was introduced in commit [1] with reference to
> the patches that modified the m4 and Makefile.am files.
> 
> The commit [2] removed the last such patch but left the reference to the
> patch and the AUTORECONF variable.
> 
> Later, commit [3] updated the mirror to the gitlab URL that no longer
> bundle a pre-generated `configure` file, making the execution of
> AUTORECONF necessary anyway.
> 
> This patch removes the obsolete reference to the patch 0001 removed in
> [2] to avoid ambiguity with the new patch 0001 introduced in commit [4].
> 
> [1] 01a82c1401 package/libapparmor: enable python bindings
> [2] 27cd0b5033 package/apparmor: bump to version 3.0.4
> [3] 5649202ddc package/libapparmor: bump to version 3.1.7
> [4] 2640f5dcd0 package/libapparmor: fix build w/ musl
> 
> Signed-off-by: Thomas Perale <thomas.perale@mind.be>

Applied to 2025.02.x & 2025.05.x. Thanks

> ---
>  package/libapparmor/libapparmor.mk | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/package/libapparmor/libapparmor.mk b/package/libapparmor/libapparmor.mk
> index fa59ff2924..b1c9a952f0 100644
> --- a/package/libapparmor/libapparmor.mk
> +++ b/package/libapparmor/libapparmor.mk
> @@ -16,7 +16,6 @@ LIBAPPARMOR_DEPENDENCIES = host-bison host-flex host-pkgconf
>  LIBAPPARMOR_SUBDIR = libraries/libapparmor
>  LIBAPPARMOR_INSTALL_STAGING = YES
>  
> -# Patch 0001 touches Makefile.am and m4 files
>  LIBAPPARMOR_AUTORECONF = YES
>  
>  # Most AppArmor tools will want to link to the static lib.
> -- 
> 2.50.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot