* [PATCH] ALSA: hda: Remove old commented out sanity check
@ 2025-07-03 22:52 Thorsten Blum
2025-07-04 7:12 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Thorsten Blum @ 2025-07-03 22:52 UTC (permalink / raw)
To: Jaroslav Kysela, Takashi Iwai, Julia Lawall,
Dr. David Alan Gilbert, Wentao Liang
Cc: Thorsten Blum, Takashi Iwai, linux-sound, linux-kernel
The sanity check has been commented out for more than 12 years since
commit d5657ec9f4ad ("ALSA: hda - Disable the sanity check in
snd_hda_add_pincfg()") - remove it.
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
sound/pci/hda/hda_codec.c | 9 ---------
1 file changed, 9 deletions(-)
diff --git a/sound/pci/hda/hda_codec.c b/sound/pci/hda/hda_codec.c
index 5508381a1833..cb72e9655c8a 100644
--- a/sound/pci/hda/hda_codec.c
+++ b/sound/pci/hda/hda_codec.c
@@ -479,15 +479,6 @@ int snd_hda_add_pincfg(struct hda_codec *codec, struct snd_array *list,
{
struct hda_pincfg *pin;
- /* the check below may be invalid when pins are added by a fixup
- * dynamically (e.g. via snd_hda_codec_update_widgets()), so disabled
- * for now
- */
- /*
- if (get_wcaps_type(get_wcaps(codec, nid)) != AC_WID_PIN)
- return -EINVAL;
- */
-
pin = look_up_pincfg(codec, list, nid);
if (!pin) {
pin = snd_array_new(list);
--
2.50.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ALSA: hda: Remove old commented out sanity check
2025-07-03 22:52 [PATCH] ALSA: hda: Remove old commented out sanity check Thorsten Blum
@ 2025-07-04 7:12 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2025-07-04 7:12 UTC (permalink / raw)
To: Thorsten Blum
Cc: Jaroslav Kysela, Takashi Iwai, Julia Lawall,
Dr. David Alan Gilbert, Wentao Liang, Takashi Iwai, linux-sound,
linux-kernel
On Fri, 04 Jul 2025 00:52:36 +0200,
Thorsten Blum wrote:
>
> The sanity check has been commented out for more than 12 years since
> commit d5657ec9f4ad ("ALSA: hda - Disable the sanity check in
> snd_hda_add_pincfg()") - remove it.
>
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
Applied now. Thanks.
Takashi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-07-04 7:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-03 22:52 [PATCH] ALSA: hda: Remove old commented out sanity check Thorsten Blum
2025-07-04 7:12 ` Takashi Iwai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.