All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Mario Limonciello <superm1@kernel.org>
Cc: mario.limonciello@amd.com, perex@perex.cz, tiwai@suse.com,
	Takashi Iwai <tiwai@suse.de>,
	linux-sound@vger.kernel.org
Subject: Re: [PATCH v2] ALSA: usb-audio: Add a quirk for Lenovo Thinkpad Thunderbolt 3 dock
Date: Sat, 24 May 2025 09:18:36 +0200	[thread overview]
Message-ID: <87cybyschf.wl-tiwai@suse.de> (raw)
In-Reply-To: <20250523192934.1412153-1-superm1@kernel.org>

On Fri, 23 May 2025 21:29:31 +0200,
Mario Limonciello wrote:
> 
> From: Mario Limonciello <mario.limonciello@amd.com>
> 
> The audio controller in the Lenovo Thinkpad Thunderbolt 3 dock doesn't
> support reading the sampling rate.
> 
> Add a quirk for it.
> 
> Suggested-by: Takashi Iwai <tiwai@suse.de>
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>

Thanks for the renewed patch.
Just a minor thing:

> ---
>  sound/usb/quirks.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c
> index dbbc9eb935a4b..c29607091fb1c 100644
> --- a/sound/usb/quirks.c
> +++ b/sound/usb/quirks.c
> @@ -2360,6 +2360,8 @@ static const struct usb_audio_quirk_flags_table quirk_flags_table[] = {
>  		   QUIRK_FLAG_ALIGN_TRANSFER),
>  	DEVICE_FLG(0x534d, 0x2109, /* MacroSilicon MS2109 */
>  		   QUIRK_FLAG_ALIGN_TRANSFER),
> +	DEVICE_FLG(0x17ef, 0x3083, /* Lenovo TBT3 dock */
> +		   QUIRK_FLAG_GET_SAMPLE_RATE),

The table is sorted in the ID number order.
Could you put the new entry at the right position?


Takashi

      reply	other threads:[~2025-05-24  7:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-23 19:29 [PATCH v2] ALSA: usb-audio: Add a quirk for Lenovo Thinkpad Thunderbolt 3 dock Mario Limonciello
2025-05-24  7:18 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87cybyschf.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=linux-sound@vger.kernel.org \
    --cc=mario.limonciello@amd.com \
    --cc=perex@perex.cz \
    --cc=superm1@kernel.org \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.