* [PATCH v2] ALSA: usb-audio: Add a quirk for Lenovo Thinkpad Thunderbolt 3 dock
@ 2025-05-23 19:29 Mario Limonciello
2025-05-24 7:18 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Mario Limonciello @ 2025-05-23 19:29 UTC (permalink / raw)
To: mario.limonciello, perex, tiwai; +Cc: Takashi Iwai, linux-sound
From: Mario Limonciello <mario.limonciello@amd.com>
The audio controller in the Lenovo Thinkpad Thunderbolt 3 dock doesn't
support reading the sampling rate.
Add a quirk for it.
Suggested-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
---
sound/usb/quirks.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c
index dbbc9eb935a4b..c29607091fb1c 100644
--- a/sound/usb/quirks.c
+++ b/sound/usb/quirks.c
@@ -2360,6 +2360,8 @@ static const struct usb_audio_quirk_flags_table quirk_flags_table[] = {
QUIRK_FLAG_ALIGN_TRANSFER),
DEVICE_FLG(0x534d, 0x2109, /* MacroSilicon MS2109 */
QUIRK_FLAG_ALIGN_TRANSFER),
+ DEVICE_FLG(0x17ef, 0x3083, /* Lenovo TBT3 dock */
+ QUIRK_FLAG_GET_SAMPLE_RATE),
/* Vendor matches */
VENDOR_FLG(0x045e, /* MS Lifecam */
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH v2] ALSA: usb-audio: Add a quirk for Lenovo Thinkpad Thunderbolt 3 dock
2025-05-23 19:29 [PATCH v2] ALSA: usb-audio: Add a quirk for Lenovo Thinkpad Thunderbolt 3 dock Mario Limonciello
@ 2025-05-24 7:18 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2025-05-24 7:18 UTC (permalink / raw)
To: Mario Limonciello
Cc: mario.limonciello, perex, tiwai, Takashi Iwai, linux-sound
On Fri, 23 May 2025 21:29:31 +0200,
Mario Limonciello wrote:
>
> From: Mario Limonciello <mario.limonciello@amd.com>
>
> The audio controller in the Lenovo Thinkpad Thunderbolt 3 dock doesn't
> support reading the sampling rate.
>
> Add a quirk for it.
>
> Suggested-by: Takashi Iwai <tiwai@suse.de>
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
Thanks for the renewed patch.
Just a minor thing:
> ---
> sound/usb/quirks.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c
> index dbbc9eb935a4b..c29607091fb1c 100644
> --- a/sound/usb/quirks.c
> +++ b/sound/usb/quirks.c
> @@ -2360,6 +2360,8 @@ static const struct usb_audio_quirk_flags_table quirk_flags_table[] = {
> QUIRK_FLAG_ALIGN_TRANSFER),
> DEVICE_FLG(0x534d, 0x2109, /* MacroSilicon MS2109 */
> QUIRK_FLAG_ALIGN_TRANSFER),
> + DEVICE_FLG(0x17ef, 0x3083, /* Lenovo TBT3 dock */
> + QUIRK_FLAG_GET_SAMPLE_RATE),
The table is sorted in the ID number order.
Could you put the new entry at the right position?
Takashi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-05-24 7:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-23 19:29 [PATCH v2] ALSA: usb-audio: Add a quirk for Lenovo Thinkpad Thunderbolt 3 dock Mario Limonciello
2025-05-24 7:18 ` Takashi Iwai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.